This repository was archived by the owner on Mar 23, 2026. It is now read-only.
fix: throw jobexception for invalid multiple statements query#732
Merged
stephaniewang526 merged 2 commits intogoogleapis:masterfrom Sep 17, 2020
Merged
fix: throw jobexception for invalid multiple statements query#732stephaniewang526 merged 2 commits intogoogleapis:masterfrom
stephaniewang526 merged 2 commits intogoogleapis:masterfrom
Conversation
add another test case add exception checking Job class update reload() method
c91ddd3 to
946de7b
Compare
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
============================================
+ Coverage 81.07% 81.15% +0.08%
- Complexity 1236 1240 +4
============================================
Files 78 78
Lines 6334 6341 +7
Branches 705 708 +3
============================================
+ Hits 5135 5146 +11
+ Misses 833 828 -5
- Partials 366 367 +1
Continue to review full report at Codecov.
|
shollyman
approved these changes
Sep 16, 2020
Contributor
shollyman
left a comment
There was a problem hiding this comment.
Could you expand on what's going on here in the PR description? I see you're adding a new raise to the reload, is this to match behavior from something else?
Contributor
Author
Indeed! Customer noticed that we are throwing Exception in invalid single-statement scenario but not invalid Multi-statement scenario. We are trying to make the behavior consistent here. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 17, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.118.0](https://www.github.com/googleapis/java-bigquery/compare/v1.117.2...v1.118.0) (2020-09-17) ### Features * **bigquery:** explicitly ask for dense responses from HTTP backend ([#739](https://www.github.com/googleapis/java-bigquery/issues/739)) ([8c92c99](https://www.github.com/googleapis/java-bigquery/commit/8c92c9919b278bdb128be963391fc1870e69e343)) ### Bug Fixes * throw jobexception for invalid multiple statements query ([#732](https://www.github.com/googleapis/java-bigquery/issues/732)) ([2a0d86d](https://www.github.com/googleapis/java-bigquery/commit/2a0d86d2d07dd706fb7d943da6ebd5c9ac98dfca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes b/163347694