Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Commit 8c92c99

Browse files
shollymanshollyman
authored
feat(bigquery): explicitly ask for dense responses from HTTP backend (#739)
This change alters HTTP response behavior by eliding unnecessary whitespace from JSON responses.
1 parent 2a0d86d commit 8c92c99

File tree

1 file changed

+47
-5
lines changed

1 file changed

+47
-5
lines changed

‎google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java‎

Lines changed: 47 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ public Dataset getDataset(String projectId, String datasetId, Map<Option, ?> opt
120120
.datasets()
121121
.get(projectId, datasetId)
122122
.setFields(Option.FIELDS.getString(options))
123+
.setPrettyPrint(false)
123124
.execute();
124125
} catch (IOException ex) {
125126
BigQueryException serviceException = translate(ex);
@@ -137,6 +138,7 @@ public Tuple<String, Iterable<Dataset>> listDatasets(String projectId, Map<Optio
137138
bigquery
138139
.datasets()
139140
.list(projectId)
141+
.setPrettyPrint(false)
140142
.setAll(Option.ALL_DATASETS.getBoolean(options))
141143
.setFilter(Option.LABEL_FILTER.getString(options))
142144
.setMaxResults(Option.MAX_RESULTS.getLong(options))
@@ -160,6 +162,7 @@ public Dataset create(Dataset dataset, Map<Option, ?> options) {
160162
return bigquery
161163
.datasets()
162164
.insert(dataset.getDatasetReference().getProjectId(), dataset)
165+
.setPrettyPrint(false)
163166
.setFields(Option.FIELDS.getString(options))
164167
.execute();
165168
} catch (IOException ex) {
@@ -176,6 +179,7 @@ public Table create(Table table, Map<Option, ?> options) {
176179
return bigquery
177180
.tables()
178181
.insert(reference.getProjectId(), reference.getDatasetId(), table)
182+
.setPrettyPrint(false)
179183
.setFields(Option.FIELDS.getString(options))
180184
.execute();
181185
} catch (IOException ex) {
@@ -190,6 +194,7 @@ public Routine create(Routine routine, Map<Option, ?> options) {
190194
return bigquery
191195
.routines()
192196
.insert(reference.getProjectId(), reference.getDatasetId(), routine)
197+
.setPrettyPrint(false)
193198
.setFields(Option.FIELDS.getString(options))
194199
.execute();
195200
} catch (IOException ex) {
@@ -207,6 +212,7 @@ public Job create(Job job, Map<Option, ?> options) {
207212
return bigquery
208213
.jobs()
209214
.insert(projectId, job)
215+
.setPrettyPrint(false)
210216
.setFields(Option.FIELDS.getString(options))
211217
.execute();
212218
} catch (IOException ex) {
@@ -220,6 +226,7 @@ public boolean deleteDataset(String projectId, String datasetId, Map<Option, ?>
220226
bigquery
221227
.datasets()
222228
.delete(projectId, datasetId)
229+
.setPrettyPrint(false)
223230
.setDeleteContents(Option.DELETE_CONTENTS.getBoolean(options))
224231
.execute();
225232
return true;
@@ -239,6 +246,7 @@ public Dataset patch(Dataset dataset, Map<Option, ?> options) {
239246
return bigquery
240247
.datasets()
241248
.patch(reference.getProjectId(), reference.getDatasetId(), dataset)
249+
.setPrettyPrint(false)
242250
.setFields(Option.FIELDS.getString(options))
243251
.execute();
244252
} catch (IOException ex) {
@@ -255,6 +263,7 @@ public Table patch(Table table, Map<Option, ?> options) {
255263
return bigquery
256264
.tables()
257265
.patch(reference.getProjectId(), reference.getDatasetId(), reference.getTableId(), table)
266+
.setPrettyPrint(false)
258267
.setFields(Option.FIELDS.getString(options))
259268
.execute();
260269
} catch (IOException ex) {
@@ -269,6 +278,7 @@ public Table getTable(
269278
return bigquery
270279
.tables()
271280
.get(projectId, datasetId, tableId)
281+
.setPrettyPrint(false)
272282
.setFields(Option.FIELDS.getString(options))
273283
.execute();
274284
} catch (IOException ex) {
@@ -288,6 +298,7 @@ public Tuple<String, Iterable<Table>> listTables(
288298
bigquery
289299
.tables()
290300
.list(projectId, datasetId)
301+
.setPrettyPrint(false)
291302
.setMaxResults(Option.MAX_RESULTS.getLong(options))
292303
.setPageToken(Option.PAGE_TOKEN.getString(options))
293304
.execute();
@@ -337,6 +348,7 @@ public Model patch(Model model, Map<Option, ?> options) {
337348
return bigquery
338349
.models()
339350
.patch(reference.getProjectId(), reference.getDatasetId(), reference.getModelId(), model)
351+
.setPrettyPrint(false)
340352
.setFields(Option.FIELDS.getString(options))
341353
.execute();
342354
} catch (IOException ex) {
@@ -351,6 +363,7 @@ public Model getModel(
351363
return bigquery
352364
.models()
353365
.get(projectId, datasetId, modelId)
366+
.setPrettyPrint(false)
354367
.setFields(Option.FIELDS.getString(options))
355368
.execute();
356369
} catch (IOException ex) {
@@ -370,6 +383,7 @@ public Tuple<String, Iterable<Model>> listModels(
370383
bigquery
371384
.models()
372385
.list(projectId, datasetId)
386+
.setPrettyPrint(false)
373387
.setMaxResults(Option.MAX_RESULTS.getLong(options))
374388
.setPageToken(Option.PAGE_TOKEN.getString(options))
375389
.execute();
@@ -402,6 +416,7 @@ public Routine update(Routine routine, Map<Option, ?> options) {
402416
.routines()
403417
.update(
404418
reference.getProjectId(), reference.getDatasetId(), reference.getRoutineId(), routine)
419+
.setPrettyPrint(false)
405420
.setFields(Option.FIELDS.getString(options))
406421
.execute();
407422
} catch (IOException ex) {
@@ -416,6 +431,7 @@ public Routine getRoutine(
416431
return bigquery
417432
.routines()
418433
.get(projectId, datasetId, routineId)
434+
.setPrettyPrint(false)
419435
.setFields(Option.FIELDS.getString(options))
420436
.execute();
421437
} catch (IOException ex) {
@@ -435,6 +451,7 @@ public Tuple<String, Iterable<Routine>> listRoutines(
435451
bigquery
436452
.routines()
437453
.list(projectId, datasetId)
454+
.setPrettyPrint(false)
438455
.setMaxResults(Option.MAX_RESULTS.getLong(options))
439456
.setPageToken(Option.PAGE_TOKEN.getString(options))
440457
.execute();
@@ -463,7 +480,11 @@ public boolean deleteRoutine(String projectId, String datasetId, String routineI
463480
public TableDataInsertAllResponse insertAll(
464481
String projectId, String datasetId, String tableId, TableDataInsertAllRequest request) {
465482
try {
466-
return bigquery.tabledata().insertAll(projectId, datasetId, tableId, request).execute();
483+
return bigquery
484+
.tabledata()
485+
.insertAll(projectId, datasetId, tableId, request)
486+
.setPrettyPrint(false)
487+
.execute();
467488
} catch (IOException ex) {
468489
throw translate(ex);
469490
}
@@ -476,6 +497,7 @@ public TableDataList listTableData(
476497
return bigquery
477498
.tabledata()
478499
.list(projectId, datasetId, tableId)
500+
.setPrettyPrint(false)
479501
.setMaxResults(Option.MAX_RESULTS.getLong(options))
480502
.setPageToken(Option.PAGE_TOKEN.getString(options))
481503
.setStartIndex(
@@ -494,6 +516,7 @@ public Job getJob(String projectId, String jobId, String location, Map<Option, ?
494516
return bigquery
495517
.jobs()
496518
.get(projectId, jobId)
519+
.setPrettyPrint(false)
497520
.setLocation(location)
498521
.setFields(Option.FIELDS.getString(options))
499522
.execute();
@@ -513,6 +536,7 @@ public Tuple<String, Iterable<Job>> listJobs(String projectId, Map<Option, ?> op
513536
bigquery
514537
.jobs()
515538
.list(projectId)
539+
.setPrettyPrint(false)
516540
.setAllUsers(Option.ALL_USERS.getBoolean(options))
517541
.setFields(Option.FIELDS.getString(options))
518542
.setStateFilter(Option.STATE_FILTER.<List<String>>get(options))
@@ -562,7 +586,12 @@ public Job apply(JobList.Jobs jobPb) {
562586
@Override
563587
public boolean cancel(String projectId, String jobId, String location) {
564588
try {
565-
bigquery.jobs().cancel(projectId, jobId).setLocation(location).execute();
589+
bigquery
590+
.jobs()
591+
.cancel(projectId, jobId)
592+
.setLocation(location)
593+
.setPrettyPrint(false)
594+
.execute();
566595
return true;
567596
} catch (IOException ex) {
568597
BigQueryException serviceException = translate(ex);
@@ -580,6 +609,7 @@ public GetQueryResultsResponse getQueryResults(
580609
return bigquery
581610
.jobs()
582611
.getQueryResults(projectId, jobId)
612+
.setPrettyPrint(false)
583613
.setLocation(location)
584614
.setMaxResults(Option.MAX_RESULTS.getLong(options))
585615
.setPageToken(Option.PAGE_TOKEN.getString(options))
@@ -676,7 +706,11 @@ public Policy getIamPolicy(String resourceId, Map<Option, ?> options) {
676706
.setRequestedPolicyVersion(
677707
Option.REQUESTED_POLICY_VERSION.getLong(options).intValue()));
678708
}
679-
return bigquery.tables().getIamPolicy(resourceId, policyRequest).execute();
709+
return bigquery
710+
.tables()
711+
.getIamPolicy(resourceId, policyRequest)
712+
.setPrettyPrint(false)
713+
.execute();
680714
} catch (IOException ex) {
681715
throw translate(ex);
682716
}
@@ -686,7 +720,11 @@ public Policy getIamPolicy(String resourceId, Map<Option, ?> options) {
686720
public Policy setIamPolicy(String resourceId, Policy policy, Map<Option, ?> options) {
687721
try {
688722
SetIamPolicyRequest policyRequest = new SetIamPolicyRequest().setPolicy(policy);
689-
return bigquery.tables().setIamPolicy(resourceId, policyRequest).execute();
723+
return bigquery
724+
.tables()
725+
.setIamPolicy(resourceId, policyRequest)
726+
.setPrettyPrint(false)
727+
.execute();
690728
} catch (IOException ex) {
691729
throw translate(ex);
692730
}
@@ -698,7 +736,11 @@ public TestIamPermissionsResponse testIamPermissions(
698736
try {
699737
TestIamPermissionsRequest permissionsRequest =
700738
new TestIamPermissionsRequest().setPermissions(permissions);
701-
return bigquery.tables().testIamPermissions(resourceId, permissionsRequest).execute();
739+
return bigquery
740+
.tables()
741+
.testIamPermissions(resourceId, permissionsRequest)
742+
.setPrettyPrint(false)
743+
.execute();
702744
} catch (IOException ex) {
703745
throw translate(ex);
704746
}

0 commit comments

Comments
 (0)