Project

General

Profile

Actions
Copy link

Bug #69150

closed

Reef: 'reef' release missing from OSDMap::pending_require_osd_release() .

Added by Sridhar Seshasayee over 1 year ago. Updated 9 months ago.

Status:
Resolved
Priority:
High
Assignee:
Sridhar Seshasayee
Category:
-
Target version:
-
% Done:

0%

Source:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:
60981
Tags (freeform):
Merge Commit:
715856cb1172ab83f79ee32db3b63a86fae7902a
Fixed In:
v18.2.4-1373-g715856cb117
Released In:
v18.2.5~198
Upkeep Timestamp:
2025-07-10T06:12:54+00:00

Description

Due to the "reef" release missing from OSDMap::pending_require_osd_release(), the
warning when the 'require-osd-release' flag does not match Reef release will not
be raised after an upgrade from prior releases. Any change made on a cluster
after upgrading to Reef without updating the value of 'require-osd-release'
would eventually lead to among other catastrophic issues, PGs stuck in peering,
activating or unknown states on the cluster.

The change is already available in the "main" branch as part of PR:
https://github.com/ceph/ceph/pull/53191 and commit
https://github.com/ceph/ceph/pull/53191/commits/a6dc3b6e69ee591b08943fd00aef4d3e2fad9964.

This tracker is created to track backporting the above commit alone to Reef.

Actions
Copy link
 #1

Updated by Sridhar Seshasayee over 1 year ago

  • Pull request ID set to 60981
Actions
Copy link
 #2

Updated by Sridhar Seshasayee over 1 year ago

  • Status changed from New to Fix Under Review
Actions
Copy link
 #3

Updated by Radoslaw Zarzynski over 1 year ago

scrub note: approved, sent to QA.

The release-checklist.txt has been fixed later:

commit 2eb298c76acfe33a5431d07b25f7cfe767ef77ae
Author: Radoslaw Zarzynski <rzarzynski@redhat.com>
Date:   Tue Dec 5 18:26:33 2023 +0100

    doc/dev/release-checklist: enlist OSDMap::pending_require_osd_release()

    Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>

diff --git a/doc/dev/release-checklists.rst b/doc/dev/release-checklists.rst
index 0af98ff3b38..b2cd47258a5 100644
--- a/doc/dev/release-checklists.rst
+++ b/doc/dev/release-checklists.rst
@@ -92,6 +92,10 @@ Mon
 - [x] mon/MonCommands.h: adjust "osd require-osd-release" allows options to include X
 - [x] qa/workunits/cephtool/test.sh: adjust `require-osd-release` test

+OSDMap
+------
+
+- [ ] src/osd/OSDMap.cc add release name mapping for `SERVER_X` in `pending_require_osd_release()`
Actions
Copy link
 #4

Updated by Radoslaw Zarzynski over 1 year ago

scrub note: in QA's testing.

Actions
Copy link
 #5

Updated by Radoslaw Zarzynski about 1 year ago

scrub note: might be bringing a regression. Review in progress.

Actions
Copy link
 #6

Updated by Sridhar Seshasayee about 1 year ago

  • Status changed from Fix Under Review to Resolved

The issue as noted in #note-5 is not a regression but a known issue.
See: https://tracker.ceph.com/issues/62934.

PR is merged to Reef.

Actions
Copy link
 #7

Updated by Upkeep Bot 9 months ago

  • Merge Commit set to 715856cb1172ab83f79ee32db3b63a86fae7902a
  • Fixed In set to v18.2.4-1373-g715856cb117
  • Released In set to v18.2.5~198
  • Upkeep Timestamp set to 2025-07-10T06:12:54+00:00
Actions
Copy link

Also available in: Atom PDF