Skip to content

kickoff v19 squid#53191

Merged
ljflores merged 28 commits intoceph:mainfrom
rzarzynski:wip-all-kickoff-s-2
Dec 22, 2023
Merged

kickoff v19 squid#53191
ljflores merged 28 commits intoceph:mainfrom
rzarzynski:wip-all-kickoff-s-2

Conversation

@rzarzynski
Copy link
Contributor

@rzarzynski rzarzynski commented Aug 28, 2023 •
edited
Loading

The corresponding changeset in ceph-build.git is ceph/ceph-build#2160.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@rzarzynski rzarzynski requested review from a team as code owners August 28, 2023 15:10
@rzarzynski rzarzynski mentioned this pull request Aug 28, 2023
Merged
adk3798
adk3798 reviewed Aug 28, 2023
View reviewed changes
@rzarzynski rzarzynski mentioned this pull request Aug 28, 2023
Closed
14 tasks
@rzarzynski
Copy link
Contributor Author

rzarzynski commented Aug 28, 2023

CC: @yuvalif, @mattbenjamin.

idryomov
idryomov reviewed Aug 28, 2023
View reviewed changes
qa/workunits/test_telemetry_reef_x.sh
#!/bin/bash -ex

# For quincy, the last_opt_revision remains at 1 since last_opt_revision
# was phased out for fresh installs of quincy.
Copy link
Contributor

@idryomov idryomov Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment probably needs massaging.

cc @yaarith

@rzarzynski rzarzynski force-pushed the wip-all-kickoff-s-2 branch 2 times, most recently from 9f9aa21 to f0a5024 Compare August 29, 2023 13:14
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@rzarzynski rzarzynski requested a review from jdurgin September 7, 2023 17:59
@yuvalif yuvalif mentioned this pull request Sep 12, 2023
Merged
14 tasks
@cbodley
Copy link
Contributor

cbodley commented Sep 28, 2023

bump! a gentle reminder that #52114 is still blocked on the squid feature bit to add tracing information back to MOSDOp

@cbodley cbodley mentioned this pull request Oct 12, 2023
Merged
@cbodley
Copy link
Contributor

cbodley commented Oct 12, 2023 •
edited
Loading

is this just blocked on reviews? is it worth a round of testing in the meantime?

@cbodley
Copy link
Contributor

cbodley commented Nov 2, 2023

can we consider splitting b0a2db7 into a separate PR to unblock #52114? @yuvalif does that require anything more than the feature bit?

@rzarzynski
ceph-volume: change to squid
93a898e 
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski
doc/dev/release-checklists: mark backport-resolve-issue is already done
b23a134 
This happened in 3d15f68.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski
doc/dev/release-checklists: mark ceph-release-notes is already done
c9f9174 
This happened in 5d944bb.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski
mon: update for squid ondisk features
f44c702 
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski
common, mon, qa: Mon-related updates for squid
dea8aa6 
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski
qa: stubs and clean up for reef
081177f 
- remove upgrades from octopus
- stubs for completing upgrade to reef

Still missing the quincy-x upgrade tests.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski
qa: bring test_telemetry_reef_x.sh for squid
6d25c05 
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski
qa: bring test_telemetry_reef.sh for squid
b35871b 
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
@rzarzynski
qa: bring qa/suites/upgrade/reef-x
7af05d0 
Bases on quincy-x.

```
$ cp -R qa/suites/upgrade/quincy-x/ qa/suites/upgrade/reef-x
$ git add qa/suites/upgrade/reef-x
$ git mv qa/suites/upgrade/reef-x/filestore-remove-check/1-ceph-install/quincy.yaml qa/suites/upgrade/reef-x/filestore-remove-check/1-ceph-install/reef.yaml
$ find qa/suites/upgrade/reef-x/ -type f -exec sed -i 's/quincy/reef/g' {} +
```

A note from rebase: changes from 05e2427
have been pulled in.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski
qa: drop filestore-remove-check from upgrade/reef-x
def898c 
FileStore is removed in Reef.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
@rzarzynski
qa: qa/suites/rados/upgrade/parallel points to reef
7fc77ef 
```
$ git rm qa/suites/rados/upgrade/parallel
$ ln -s ../../upgrade/reef-x/parallel qa/suites/rados/upgrade/parallel
$ git add qa/suites/rados/upgrade/parallel
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski
test/cli/monmaptool: adjust for the squid monmap features
4a81193 
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski
release-checklists.rst: mark section for ceph-build as complete
70b70c5 
This bases on ceph/ceph-build#2160.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski
Copy link
Contributor Author

rzarzynski commented Dec 4, 2023

Rebased just the sake of tagging (v19.0.0); no other changes.

PhilippHufnagl and others added 4 commits December 5, 2023 18:12
@PhilippHufnagl @rzarzynski
osd: adding 'reef' to pending_require_osd_release
a6dc3b6 
It appears adding 'reef' to pending_require_osd_release has been
forgotten. This PR adds it

Signed-off-by: Philipp Hufangl <p.hufnagl@proxmox.com>
(cherry picked from commit e443ef3)
@rzarzynski
doc/dev/release-checklist: enlist OSDMap::pending_require_osd_release()
2eb298c 
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
@rzarzynski
osd, doc: make OSDMap::pending_require_osd_release() aware about squid
4d420e1 
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
@rzarzynski
doc/dev/release-checklist: mark ceph-container changes done
66e9815 
Per ceph/ceph-container#2174.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
idryomov
idryomov approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack from the RBD perspective

vshankar
vshankar approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzarzynski
Copy link
Contributor Author

rzarzynski commented Dec 15, 2023

Related PRs in ceph-container.git:

@ljflores
Copy link
Member

ljflores commented Dec 22, 2023

Rados approved: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrellocomcNCZCeuVu1894-wip-yuri10-testing-2023-12-12-1229-old-wip-yuri10-testing-2023-12-07-1728-old-wip-yuri10-testing-2023-12-05-1105-old-wip-yuri10

@ljflores ljflores merged commit 0a2572c into ceph:main Dec 22, 2023
@sseshasa sseshasa mentioned this pull request Dec 6, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@idryomov idryomov idryomov approved these changes

@cbodley cbodley cbodley approved these changes

@adk3798 adk3798 adk3798 approved these changes

@ljflores ljflores ljflores approved these changes

@jdurgin jdurgin Awaiting requested review from jdurgin

@neha-ojha neha-ojha Awaiting requested review from neha-ojha

Assignees

No one assigned

Labels

build/ops ceph-volume cephadm cephfs Ceph File System common core documentation mon rbd tests wip-adk-testing wip-yuri10-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@rzarzynski @cbodley @yuvalif @yuriw @ljflores @vshankar @idryomov @adk3798 @PhilippHufnagl