tracer/osd/librados/build/rgw: rgw and osd end2end tracing using opentelemetry by yuvalif · Pull Request #52114 · ceph/ceph

yuvalif · 2023-06-19T17:21:30Z

manual testing for end2end tracing is described here: https://gist.github.com/yuvalif/c013710c537e96ba5d301b1bce512240

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows

github-actions · 2023-06-19T17:21:51Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

athanatos · 2023-09-28T16:28:45Z

src/common/tracer.h

+// shoudl be called between ENCODE_START, ENCODE_FINISH pair
+inline void nested_encode(const jspan_context& span_ctx, bufferlist& bl, uint64_t f = 0) {
+  auto is_valid = span_ctx.IsValid();
+  ceph::encode(is_valid, bl);


Doesn't this change break the existing encoding?

@athanatos this specific change is part of an optimization to avoid parsing a struct when encoding is disabled (by taking the boolean out of the struct). see: ea8f7fb

but regardless of that optimization (that we can remove), adding the new trace struct in the middle of the message, breaks existing encoding.
to solve this issue I'm wating for "squid" feature bit to be merged: #53191

github-actions · 2023-11-30T13:03:30Z

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

yuvalif · 2023-11-30T15:05:47Z

unstale please

cbodley · 2024-01-23T19:54:00Z

@yuvalif we need this for squid right?

yuvalif · 2024-01-24T09:35:48Z

@yuvalif we need this for squid right?

yes

rzarzynski · 2024-02-16T13:26:59Z

The following tests FAILED:
	 32 - run-rbd-unit-tests-61.sh (Timeout)
	240 - unittest-seastar-socket (Subprocess aborted)

rzarzynski · 2024-02-16T13:27:14Z

jenkins test make check

rzarzynski · 2024-02-16T13:27:30Z

jenkins test windows

rzarzynski · 2024-02-16T14:39:09Z

The following tests FAILED:
	 33 - run-rbd-unit-tests-109.sh (Failed)

rzarzynski · 2024-02-16T14:39:17Z

jenkins test make check

rzarzynski · 2024-02-16T15:19:36Z

jenkins test windows

ljflores · 2024-02-16T16:21:19Z

Rados approved: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrellocomccLo2ALzd1957-wip-yuri5-testing-2024-02-14-1335

ljflores · 2024-02-16T19:00:30Z

jenkins test windows

yuriw · 2024-02-16T19:17:50Z

@yuvalif @ljflores This was tested and approved
Pls merge when all checks passed
Ref: https://trello.com/c/cLo2ALzd

ljflores · 2024-02-16T22:44:22Z

jenkins test windows

rzarzynski · 2024-02-17T00:57:18Z

Yet another one:

[2024-02-17T00:46:13.000Z] Finished 4 out of 130 jobs.
+ EXIT_CODE=124
+ [[ 124 -eq 124 ]]
+ echo 'ERROR: ssh command timed out'
ERROR: ssh command timed out
+ return 124

rzarzynski · 2024-02-17T00:59:17Z

OK, going to backport just after cutting squid.

rzarzynski · 2024-02-17T09:20:50Z

The windows check failed due to timeout:

+ timeout 1h ssh -i **** -o UserKnownHostsFile=/home/jenkins-build/build/workspace/ceph-windows-pull-requests/libvirt/known_hosts administrator@192.168.122.174 powershell.exe /workspace/repos/ceph-win32-tests/test_host/run_tests.ps1 -workerCount 4
[2024-02-16T23:46:17.000Z] Running unit tests.
[2024-02-16T23:46:17.000Z] Using subunit file: C:\workspace\test_results\subunit.out
[2024-02-16T23:46:18.000Z] Running test: [googletest] ceph_test_dokan.
[2024-02-16T23:46:18.000Z] Running test: [googletest] ceph_test_librbd.
[2024-02-16T23:46:18.000Z] Running test: [standalone] ceph_test_librbd_fsx.librbd.
[2024-02-16T23:46:19.000Z] Running test: [standalone] ceph_test_librbd_fsx.wnbd.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_aio.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_aio_pp.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_asio.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_cls.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_cmd.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_cmd_pp.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_c_read_operations.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_c_write_operations.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_io.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_io_pp.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_list.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_lock.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_lock_pp.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_misc.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_misc_pp.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_pool.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_service.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_service_pp.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_snapshots.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_snapshots_pp.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_snapshots_stats.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_snapshots_stats_pp.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_stat.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_stat_pp.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_watch_notify.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_api_watch_notify_pp.
[2024-02-16T23:46:19.000Z] Running test: [standalone] ceph_test_rados_delete_pools_parallel.
[2024-02-16T23:46:19.000Z] Running test: [standalone] ceph_test_rados_list_parallel.
[2024-02-16T23:46:19.000Z] Running test: [standalone] ceph_test_rados_open_pools_parallel.
[2024-02-16T23:46:19.000Z] Running test: [standalone] ceph_test_rados_op_speed.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_striper_api_aio.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_striper_api_io.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_rados_striper_api_striping.
[2024-02-16T23:46:19.000Z] Running test: [googletest] ceph_test_stress_watch.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_addrs.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_allocate_unique.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_any.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_arch.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_async_completion.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_async_shared_mutex.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_auth.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_base64.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_bit_vector.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_blocked_completion.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_bloom_filter.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_bounded_key_counter.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_bufferlist.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_cdc.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_ceph_argparse.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_ceph_compatset.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_ceph_crypto.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_ceph_timer.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_config.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_confutils.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_context.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_convenience.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_counter.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_crc32c.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_crush.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_crush_wrapper.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_crypto.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_crypto_init.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_daemon_config.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_denc.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_encoding.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_escape.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_fair_mutex.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_fault_injector.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_features.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_gather.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_heartbeatmap.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_histogram.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_hobject.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_hostname.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_intarith.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_interval_map.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_interval_set.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_intrusive_lru.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_ipaddr.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_iso_8601.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_json_formattable.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_json_formatter.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_libcephfs_config.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_librados.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_librados_config.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_lru.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_lruset.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_memory.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_mempool.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_mime.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_option.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_pageset.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_perf_histogram.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_pretty_binary.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_prioritized_queue.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_random.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_random_string.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_rbd_replay.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_readahead.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_run_cmd.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_safe_io.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_sharedptr_registry.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_shared_cache.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_shunique_lock.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_simple_spin.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_sloppy_crc_map.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_split.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_static_ptr.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_striper.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_strtol.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_str_list.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_str_map.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_subprocess.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_tableformatter.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_texttable.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_time.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_url_escape.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_utf8.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_util.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_utime.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_versioned_variant.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_weighted_priority_queue.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_weighted_shuffle.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_workqueue.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_xlist.
[2024-02-16T23:46:19.000Z] Running test: [googletest] unittest_xmlformatter.
[2024-02-16T23:46:29.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:46:39.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:46:49.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:46:59.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:47:09.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:47:19.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:47:29.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:47:39.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:47:49.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:47:59.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:48:09.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:48:19.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:48:29.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:48:39.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:48:49.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:48:59.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:49:09.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:49:19.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:49:29.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:49:39.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:49:49.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:49:59.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:50:09.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:50:19.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:50:29.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:50:39.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:50:49.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:50:59.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:51:09.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:51:19.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:51:29.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:51:39.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:51:49.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:51:59.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:52:09.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:52:19.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:52:29.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:52:39.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:52:49.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:52:59.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:53:09.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:53:20.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:53:30.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:53:40.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:53:50.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:54:00.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:54:10.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:54:20.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:54:30.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:54:40.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:54:50.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:55:00.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:55:10.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:55:20.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:55:30.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:55:40.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:55:50.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:56:00.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:56:10.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:56:20.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:56:30.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:56:40.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:56:50.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:57:00.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:57:10.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:57:20.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:57:30.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:57:40.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:57:50.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:58:00.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:58:10.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:58:20.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:58:30.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:58:40.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:58:50.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:59:00.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:59:10.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:59:20.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:59:30.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:59:40.000Z] Finished 0 out of 130 jobs.
[2024-02-16T23:59:50.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:00:00.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:00:10.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:00:20.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:00:30.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:00:40.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:00:50.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:01:00.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:01:10.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:01:20.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:01:30.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:01:40.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:01:50.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:02:00.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:02:10.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:02:20.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:02:30.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:02:40.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:02:50.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:03:00.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:03:10.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:03:20.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:03:30.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:03:40.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:03:50.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:04:00.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:04:10.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:04:20.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:04:30.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:04:40.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:04:50.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:05:00.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:05:10.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:05:20.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:05:30.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:05:40.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:05:50.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:06:00.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:06:10.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:06:20.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:06:30.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:06:40.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:06:50.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:07:00.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:07:10.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:07:20.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:07:30.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:07:40.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:07:50.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:08:00.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:08:10.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:08:20.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:08:30.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:08:40.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:08:50.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:09:00.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:09:10.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:09:20.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:09:30.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:09:40.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:09:50.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:10:00.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:10:10.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:10:20.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:10:30.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:10:40.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:10:50.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:11:00.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:11:10.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:11:20.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:11:30.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:11:40.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:11:50.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:12:00.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:12:11.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:12:21.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:12:31.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:12:41.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:12:51.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:13:01.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:13:11.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:13:21.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:13:31.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:13:41.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:13:51.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:14:01.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:14:11.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:14:21.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:14:31.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:14:41.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:14:51.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:15:01.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:15:11.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:15:21.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:15:31.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:15:41.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:15:51.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:16:01.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:16:11.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:16:21.000Z] Finished 0 out of 130 jobs.
[2024-02-17T00:16:31.000Z] Finished 3 out of 130 jobs.
[2024-02-17T00:16:41.000Z] Finished 3 out of 130 jobs.
[2024-02-17T00:16:51.000Z] Finished 3 out of 130 jobs.
[2024-02-17T00:17:01.000Z] Finished 3 out of 130 jobs.
[2024-02-17T00:17:11.000Z] Finished 3 out of 130 jobs.
[2024-02-17T00:17:21.000Z] Finished 3 out of 130 jobs.
[2024-02-17T00:17:31.000Z] Finished 3 out of 130 jobs.
[2024-02-17T00:17:41.000Z] Finished 3 out of 130 jobs.
[2024-02-17T00:17:51.000Z] Finished 3 out of 130 jobs.
[2024-02-17T00:18:01.000Z] Finished 3 out of 130 jobs.
[2024-02-17T00:18:11.000Z] Finished 3 out of 130 jobs.
[2024-02-17T00:18:21.000Z] Finished 3 out of 130 jobs.
[2024-02-17T00:18:31.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:18:41.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:18:51.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:19:01.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:19:11.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:19:21.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:19:31.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:19:41.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:19:51.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:20:01.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:20:11.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:20:21.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:20:31.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:20:41.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:20:51.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:21:01.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:21:11.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:21:21.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:21:31.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:21:41.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:21:51.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:22:01.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:22:11.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:22:21.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:22:31.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:22:41.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:22:51.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:23:01.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:23:11.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:23:21.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:23:31.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:23:41.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:23:51.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:24:01.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:24:11.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:24:21.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:24:31.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:24:41.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:24:51.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:25:01.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:25:11.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:25:21.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:25:31.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:25:41.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:25:51.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:26:01.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:26:11.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:26:21.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:26:31.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:26:41.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:26:51.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:27:01.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:27:11.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:27:21.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:27:31.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:27:41.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:27:51.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:28:01.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:28:11.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:28:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:28:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:28:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:28:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:29:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:29:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:29:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:29:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:29:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:29:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:30:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:30:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:30:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:30:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:30:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:30:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:31:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:31:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:31:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:31:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:31:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:31:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:32:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:32:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:32:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:32:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:32:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:32:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:33:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:33:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:33:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:33:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:33:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:33:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:34:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:34:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:34:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:34:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:34:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:34:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:35:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:35:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:35:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:35:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:35:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:35:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:36:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:36:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:36:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:36:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:36:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:36:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:37:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:37:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:37:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:37:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:37:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:37:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:38:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:38:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:38:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:38:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:38:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:38:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:39:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:39:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:39:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:39:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:39:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:39:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:40:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:40:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:40:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:40:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:40:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:40:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:41:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:41:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:41:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:41:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:41:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:41:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:42:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:42:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:42:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:42:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:42:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:42:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:43:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:43:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:43:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:43:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:43:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:43:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:44:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:44:12.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:44:22.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:44:32.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:44:42.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:44:52.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:45:02.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:45:13.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:45:23.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:45:33.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:45:43.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:45:53.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:46:03.000Z] Finished 4 out of 130 jobs.
[2024-02-17T00:46:13.000Z] Finished 4 out of 130 jobs.
+ EXIT_CODE=124
+ [[ 124 -eq 124 ]]
+ echo 'ERROR: ssh command timed out'
ERROR: ssh command timed out
+ return 124

I don't see a rebase-to-fresh-main happening before building the binaries. I'm going go through the check with a rebased commit.

petrutlucian94 · 2024-02-17T09:51:52Z

Hi, I'm currently preparing a build with this patch and I'll take a closer look. For what is worth, Windows builds use WITH_JAEGER=OFF. We had some message decoding issues before, I think there's a high chance that it's a similar issue.

#51043

petrutlucian94 · 2024-02-17T15:36:28Z

I was right, it's a message decoding issue, similar to the one that we had before. We're getting this on the OSD side:

2024-02-17T15:28:20.348+0000 7f3bead9b640 -1 failed to decode message of type 42 v9: void tracing::decode(jspan_context&, ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]

It looks like this patch (re)introduces a regression that affects compatibility between builds that have telemetry enabled and the ones that don't. The previous PR got reverted: #51331

rzarzynski · 2024-02-17T19:21:22Z

In my understanding:

There are two flavors of the dencoder for jspan_context: 1) the properly defined, even before this commit, HAVE_JEAGER one and 2) the dummy where the encode() and decode() methods are just empty:

#ifdef HAVE_JAEGER
// ...
void encode(const jspan_context& span, ceph::buffer::list& bl, uint64_t f = 0);
void decode(jspan_context& span_ctx, ceph::buffer::list::const_iterator& bl);
// ...
#else  // !HAVE_JAEGER
// ...
inline void encode(const jspan_context& span, bufferlist& bl, uint64_t f=0) {}
inline void decode(jspan_context& span_ctx, ceph::buffer::list::const_iterator& bl) {}
}
#endif // !HAVE_JAEGER

Because of the Yuval's commit Message starts using the methods above – the bug gets unveiled.
The exposed problem has been fixed in common/tracer: fix decoding when jaeger tracing is disabled #51043 which turns dummy into a valid dencoder.

inline void encode(const jspan_context& span_ctx, bufferlist& bl, uint64_t f = 0) {
  ENCODE_START(1, 1, bl);
  // jaeger is missing, set "is_valid" to false.
  bool is_valid = false;
  encode(is_valid, bl);
  ENCODE_FINISH(bl);
}

What is important here is that ENCODE_START() & co imposes the dependency on include/dencoding.h.

Inclusion of this header was a part of the Yuval original's commit:

-#include "include/buffer.h"
+#include "include/encoding.h"

Unfortunately, reverting it leaded to reverting also the fix for dummy dencoder of jspan_context (due to FTBFSes on ccentos8). This happened in Revert "common/tracer: fix decoding when jaeger tracing is disabled" #51331.

As this PR also includes include/encoding.h, I think all is needed is just to bring the @petrutlucian94's 3701ffa back. I'm doing this right now.

We aren't currently using jaeger tracing on Windows. The issue is that Windows hosts (or any other host that doesn't use jaeger) are experiencing message decoding failures after a recent change [1]. This change updates the tracer encoding so that messages from non-jaeger hosts may be decoded by services that use jaeger. [1] ceph#47457 Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com> This commit rebrings 3701ffa which got reverted due to an implicit dependency with other revert. Please see ceph#52114 (comment). Conflicts: src/common/tracer.h formatting conflict with 7179ac0

yuvalif · 2024-02-20T16:21:35Z

thanks @rzarzynski and team for all the help and support!

We aren't currently using jaeger tracing on Windows. The issue is that Windows hosts (or any other host that doesn't use jaeger) are experiencing message decoding failures after a recent change [1]. This change updates the tracer encoding so that messages from non-jaeger hosts may be decoded by services that use jaeger. [1] ceph#47457 Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com> This commit rebrings 3701ffa which got reverted due to an implicit dependency with other revert. Please see ceph#52114 (comment). Conflicts: src/common/tracer.h formatting conflict with 7179ac0 (cherry picked from commit e145264)

rzarzynski · 2024-02-20T16:35:10Z

The squid backport is: #55625.

cbodley · 2024-02-20T16:58:24Z

src/librados/librados_asio.h

 auto async_operate(ExecutionContext& ctx, IoCtx& io, const std::string& oid,
                   ObjectReadOperation *read_op, int flags,
-                   CompletionToken&& token)
+                   CompletionToken&& token, const jspan_context* trace_ctx = nullptr)


noticed while rebasing #55592 that this argument is unused

no ObjectReadOperation overload of aio_operate() takes a trace pointer. the jspan_context overloads were only added for ObjectWriteOperations

We aren't currently using jaeger tracing on Windows. The issue is that Windows hosts (or any other host that doesn't use jaeger) are experiencing message decoding failures after a recent change [1]. This change updates the tracer encoding so that messages from non-jaeger hosts may be decoded by services that use jaeger. [1] ceph#47457 Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com> This commit rebrings 3701ffa which got reverted due to an implicit dependency with other revert. Please see ceph#52114 (comment). Conflicts: src/common/tracer.h formatting conflict with 7179ac0

github-actions bot added build/ops cephfs Ceph File System common core documentation mon rbd rgw tests needs-rebase labels Jun 19, 2023

This was referenced Jun 19, 2023

tracer/osd/librados/build/rgw: rgw and osd end2end tracing using opentelemetry rzarzynski/ceph#2

Closed

tracing: fix OSD message breakage with backward compatibility #51288

Closed

yuvalif requested review from athanatos, cbodley, gregsfortytwo, mattbenjamin and rzarzynski June 19, 2023 17:25

This was referenced Jun 22, 2023

rgw: multisite bucket index trace points #48341

Closed

blkin: remove blkin trace submodule and cleanup #48971

Closed

yuvalif added the tracing label Jul 12, 2023

cbodley mentioned this pull request Sep 28, 2023

kickoff v19 squid #53191

Merged

14 tasks

athanatos reviewed Sep 28, 2023

View reviewed changes

github-actions bot added the stale label Nov 30, 2023

github-actions bot removed the stale label Nov 30, 2023

yuvalif force-pushed the wip-end2end-tracing branch from cc4823b to a7e36b8 Compare January 28, 2024 09:10

yuriw added wip-yuri2-testing and removed wip-yuri2-testing labels Feb 15, 2024

yuriw added TESTED ready-to-merge and removed wip-yuri5-testing labels Feb 16, 2024

rzarzynski mentioned this pull request Feb 17, 2024

squid: tracer/osd/librados/build/rgw: rgw and osd end2end tracing using open… #55625

Merged

14 tasks

rzarzynski mentioned this pull request Feb 17, 2024

tracer/osd/librados/build/rgw: rgw and osd end2end tracing using open… #55628

Closed

14 tasks

rzarzynski merged commit b9f000f into ceph:main Feb 20, 2024

cbodley reviewed Feb 20, 2024

View reviewed changes

Conversation

yuvalif commented Jun 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

github-actions bot commented Jun 19, 2023

Uh oh!

athanatos Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

yuvalif Oct 1, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 30, 2023

Uh oh!

yuvalif commented Nov 30, 2023

Uh oh!

cbodley commented Jan 23, 2024

Uh oh!

yuvalif commented Jan 24, 2024

Uh oh!

rzarzynski commented Feb 16, 2024

Uh oh!

rzarzynski commented Feb 16, 2024

Uh oh!

rzarzynski commented Feb 16, 2024

Uh oh!

rzarzynski commented Feb 16, 2024

Uh oh!

rzarzynski commented Feb 16, 2024

Uh oh!

rzarzynski commented Feb 16, 2024

Uh oh!

ljflores commented Feb 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljflores commented Feb 16, 2024

Uh oh!

yuriw commented Feb 16, 2024

Uh oh!

ljflores commented Feb 16, 2024

Uh oh!

rzarzynski commented Feb 17, 2024

Uh oh!

rzarzynski commented Feb 17, 2024

Uh oh!

rzarzynski commented Feb 17, 2024

Uh oh!

petrutlucian94 commented Feb 17, 2024

Uh oh!

petrutlucian94 commented Feb 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rzarzynski commented Feb 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuvalif commented Feb 20, 2024

Uh oh!

rzarzynski commented Feb 20, 2024

Uh oh!

cbodley Feb 20, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

yuvalif commented Jun 19, 2023 •

edited

Loading

ljflores commented Feb 16, 2024 •

edited

Loading

petrutlucian94 commented Feb 17, 2024 •

edited

Loading

rzarzynski commented Feb 17, 2024 •

edited

Loading