Skip to content

reef: osd: adding 'reef' to pending_require_osd_release#60981

Merged
SrinivasaBharath merged 1 commit intoceph:reeffrom
sseshasa:wip-69150-reef
Jan 17, 2025
Merged

reef: osd: adding 'reef' to pending_require_osd_release#60981
SrinivasaBharath merged 1 commit intoceph:reeffrom
sseshasa:wip-69150-reef

Conversation

@sseshasa
Copy link
Contributor

@sseshasa sseshasa commented Dec 6, 2024 •
edited
Loading

It appears adding 'reef' to pending_require_osd_release has been forgotten. This PR adds it

Signed-off-by: Philipp Hufangl p.hufnagl@proxmox.com
(cherry picked from commit e443ef3)
(cherry picked from commit a6dc3b6)

This is a Reef backport PR

Fixes: https://tracker.ceph.com/issues/69150

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@PhilippHufnagl @sseshasa
osd: adding 'reef' to pending_require_osd_release
25e8b22 
It appears adding 'reef' to pending_require_osd_release has been
forgotten. This PR adds it

Signed-off-by: Philipp Hufangl <p.hufnagl@proxmox.com>
(cherry picked from commit e443ef3)
(cherry picked from commit a6dc3b6)
@sseshasa sseshasa requested a review from a team as a code owner December 6, 2024 16:19
@github-actions github-actions bot added the core label Dec 6, 2024
@github-actions github-actions bot added this to the reef milestone Dec 6, 2024
@sseshasa
Copy link
Contributor Author

sseshasa commented Dec 6, 2024

Note: Need to perform separate teuthology upgrade tests to verify that the warning is generated.

@sseshasa sseshasa requested a review from rzarzynski December 6, 2024 16:22
@sseshasa
Copy link
Contributor Author

sseshasa commented Dec 6, 2024

@rzarzynski This is a backport of commit a6dc3b6 from your PR: #53191.

Please take a look. This would need upgrade testing on both rados and fs suites.

@sseshasa
Copy link
Contributor Author

sseshasa commented Dec 9, 2024

jenkins test make check

2 similar comments
@sseshasa
Copy link
Contributor Author

sseshasa commented Dec 9, 2024

jenkins test make check

@sseshasa
Copy link
Contributor Author

sseshasa commented Dec 9, 2024

jenkins test make check

@rzarzynski
Copy link
Contributor

rzarzynski commented Dec 9, 2024

jenkins test make check

@ljflores ljflores changed the title osd: adding 'reef' to pending_require_osd_release reef: osd: adding 'reef' to pending_require_osd_release Dec 9, 2024
@sseshasa
Copy link
Contributor Author

sseshasa commented Dec 10, 2024

jenkins test make check

@sseshasa
Copy link
Contributor Author

sseshasa commented Dec 12, 2024

jenkins test make check

5 similar comments
@ljflores
Copy link
Member

ljflores commented Dec 16, 2024

jenkins test make check

@sseshasa
Copy link
Contributor Author

sseshasa commented Dec 30, 2024

jenkins test make check

@SrinivasaBharath
Copy link
Contributor

SrinivasaBharath commented Jan 8, 2025

jenkins test make check

@sseshasa
Copy link
Contributor Author

sseshasa commented Jan 10, 2025

jenkins test make check

@SrinivasaBharath
Copy link
Contributor

SrinivasaBharath commented Jan 13, 2025

jenkins test make check

@rzarzynski
Copy link
Contributor

rzarzynski commented Jan 13, 2025 

[ RUN      ] OSDMapTest.BUG_42052
pure virtual method called
terminate called without an active exception
*** Caught signal (Aborted) **
 in thread 7f11b9138640 thread_name:clean_upmap_tp
 ceph version Development (no_version) reef (stable)
 1: /home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_osdmap(+0x2dd8c9) [0x56521fac98c9]
 2: /lib/x86_64-linux-gnu/libc.so.6(+0x42520) [0x7f11bf9fb520]
 3: pthread_kill()
 4: raise()
 5: abort()
 6: /lib/x86_64-linux-gnu/libstdc++.so.6(+0xa2b9e) [0x7f11bfd8db9e]
 7: /lib/x86_64-linux-gnu/libstdc++.so.6(+0xae20c) [0x7f11bfd9920c]
 8: /lib/x86_64-linux-gnu/libstdc++.so.6(+0xae277) [0x7f11bfd99277]
 9: /lib/x86_64-linux-gnu/libstdc++.so.6(+0xaefa5) [0x7f11bfd99fa5]
 10: (ThreadPool::WorkQueue<ParallelPGMapper::Item>::_void_dequeue()+0x16) [0x56521fa1cff6]
 11: (ThreadPool::worker(ThreadPool::WorkThread*)+0x7c9) [0x7f11c1b35c79]
 12: (ThreadPool::WorkThread::entry()+0x1a) [0x7f11c1b3c16a]
 13: (Thread::entry_wrapper()+0x77) [0x7f11c1b09b57]
 14: (Thread::_entry_func(void*)+0x15) [0x7f11c1b09ac5]
 15: /lib/x86_64-linux-gnu/libc.so.6(+0x94ac3) [0x7f11bfa4dac3]
 16: /lib/x86_64-linux-gnu/libc.so.6(+0x126850) [0x7f11bfadf850]
2025-01-13T07:58:32.419+0000 7f11b9138640 -1 *** Caught signal (Aborted) **
 in thread 7f11b9138640 thread_name:clean_upmap_tp

This is from the unittest_osdmap. Is this related, @sseshasa?

@sseshasa
Copy link
Contributor Author

sseshasa commented Jan 14, 2025

OSDMapTest

@rzarzynski The make check so far was only indicating failure in run_tox_mgr test which is affecting merging of many Reef PRs. The failure in the osdmap unittest was not showing up until now. This a known issue: https://tracker.ceph.com/issues/62934. The fix needs to be backported to Reef as well.

@yuriw
Copy link
Contributor

yuriw commented Jan 16, 2025

jenkins test make check

1 similar comment
@yuriw
Copy link
Contributor

yuriw commented Jan 16, 2025

jenkins test make check

@SrinivasaBharath SrinivasaBharath merged commit 715856c into ceph:reef Jan 17, 2025
@sseshasa sseshasa removed this from the reef milestone Jul 17, 2025
@sseshasa sseshasa added this to the v18.2.8 milestone Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rzarzynski rzarzynski rzarzynski approved these changes

Assignees

No one assigned

Labels

core needs-qa ready-to-merge TESTED wip-bharath4-testing

Projects

None yet

Milestone

v18.2.8

Development

Successfully merging this pull request may close these issues.

6 participants

@sseshasa @rzarzynski @ljflores @SrinivasaBharath @yuriw @PhilippHufnagl