Project

General

Profile

Actions

Bug #66905

closed

seastar submodule: remove clang14 adjustment commit

Added by Matan Breizman over 1 year ago. Updated 5 months ago.

Status:
Resolved
Priority:
Low
Category:
-
Target version:
-
% Done:

0%

Source:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Tags (freeform):
Fixed In:
v19.3.0-8077-g4697f4e858
Released In:
v20.2.0~962
Upkeep Timestamp:
2025-11-01T01:17:10+00:00

Description

https://github.com/ceph/ceph/pull/58452 updated the submodule to https://github.com/ceph/seastar/commits/wip-matanb-seastar-july9/.

Since our ci still uses clang14 sometimes, the commit https://github.com/ceph/seastar/commit/e7a2679235aeea4c9635e5202260204f0147a8c2
had to be pushed. Seastar supports the last two major version of gcc/clang so it's not expected to be fixed.

This issue is fixed in newer compilers (16 and above for clang).
Once we upgrade the compilers we use for jenkins CI, we can remove the commit attached above.

Actions #1

Updated by Hanliang Xu over 1 year ago

Hey Ceph Maintainers! I'm Hanliang, a JHU CS undergraduate interested in applying what I learned in my last semester's "Distributed Systems" to open-source contribution to Ceph. I'm also an open source contributor to another GSoC organization (OSIPI) this summer. I noticed the "good-first-issue" tag, and may I try fixing this? Thank you for your consideration! I'll report my progress while working on it next week.

Actions #2

Updated by Hanliang Xu over 1 year ago

Hanliang Xu wrote in #note-1:

Hey Ceph Maintainers! I'm Hanliang, a JHU CS undergraduate interested in applying what I learned in my last semester's "Distributed Systems" to open-source contribution to Ceph. I'm also an open source contributor to another GSoC organization (OSIPI) this summer. I noticed the "good-first-issue" tag, and may I try fixing this? Thank you for your consideration! I'll report my progress while working on it next week.

Or I'd like to try another issue if the compiler for Jenkins CI hasn't been upgraded yet!

Actions #3

Updated by Matan Breizman over 1 year ago

Hanliang Xu wrote in #note-1:

Hey Ceph Maintainers! I'm Hanliang, a JHU CS undergraduate interested in applying what I learned in my last semester's "Distributed Systems" to open-source contribution to Ceph. I'm also an open source contributor to another GSoC organization (OSIPI) this summer. I noticed the "good-first-issue" tag, and may I try fixing this? Thank you for your consideration! I'll report my progress while working on it next week.

Hey, as this tracker is not yet relevant (CI). Do you want to try https://tracker.ceph.com/issues/66627 instead?
Feel free to ping me in Ceph's Slack.
Thanks!

Actions #4

Updated by Hanliang Xu over 1 year ago

Hey Matan, thank you! Replied under that issue. Will work on it over this week and plan to submit pull request by this weekend.

Matan Breizman wrote in #note-3:

Hanliang Xu wrote in #note-1:

Hey Ceph Maintainers! I'm Hanliang, a JHU CS undergraduate interested in applying what I learned in my last semester's "Distributed Systems" to open-source contribution to Ceph. I'm also an open source contributor to another GSoC organization (OSIPI) this summer. I noticed the "good-first-issue" tag, and may I try fixing this? Thank you for your consideration! I'll report my progress while working on it next week.

Hey, as this tracker is not yet relevant (CI). Do you want to try https://tracker.ceph.com/issues/66627 instead?
Feel free to ping me in Ceph's Slack.
Thanks!

Actions #5

Updated by Matan Breizman about 1 year ago

  • Status changed from New to Fix Under Review
  • Assignee set to Matan Breizman
  • Pull request ID set to 61735

Clang is updated to 19, rebasing the submodule without the adjustment commit.

Actions #6

Updated by Matan Breizman 10 months ago

  • Status changed from Fix Under Review to Resolved
Actions #7

Updated by Upkeep Bot 8 months ago

  • Merge Commit set to 4697f4e858f0a9a4d1974811e225fb4ee1569d4a
  • Fixed In set to v19.3.0-8077-g4697f4e858f
  • Upkeep Timestamp set to 2025-07-10T19:36:55+00:00
Actions #8

Updated by Upkeep Bot 8 months ago

  • Fixed In changed from v19.3.0-8077-g4697f4e858f to v19.3.0-8077-g4697f4e858
  • Upkeep Timestamp changed from 2025-07-10T19:36:55+00:00 to 2025-07-14T22:42:14+00:00
Actions #9

Updated by Upkeep Bot 5 months ago

  • Released In set to v20.2.0~962
  • Upkeep Timestamp changed from 2025-07-14T22:42:14+00:00 to 2025-11-01T01:17:10+00:00
Actions

Also available in: Atom PDF