seastar: update submodule by Matan-B · Pull Request #58452 · ceph/ceph

Matan-B · 2024-07-07T11:54:27Z

seastar: fix makecheck error: missing 'typename' #58427 reverted a commit in the submodule in order to resolve a FTBFS which was fixed in latest seastar ceph/seastar@378b776.
The revert is removed.
Seastar_STD_OPTIONAL_VARIANT_STRINGVIEW is removed
Seastar_DEPRECATED_OSTREAM_FORMATTERS OFF - set to OFF to use seastar's formatters.
Latest seastar deprecated get0 - use get instead
WIP: clang 14 FTBFS - ceph/seastar@e7a2679

The submodule is updated to branch https://github.com/ceph/seastar/commits/wip-matanb-seastar-july9/

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

Matan-B · 2024-07-08T14:16:32Z

jenkins test make check

Matan-B · 2024-07-09T12:51:02Z

@tchaikov, @athanatos - I had to also revert ceph/seastar@914a424 from our submodule since we can't deprecate operator<< yet (for vector and unordered_map). The commit message says:

...
and these two formatters are marked deprecated.
so in future, we can remove them when we bump up the API level or just
completely drop them.

Is it intended for the deprecation to apply to the project as a whole (and not just seastar's usage of it)?

tchaikov · 2024-07-09T13:17:33Z

@tchaikov, @athanatos - I had to also revert ceph/seastar@914a424 from our submodule since we can't deprecate operator<< yet (for vector and unordered_map). The commit message says:
...
and these two formatters are marked deprecated.
so in future, we can remove them when we bump up the API level or just
completely drop them.
Is it intended for the deprecation to apply to the project as a whole (and not just seastar's usage of it)?

IMO, seastar is just an event-driven library, it is not in a position to decide how its parent project formats an instance of std::vector<T>. actually, ceph has two overloads for formatting std::vector<T>, and one overload for formatting std::unordered_set<T>.

i think the right way to fix this is

do not define Seastar_DEPRECATED_OSTREAM_FORMATTERS
define operator<< for std::unordered_map<T> in Ceph, instead of relying on a library like seastar to do this.

Update submodule to branch https://github.com/ceph/seastar/commits/wip-matanb-seastar-july9/ Signed-off-by: Matan Breizman <mbreizma@redhat.com>

scylladb/seastar@2b43417 Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

ceph/seastar@ad4fef3 Signed-off-by: Matan Breizman <mbreizma@redhat.com>

ceph/seastar@914a424 We shouldn't rely on seastar's formatters Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Matan-B · 2024-07-09T14:18:23Z

i think the right way to fix this is

do not define Seastar_DEPRECATED_OSTREAM_FORMATTERS

define operator<< for std::unordered_map<T> in Ceph, instead of relying on a library like seastar to do this.

@tchaikov, thank you for the quick reply.
btw, do you think that ceph/seastar@e7a2679 should be pushed to the main repo as well? Awaiting make check to find more instances.

Looks clang specific llvm/llvm-project#52720

Edit: structural bindings captures were is the issue for clang 15 and below.
https://godbolt.org/z/ez4Y99xfK

clang++-14: ``` /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/crimson/seastore/test_seastore.cc:86:5: error: void function 'do_transaction' should not return a value [-Wreturn-type] return sharded_seastore->do_transaction( ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/crimson/seastore/test_seastore.cc:94:5: error: void function 'set_meta' should not return a value [-Wreturn-type] return seastore->write_meta(key, value).get(); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 errors generated. ``` Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Matan-B · 2024-07-10T07:42:58Z

jenkins test make check

Matan-B · 2024-07-11T09:26:35Z

https://shaman.ceph.com/builds/ceph/wip-matanb-seastar-july7

Matan-B · 2024-07-11T09:35:01Z

Added https://tracker.ceph.com/issues/66905 to remove the last commit from our submodule once we update the compilers used for CI.

tchaikov · 2024-07-11T12:23:00Z

i think the right way to fix this is

do not define Seastar_DEPRECATED_OSTREAM_FORMATTERS

define operator<< for std::unordered_map<T> in Ceph, instead of relying on a library like seastar to do this.

@tchaikov, thank you for the quick reply. btw, do you think that ceph/seastar@e7a2679 should be pushed to the main repo as well? Awaiting make check to find more instances.

unless you believe it's a bug in seastar instead of a bug in clang.

you could verify this with, for instance, a recent version of GCC. if both of them complain, there are good chances it's a bug in Seastar. or you could check if this is indeed something not supported by C++20. yeah, i knew that the standard is not human readable under most circumstances. but still..

Looks clang specific llvm/llvm-project#52720

Edit: structural bindings captures were is the issue for clang 15 and below. https://godbolt.org/z/ez4Y99xfK

Matan-B · 2024-07-11T12:41:27Z

unless you believe it's a bug in seastar instead of a bug in clang.

It's a bug in clang which was fixed in 16 and higher, shouldn't probably be fixed in seastar. I'll keep it in out submodule until we stop using the older version. Thank you!

tchaikov · 2024-07-12T00:51:52Z

src/test/crimson/seastore/test_seastore.cc


  void do_transaction(CTransaction &&t) {
-    return sharded_seastore->do_transaction(
+    return (void)sharded_seastore->do_transaction(


nit, s/return//

cbodley · 2024-07-18T20:04:08Z

@Matan-B can this be reasonably backported to squid, or should we backport #58427 instead? still seeing a lot of 'make check' failures on squid due to https://tracker.ceph.com/issues/66834

Matan-B · 2024-07-21T10:13:55Z

@Matan-B can this be reasonably backported to squid, or should we backport #58427 instead? still seeing a lot of 'make check' failures on squid due to https://tracker.ceph.com/issues/66834

#58702 should do. thanks for updating the tracker!

Matan-B · 2024-07-21T10:37:15Z

https://pulpito.ceph.com/matan-2024-07-11_12:17:07-crimson-rados-wip-matanb-seastar-july7-distro-crimson-smithi/

Bluestore failures (seastore looks stable, no relevant changes):
https://tracker.ceph.com/issues/66294 - 7796519, 7796501
https://tracker.ceph.com/issues/67062 - 7796510 (new, unrelated)
https://tracker.ceph.com/issues/66316 - 7796492, 7796497

Matan-B · 2024-07-21T11:20:08Z

@xxhdx1985126 @cyx1231st FYI

seastar: update submodule Reviewed-by: Samuel Just <sjust@redhat.com>

Matan-B added the crimson label Jul 7, 2024

Matan-B requested a review from a team July 7, 2024 11:54

github-actions bot added the CI Continuous Integration label Jul 7, 2024

athanatos approved these changes Jul 8, 2024

View reviewed changes

Matan-B force-pushed the wip-matanb-seastar-july7 branch from 0b46f71 to 8efc2e8 Compare July 9, 2024 12:45

github-actions bot added the tests label Jul 9, 2024

Matan-B force-pushed the wip-matanb-seastar-july7 branch from 8efc2e8 to e076150 Compare July 9, 2024 12:54

Matan-B added 5 commits July 9, 2024 14:16

seastar: update submodule

9fddade

Update submodule to branch https://github.com/ceph/seastar/commits/wip-matanb-seastar-july9/ Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson: use get instead of deprecated get0

425f333

scylladb/seastar@2b43417 Signed-off-by: Matan Breizman <mbreizma@redhat.com>

labeler: label seastar submodule as crimson

9328060

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

CMakeLists: Crimson - remove Seastar_STD_OPTIONAL_VARIANT_STRINGVIEW

220669a

ceph/seastar@ad4fef3 Signed-off-by: Matan Breizman <mbreizma@redhat.com>

CMakeLists: Seastar_DEPRECATED_OSTREAM_FORMATTERS OFF

2539c6f

ceph/seastar@914a424 We shouldn't rely on seastar's formatters Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Matan-B force-pushed the wip-matanb-seastar-july7 branch from e076150 to 2539c6f Compare July 9, 2024 14:16

github-actions bot added the build/ops label Jul 9, 2024

Matan-B added the needs-crimson-qa label Jul 10, 2024

Matan-B mentioned this pull request Jul 10, 2024

crimson: peering event processing fixes, wait for async operations started during peering events #58464

Merged

Matan-B added the wip-matan-testing label Jul 11, 2024

athanatos self-requested a review July 11, 2024 15:51

athanatos approved these changes Jul 11, 2024

View reviewed changes

tchaikov reviewed Jul 12, 2024

View reviewed changes

Matan-B merged commit d557013 into ceph:main Jul 21, 2024

Matan-B mentioned this pull request Jul 31, 2024

squid: seastar: update submodule #58955

Merged

NitzanMordhai pushed a commit to NitzanMordhai/ceph that referenced this pull request Aug 1, 2024

Merge pull request ceph#58452 from Matan-B/wip-matanb-seastar-july7

a4c6696

seastar: update submodule Reviewed-by: Samuel Just <sjust@redhat.com>

Conversation

Matan-B commented Jul 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The submodule is updated to branch https://github.com/ceph/seastar/commits/wip-matanb-seastar-july9/

Contribution Guidelines

Checklist

Uh oh!

Matan-B commented Jul 8, 2024

Uh oh!

Matan-B commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tchaikov commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Matan-B commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Matan-B commented Jul 10, 2024

Uh oh!

Matan-B commented Jul 11, 2024

Uh oh!

Matan-B commented Jul 11, 2024

Uh oh!

tchaikov commented Jul 11, 2024

Uh oh!

Matan-B commented Jul 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tchaikov Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

cbodley commented Jul 18, 2024

Uh oh!

Matan-B commented Jul 21, 2024

Uh oh!

Matan-B commented Jul 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Matan-B commented Jul 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Matan-B commented Jul 7, 2024 •

edited

Loading

Matan-B commented Jul 9, 2024 •

edited

Loading

tchaikov commented Jul 9, 2024 •

edited

Loading

Matan-B commented Jul 9, 2024 •

edited

Loading

Matan-B commented Jul 11, 2024 •

edited

Loading

Matan-B commented Jul 21, 2024 •

edited

Loading