Skip to content

seastar: bump up seastar submodule#61735

Merged
Matan-B merged 3 commits intoceph:mainfrom
Matan-B:wip-matanb-crimson-seastar-feb-25
Mar 3, 2025
Merged

seastar: bump up seastar submodule#61735
Matan-B merged 3 commits intoceph:mainfrom
Matan-B:wip-matanb-crimson-seastar-feb-25

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Feb 9, 2025 •
edited
Loading

Bump up seastar submodule to https://github.com/ceph/seastar/commits/wip-matanb-seastar-feb-25/

ceph/seastar@b4271a0 is also pushed to allow boost upgrade to 1.87 (until the fixes will be merged in the main repo) - CC: @adamemerson
edit: scylladb/seastar#2639 was merged, rebasing.

Fixes: https://tracker.ceph.com/issues/66905

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@Matan-B Matan-B requested a review from a team as a code owner February 9, 2025 15:04
@Matan-B Matan-B mentioned this pull request Feb 9, 2025
Merged
14 tasks
@cyx1231st
Copy link
Member

cyx1231st commented Feb 10, 2025

jenkins test api

@Matan-B
Copy link
Contributor Author

Matan-B commented Feb 10, 2025

Looks like c++20 support is required:

src/seastar/src/core/fstream.cc
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/seastar/src/core/fstream.cc:26:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/fmt/include/fmt/format.h:44:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/cmath:1935:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/specfun.h:45:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_algobase.h:65:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_iterator_base_types.h:71:
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/iterator_concepts.h:979:13: error: no matching function for call to '__begin'

We currently use clang++-14 with -std=gnu++2b

@Matan-B Matan-B force-pushed the wip-matanb-crimson-seastar-feb-25 branch from 6da6c58 to e66ec39 Compare February 10, 2025 08:42
@Matan-B
Copy link
Contributor Author

Matan-B commented Feb 10, 2025

changeset: rebased submodule, fixes were merged

@Matan-B Matan-B mentioned this pull request Feb 10, 2025
Merged
@Matan-B
Copy link
Contributor Author

Matan-B commented Feb 10, 2025

Looks like c++20 support is required:

src/seastar/src/core/fstream.cc
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/seastar/src/core/fstream.cc:26:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/fmt/include/fmt/format.h:44:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/cmath:1935:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/specfun.h:45:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_algobase.h:65:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_iterator_base_types.h:71:
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/iterator_concepts.h:979:13: error: no matching function for call to '__begin'

We currently use clang++-14 with -std=gnu++2b

Follow-up: #61740

@Matan-B Matan-B force-pushed the wip-matanb-crimson-seastar-feb-25 branch 2 times, most recently from 3442ddd to 7f40e3e Compare February 25, 2025 13:57
@Matan-B
Copy link
Contributor Author

Matan-B commented Feb 25, 2025

jenkins test make check

@Matan-B
Copy link
Contributor Author

Matan-B commented Feb 25, 2025

jenkins test api

@Matan-B
Copy link
Contributor Author

Matan-B commented Feb 26, 2025

jenkins test make check arm64

@Matan-B
Copy link
Contributor Author

Matan-B commented Feb 26, 2025

https://shaman.ceph.com/builds/ceph/wip-matanb-crimson-seastar-feb-25

@Matan-B
Copy link
Contributor Author

Matan-B commented Feb 26, 2025

https://pulpito.ceph.com/matan-2025-02-26_10:36:55-crimson-rados-wip-matanb-crimson-seastar-feb-25-distro-crimson-smithi/

@Matan-B
Copy link
Contributor Author

Matan-B commented Feb 27, 2025

arm64:

INFO  2025-02-26 12:36:11,132 [shard 0:main] test - EphemeralTestState::restart_fut: finish
INFO  2025-02-26 12:36:11,133 [shard 0:main] test - EphemeralTestState::tm_setup: finish
INFO  2025-02-26 12:36:11,207 [shard 0:main] test - setup finished
INFO  2025-02-26 12:36:11,208 [shard 0:main] test - run_async started...
INFO  2025-02-26 12:36:11,268 [shard 0:main] seastore_epm - BackgroundProcess::run_until_halt: started...
INFO  2025-02-26 12:36:11,269 [shard 0:main] seastore_epm - BackgroundProcess::run_until_halt: finished
/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.h:307:2: runtime error: downcast of misaligned address 0xfffffffffffffe49 for type 'LogicalChildNode', which requires 8 byte alignment
0xfffffffffffffe49: note: pointer points here
<memory cannot be printed>
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.h:307:2 
/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.cc:446:8: runtime error: upcast of misaligned address 0xfffffffffffffe49 for type 'crimson::os::seastore::LogicalChildNode', which requires 8 byte alignment
0xfffffffffffffe49: note: pointer points here
<memory cannot be printed>
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.cc:446:8 
/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.cc:450:29: runtime error: upcast of misaligned address 0xfffffffffffffe49 for type 'crimson::os::seastore::LogicalChildNode', which requires 8 byte alignment
0xfffffffffffffe49: note: pointer points here
<memory cannot be printed>
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.cc:450:29 
INFO  2025-02-26 12:36:11,482 [shard 0:main] seastore_epm - BackgroundProcess::run_until_halt: started...

and

Failed to load class: cas (/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/lib/libcls_cas.so): /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/lib/libcls_cas.so: undefined symbol: _Z26cls_get_manifest_ref_countPvNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
Failed to load class: cmpomap (/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/lib/libcls_cmpomap.so): /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/lib/libcls_cmpomap.so: undefined symbol: _Z28cls_cxx_map_get_vals_by_keysPvRKSt3setINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESt4lessIS6_ESaIS6_EEPSt3mapIS6_N4ceph6buffer7v15_2_04listES8_SaISt4pairIKS6_SH_EEE
Failed to load class: fifo (/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/lib/libcls_fifo.so): /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/lib/libcls_fifo.so: undefined symbol: _Z20cls_gen_random_bytesPci
Failed to load class: log (/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/lib/libcls_log.so): /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/lib/libcls_log.so: undefined symbol: _Z24cls_cxx_map_write_headerPvPN4ceph6buffer7v15_2_04listE
Failed to load class: rgw (/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/lib/libcls_rgw.so): /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/lib/libcls_rgw.so: undefined symbol: _Z19cls_get_object_infoPv
Failed to load class: user (/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/lib/libcls_user.so): /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/lib/libcls_user.so: undefined symbol: _Z24cls_cxx_map_write_headerPvPN4ceph6buffer7v15_2_04listE

@cyx1231st cyx1231st mentioned this pull request Feb 27, 2025
Merged
14 tasks
@Matan-B
Copy link
Contributor Author

Matan-B commented Mar 2, 2025

jenkins test make check arm64

Matan-B added 3 commits March 3, 2025 09:31
@Matan-B
seastar: bump up seastar submodule
ec4edf7 
Update branch to wip-matanb-seastar-feb-25

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
crimson: bump up seastar fixes
25a1611 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
test/crimson/seastore/CMakeLists: [arm64] disable omap manager
59df54e 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-crimson-seastar-feb-25 branch from 7f40e3e to 59df54e Compare March 3, 2025 09:33
@Matan-B
Copy link
Contributor Author

Matan-B commented Mar 3, 2025 •
edited
Loading 

8154782, 8154853 slow requests - https://tracker.ceph.com/issues/69612
8154802 - osd.3 bluestore op got ENOENT - https://tracker.ceph.com/issues/69438
8154810, 8154854 - osd.3, osd.1 ptr https://tracker.ceph.com/issues/70179
8154840 - osd.2 trim_to <= peering_state.get_pg_committed_to() - https://tracker.ceph.com/issues/69439
8154863, 8154867 - infra
8154874 - osd.0 - https://tracker.ceph.com/issues/70258

@Matan-B Matan-B merged commit 4697f4e into ceph:main Mar 3, 2025
11 checks passed
@Matan-B Matan-B moved this from Tested to Merged in Crimson Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyx1231st cyx1231st cyx1231st approved these changes

Assignees

No one assigned

Labels

build/ops crimson ready-to-merge TESTED tests wip-matan-testing

Projects

Crimson
Status: Merged (Pre Tentacle Freeze)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Matan-B @cyx1231st