fix(caser): ToSnake does not replace spaces with _#1148
Merged
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom Sep 4, 2023
Merged
fix(caser): ToSnake does not replace spaces with _#1148kodiakhq[bot] merged 6 commits intocloudquery:mainfrom
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom
Conversation
5 tasks
abc2dfe to
abf5536
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1148 +/- ##
==========================================
+ Coverage 48.29% 48.33% +0.03%
==========================================
Files 87 87
Lines 8152 8158 +6
==========================================
+ Hits 3937 3943 +6
Misses 3858 3858
Partials 357 357
☔ View full report in Codecov by Sentry. |
candiduslynx
approved these changes
Sep 4, 2023
hermanschaaf
approved these changes
Sep 4, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 4, 2023
🤖 I have created a release *beep* *boop* --- ## [4.6.4](v4.6.3...v4.6.4) (2023-09-04) ### Bug Fixes * **caser:** ToSnake does not replace spaces with _ ([#1148](#1148)) ([329b601](329b601)) * **deps:** Update `github.com/grpc-ecosystem/go-grpc-middleware/v2` to `v2.0.0` ([#1197](#1197)) ([6d3f752](6d3f752)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #728
Another approach to #1094.
Instead of regular expressions we use
strings.Fieldsto get rid of the spaces and replace them with_. Then we use_as a word separator.