fix(caser): ToSnake does not replace spaces with _ (#1148)

erezrokah · web-flow · commit 329b60164148 · 2023-09-04T14:31:18.000Z
#### Summary Fixes #728 Another approach to #1094. Instead of regular expressions we use `strings.Fields` to get rid of the spaces and replace them with `_`. Then we use `_` as a word separator.
diff --git a/caser/caser.go b/caser/caser.go
@@ -78,10 +78,13 @@ func (c *Caser) ToSnake(s string) string {
 	var result string
 	var words []string
 	var lastPos int
+
+	s = strings.Join(strings.Fields(s), "_")
+
 	rs := []rune(s)
 
 	for i := 0; i < len(rs); i++ {
-		if i > 0 && unicode.IsUpper(rs[i]) {
+		if i > 0 && (unicode.IsUpper(rs[i]) || rs[i] == '_') {
 			// check if next word is initialism
 			if initialism := c.startsWithInitialism(s[lastPos:]); initialism != "" {
 				words = append(words, initialism)
@@ -100,6 +103,9 @@ func (c *Caser) ToSnake(s string) string {
 			}
 
 			words = append(words, s[lastPos:i])
+			if rs[i] == '_' {
+				i++
+			}
 			lastPos = i
 		}
 	}
diff --git a/caser/caser_test.go b/caser/caser_test.go
@@ -31,6 +31,17 @@ func Test_ToSnake(t *testing.T) {
 		{Camel: "IAMRoles", Snake: "iam_roles"},
 		{Camel: "testIAM", Snake: "test_iam"},
 		{Camel: "TestAWSMode", Snake: "test_aws_mode"},
+		{Camel: "Hello World", Snake: "hello_world"},
+		{Camel: "Hello Wor ld", Snake: "hello_wor_ld"},
+		{Camel: "Hello Wor Ld", Snake: "hello_wor_ld"},
+		{Camel: "Hello wor ld", Snake: "hello_wor_ld"},
+		{Camel: "Hello wOr ld", Snake: "hello_w_or_ld"},
+		{Camel: "Hello wOrOr ld", Snake: "hello_w_or_or_ld"},
+		{Camel: "H e l l o", Snake: "h_e_l_l_o"},
+		{Camel: "H e l l o ", Snake: "h_e_l_l_o"},
+		{Camel: " H e l l o", Snake: "h_e_l_l_o"},
+		{Camel: " H e l l o ", Snake: "h_e_l_l_o"},
+		{Camel: "Hello     World", Snake: "hello_world"},
 	}
 	t.Parallel()
 	c := New()
