Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08% ⚠️

Comparison is base (3f5dae9) 47.17% compared to head (4814550) 47.09%.
Report is 11 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
- Coverage   47.17%   47.09%   -0.08%     
==========================================
  Files          84       85       +1     
  Lines        7728     7792      +64     
==========================================
+ Hits         3646     3670      +24     
- Misses       3748     3787      +39     
- Partials      334      335       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⏱️ Benchmark results

Comparing with 8a6a2cc

• Glob-8 ns/op: 98.79 ⬇️ 0.90% decrease vs. 8a6a2cc

@erezrokah I will add unit test.

@erezrokah
If I am adding this {Camel: "Test Space", Snake: "test_space"} in Test_ToSnake case. Then test got fail

                Error:          Not equal: 
                                expected: "test_space"
                                actual  : "test__space"

After observing I come to know when I remove this word = strings.ReplaceAll(word, " ", "_") line from caser.go file the error become

                                expected: "test_space"
                                actual  : "test _space"

According to my observation
word = strings.ReplaceAll(word, " ", "") should be added to caser.go this will passing the test case.

PASS
ok      github.com/cloudquery/plugin-sdk/v4/caser       0.012s

@erezrokah What are your thoughts?

@erezrokah What are your thoughts?

Hi @ankur0904 thank you for looking into it, will that solution work for the following test {Camel: "Hello Wor ld", Snake: "hello_wor_ld"}?

I think we might need to first replace spaces on the entire string, then split the words, WDYT?

You can also use https://textedit.tools/snakecase to test

@erezrokah You are absolutely right {Camel: "Hello Wor ld", Snake: "hello_wor_ld"} gives the error.

@erezrokah I have updated the code, in this code I first replace spaces on the entire string then if there is __ then replace it with _. And also added some additional corner cases like e.g. leading trailing spaces h e l l o, h e l l o , h e l l o

Unit test I added

{Camel: "Hello World", Snake: "hello_world"},
{Camel: "Hello Wor ld", Snake: "hello_wor_ld"},
{Camel: "H e l l o", Snake: "h_e_l_l_o"},
{Camel: "H e l l o ", Snake: "h_e_l_l_o"},
{Camel: " H e l l o", Snake: "h_e_l_l_o"},
{Camel: " H e l l o ", Snake: "h_e_l_l_o"},

After running

$ go test
PASS
ok      github.com/cloudquery/plugin-sdk/v4/caser       0.006s

Thanks for following up @ankur0904, looks better but I think it's missing {Camel: "Hello World", Snake: "hello_wor_ld"}, (see the multiple spaces).

@erezrokah Apologize, I have forgotten to mention that.

@erezrokah Does anything else we need to change?

@erezrokah Does anything else we need to change?

Sorry for the late reply. I missed your last commit. I'll take a look tomorrow.

@erezrokah

@erezrokah Does anything else we need to change?

Sorry for the late reply. I missed your last commit. I'll take a look tomorrow.

Can this PR be merged?

Can this PR be merged?

Hi @ankur0904, let me look at this again. I think this could be simplified to replace the spaces once before splitting the words.

@erezrokah Should I need to change the code?

@erezrokah Should I need to change the code?

Not yet, I'll comment on the PR if that's needed

@erezrokah OK

Hi @ankur0904 I opened #1148 as a draft with a different approach to get rid of the spaces. I think that's more consistent with the current code (doesn't use regular expressions). Please let me know what you think

@erezrokah #1148 That looks fine and more consistent.

Closing, as #1198 was released as part of v4.6.4