Update to Yarn 3 by nicolo-ribaudo · Pull Request #13140 · babel/babel

nicolo-ribaudo · 2021-04-12T14:18:04Z

Q	A
Any Dependency Changes?	Yes, Yarn (committed dev dependency)
License	MIT

Yarn 3 isn't stable yet, but I want to verify that it doesn't introduce any unexpected regression in our workflow.

~~It currently breaks our release tool, but it's a known breaking change.~~

What works so far:

yarn install (also with the condition: plugin)
yarn install works on CI (feat: make enableImmutableInstalls default to true on ci yarnpkg/berry#2530)
yarn release-tool version
yarn release-tool publish

You can see the breaking changes list at https://github.com/yarnpkg/berry/blob/master/CHANGELOG.md#breaking-changes. We are affected by:

Node.js 10 has been dropped
Yarn runs with --immutable by default on CI
There are workarounds/changes for both of them.

babel-bot · 2021-04-12T14:24:53Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48746/

codesandbox-ci · 2021-04-12T14:25:10Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 62c08b9:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

merceyz · 2021-05-18T16:54:36Z

Would you be willing to change this PR to use the CLI from yarnpkg/berry#2161 and enable PnP for the build step again? I updated the PR over the weekend and added tests based on your comments from last time and fixed some issues that caused it to crash when running yarn gulp in this repo, it looks like it works but would be nice to have the CI agree.

nicolo-ribaudo · 2021-05-18T20:22:18Z

Ok, sure!

nicolo-ribaudo · 2021-05-20T22:45:44Z

When using PnP the generated @babel/standalone bundle is broken, but it might be caused by something else (maybe Rollup).

merceyz · 2021-05-21T09:14:24Z

Yeah I saw that, looked into the bundle but nothing stood out, I see the methods are missing but not sure why

merceyz · 2021-05-21T09:37:02Z

These two imports are merged into one https://github.com/facebook/regenerator/blob/dbbddd9bd8c099ed1cdfcecdd077b8b4e7f43042/packages/transform/src/leap.js#L10-L11 so it's trying to get inherits from ./util which doesn't exist

merceyz · 2021-05-31T11:58:44Z

Got some time to look into it and it looks like a bug on our end, I'll fix it

nicolo-ribaudo · 2021-05-31T13:25:04Z

Oh thanks! Let me know when I have to update this PR.

nicolo-ribaudo · 2021-07-26T21:50:00Z

Yarn 3 has been released! I removed the commit to test yarnpkg/berry#2161 since that PR has been deferred to a later version. I'll update a new branch PR if we'll have to test ESM support before that it's merged.

nicolo-ribaudo · 2021-07-26T21:52:08Z

@arcanis Was the --skip-builds option removed? It's not mentioned in the changelog 🤔

arcanis · 2021-07-26T22:02:07Z

It got replaced by --mode=skip-build, I'll add it to the changelog 👍

nicolo-ribaudo · 2021-07-28T21:48:23Z

The CI failure looks related

larixer · 2021-07-29T16:37:12Z

@nicolo-ribaudo I'm not sure that its related, but why did you do:

Have you seen that it fails?

arcanis · 2021-07-29T16:38:46Z

Running the following locally seems to work for me - could it just be that your trunk has legit breaking changes that would break using a version of @babel/types at the same time as the trunk one? I don't see other e2e-breaking-pr tests running so I can't compare 🤔

rm -rf /tmp/jest
git clone --depth=1 https://github.com/facebook/jest /tmp/jest 
cd /tmp/jest
node -e "
  var pkg = require('./package.json');
  pkg.resolutions || (pkg.resolutions = {});
  pkg.resolutions['@types/babel__traverse/@babel/types'] = 'latest';
  fs.writeFileSync('./package.json', JSON.stringify(pkg, null, 2));
"
yarn install
yarn build

nicolo-ribaudo · 2021-07-29T20:28:29Z

Yeah, I think that "related" is more something on our side uncovered by an innocuous change in Yarn.

@larixer I don't remember, I'll revert it back 😅

nicolo-ribaudo · 2021-07-29T21:28:27Z

Ok, it looks like I used npm to install verdaccio because Yarn 3 throws:

+ yarn global add verdaccio-memory@~9.7.2
Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation)

merceyz · 2021-09-11T16:05:03Z

We have a compat layer that is supposed to handle that 🤔

nicolo-ribaudo · 2021-09-11T16:35:30Z

package.json

    "test:runtime:bundlers": "node test/runtime-integration/bundlers.cjs",
    "test:runtime:node": "node test/runtime-integration/node.cjs"
  },
+  "packageManager": "yarn@3.0.0",


Q: Is this for corepack?

Yes, when corepack is enabled running yarn will launch yarn@3.0.0 which will check yarnPath and use that binary if it doesn't match the one corepack launched

merceyz

CI is passing but @yarnpkg/plugin-constraints should be updated as well

nicolo-ribaudo · 2021-09-11T17:59:22Z

Greeeen 🥳

nicolo-ribaudo · 2021-09-16T15:46:25Z

After merging this I'll do something like yarnpkg/berry#3431

hzoo

nice work, verifying is much easier than testing ci..

merceyz · 2021-09-17T13:03:02Z

The issue in #13140 (comment) has been fixed and the ESM PR has been updated

nicolo-ribaudo added PR: Dependency ⬆️ PR: Internal 🏠 A type of pull request used for our changelog categories labels Apr 12, 2021

nicolo-ribaudo force-pushed the yarn-3 branch 4 times, most recently from 443f538 to 69cb6c0 Compare April 16, 2021 22:42

nicolo-ribaudo force-pushed the yarn-3 branch 4 times, most recently from 06a4f60 to 3173ba8 Compare May 19, 2021 22:36

nicolo-ribaudo force-pushed the yarn-3 branch from 3173ba8 to 2d106ce Compare July 26, 2021 21:48

nicolo-ribaudo marked this pull request as ready for review July 27, 2021 21:15

nicolo-ribaudo force-pushed the yarn-3 branch from 95a7b41 to b564ad0 Compare July 29, 2021 21:11

nicolo-ribaudo force-pushed the yarn-3 branch from 2dd572f to def5a9e Compare September 11, 2021 16:01

nicolo-ribaudo force-pushed the yarn-3 branch 2 times, most recently from 77546b5 to 4f1e855 Compare September 11, 2021 16:18

nicolo-ribaudo commented Sep 11, 2021

View reviewed changes

merceyz reviewed Sep 11, 2021

View reviewed changes

nicolo-ribaudo requested review from JLHwung and hzoo September 11, 2021 17:59

nicolo-ribaudo added 12 commits September 16, 2021 17:48

Update to Yarn 3

347c722

--skip-builds -> --mode=skip-build

04fe6f4

Install verdaccio with yarn again

92cd0ce

Update

d8d6e5e

Debug

ddeecfa

Update

3880454

Update release and conditions plugins

02cfad5

Yarn 3.0.2

5fcd023

Remove debug code

2fcce63

Regenerate lockfile

926b413

Update @yarnpkg/plugin-constraints

1fc324a

Update .yarnrc

62c08b9

nicolo-ribaudo force-pushed the yarn-3 branch from c5ecef1 to 62c08b9 Compare September 16, 2021 15:49

hzoo approved these changes Sep 16, 2021

View reviewed changes

JLHwung approved these changes Sep 16, 2021

View reviewed changes

nicolo-ribaudo merged commit 2ffb198 into babel:main Sep 16, 2021

merceyz mentioned this pull request Sep 16, 2021

fix(compat): don't resolve missing modules to a file with the same name yarnpkg/berry#3455

Merged

3 tasks

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 18, 2021

github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2021

Uh oh!

Conversation

nicolo-ribaudo commented Apr 12, 2021 • edited by gitpod-io bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

babel-bot commented Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codesandbox-ci bot commented Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

merceyz commented May 18, 2021

Uh oh!

nicolo-ribaudo commented May 18, 2021

Uh oh!

nicolo-ribaudo commented May 20, 2021

Uh oh!

merceyz commented May 21, 2021

Uh oh!

merceyz commented May 21, 2021

Uh oh!

merceyz commented May 31, 2021

Uh oh!

nicolo-ribaudo commented May 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo commented Jul 26, 2021

Uh oh!

nicolo-ribaudo commented Jul 26, 2021

Uh oh!

arcanis commented Jul 26, 2021

Uh oh!

nicolo-ribaudo commented Jul 28, 2021

Uh oh!

larixer commented Jul 29, 2021

Uh oh!

arcanis commented Jul 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo commented Jul 29, 2021

Uh oh!

nicolo-ribaudo commented Jul 29, 2021

Uh oh!

merceyz commented Sep 11, 2021

Uh oh!

nicolo-ribaudo Sep 11, 2021

Choose a reason for hiding this comment

Uh oh!

merceyz Sep 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

merceyz left a comment

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo commented Sep 11, 2021

Uh oh!

nicolo-ribaudo commented Sep 16, 2021

Uh oh!

hzoo left a comment

Choose a reason for hiding this comment

Uh oh!

merceyz commented Sep 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nicolo-ribaudo commented Apr 12, 2021 •

edited by gitpod-io bot

Loading

babel-bot commented Apr 12, 2021 •

edited

Loading

codesandbox-ci bot commented Apr 12, 2021 •

edited

Loading

nicolo-ribaudo commented May 31, 2021 •

edited

Loading

arcanis commented Jul 29, 2021 •

edited

Loading

merceyz Sep 11, 2021 •

edited

Loading