Skip to content

feat: make enableImmutableInstalls default to true on ci#2530

Merged
paul-soporan merged 2 commits intomasterfrom
paul/feat/immutable-on-ci
Feb 27, 2021
Merged

feat: make enableImmutableInstalls default to true on ci#2530
paul-soporan merged 2 commits intomasterfrom
paul/feat/immutable-on-ci

Conversation

@paul-soporan
Copy link
Copy Markdown
Member

What's the problem this PR addresses?

This PR makes Yarn immutable by default on CI. One of the v3 roadmap items and something that was discussed previously in the v1 repo: yarnpkg/yarn#5869.

How did you fix it?

...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

Copy link
Copy Markdown
Member

@arcanis arcanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paul-soporan paul-soporan merged commit f958c1f into master Feb 27, 2021
@paul-soporan paul-soporan deleted the paul/feat/immutable-on-ci branch February 27, 2021 17:58
This was referenced Feb 27, 2021
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 12, 2021
4 tasks
@rarkins
Copy link
Copy Markdown

rarkins commented Apr 12, 2021

@paul-soporan @arcanis is there any chance this behavior leaked into Yarn 2.x? My best guess about renovatebot/renovate#9481 is that it's caused by Renovate setting CI=true in env, but they're using 2.4.0-git.20210409.hash-2988e810

@arcanis
Copy link
Copy Markdown
Member

arcanis commented Apr 12, 2021

2.4.0-git.*** is 2.4.0 + whatever was on master at the specified time (it's basically a nightly build), so yep, that's not surprising. Builds made from sources are fairly rare though (comparatively).

@rarkins
Copy link
Copy Markdown

rarkins commented Apr 12, 2021

Thanks, understood. FYI we will now set enableImmutableInstalls=false for all yarn>=2.

unicornware added a commit to flex-development/dist-tag-action that referenced this pull request Aug 10, 2022
- installs are immutable by default; `--immutable` is not needed - yarnpkg/berry#2530
- @dependabot is allowed to modify lockfile - yarnpkg/berry#3486

Signed-off-by: Lexus Drumgold <unicornware@flexdevelopment.llc>
unicornware added a commit to flex-development/dist-tag that referenced this pull request Aug 13, 2022
- installs are immutable by default; `--immutable` is not needed - yarnpkg/berry#2530
- @dependabot is allowed to modify lockfile - yarnpkg/berry#3486

Signed-off-by: Lexus Drumgold <unicornware@flexdevelopment.llc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants