Skip to content

Add a test for YAML 1.1 types#483

Merged
ingydotnet merged 1 commit intoyaml:release/6.0from
perlpunk:perlpunk/schema
Sep 22, 2021
Merged

Add a test for YAML 1.1 types#483
ingydotnet merged 1 commit intoyaml:release/6.0from
perlpunk:perlpunk/schema

Conversation

@perlpunk
Copy link
Copy Markdown
Member

@perlpunk perlpunk commented Jan 25, 2021

This is the first step for supporting the YAML 1.2 Core schema.

https://github.com/perlpunk/yaml-test-schema has lots of test data for all the various YAML schemas/versions.

This PR adds

  • the testdata for YAML 1.1 to the test/data directory
  • a test loading and dumping all test data and check the results

Known bugs like missing boolean resolution for y, n etc. are skipped.

Also the test data file from https://github.com/perlpunk/yaml-test-schema is not yet in master.

@perlpunk perlpunk changed the base branch from perlpunk/schema to master January 25, 2021 02:17
@perlpunk perlpunk requested a review from ingydotnet January 25, 2021 12:31
@perlpunk
Copy link
Copy Markdown
Member Author

@ingydotnet could you please have a look?
This is just a draft, but if it's principally ok, I can move forward with the next steps for 1.2.
Considered that you are still interested in 1.2 support.

I added an issue with suggestions #486

@perlpunk perlpunk force-pushed the perlpunk/schema branch 2 times, most recently from cf9ecfa to 8f85b31 Compare February 5, 2021 23:52
@perlpunk
Copy link
Copy Markdown
Member Author

perlpunk commented Feb 6, 2021

This PR is now also used for #497

@perlpunk perlpunk force-pushed the perlpunk/schema branch 2 times, most recently from 82d08d7 to 2112b10 Compare March 26, 2021 17:31
@perlpunk perlpunk changed the base branch from master to release/6.0 September 21, 2021 23:26
Copy link
Copy Markdown
Member

@ingydotnet ingydotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just fix indent to 4.

@perlpunk perlpunk requested a review from ingydotnet September 22, 2021 16:32
@perlpunk perlpunk force-pushed the perlpunk/schema branch 2 times, most recently from 7389b12 to 4b9f1a4 Compare September 22, 2021 17:39
@perlpunk perlpunk marked this pull request as ready for review September 22, 2021 17:39
Copy link
Copy Markdown
Member

@ingydotnet ingydotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perlpunk perlpunk deleted the perlpunk/schema branch September 23, 2021 23:46
stuhood pushed a commit to pantsbuild/pants that referenced this pull request Oct 20, 2021
PyYAML 6:
```
6.0 (2021-10-13)

* yaml/pyyaml#327 -- Change README format to Markdown
* yaml/pyyaml#483 -- Add a test for YAML 1.1 types
* yaml/pyyaml#497 -- fix float resolver to ignore `.` and `._`
* yaml/pyyaml#550 -- drop Python 2.7
* yaml/pyyaml#553 -- Fix spelling of “hexadecimal”
* yaml/pyyaml#556 -- fix representation of Enum subclasses
* yaml/pyyaml#557 -- fix libyaml extension compiler warnings
* yaml/pyyaml#560 -- fix ResourceWarning on leaked file descriptors
* yaml/pyyaml#561 -- always require `Loader` arg to `yaml.load()`
* yaml/pyyaml#564 -- remove remaining direct distutils usage
```
halstead pushed a commit to openembedded/openembedded-core that referenced this pull request Oct 23, 2021
Now uses "vendored" distutils from setuptools by default
rather than from Python stdlib.

Changes
=======

* yaml/pyyaml#327
  -- Change README format to Markdown
* yaml/pyyaml#483
  -- Add a test for YAML 1.1 types
* yaml/pyyaml#497
  -- fix float resolver to ignore `.` and `._`
* yaml/pyyaml#550
  -- drop Python 2.7
* yaml/pyyaml#553
  -- Fix spelling of “hexadecimal”
* yaml/pyyaml#556
  -- fix representation of Enum subclasses
* yaml/pyyaml#557
  -- fix libyaml extension compiler warnings
* yaml/pyyaml#560
  -- fix ResourceWarning on leaked file descriptors
* yaml/pyyaml#561
  -- always require `Loader` arg to `yaml.load()`
* yaml/pyyaml#564
  -- remove remaining direct distutils usage

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
seambot pushed a commit to seamapi/poky that referenced this pull request Oct 23, 2021
Now uses "vendored" distutils from setuptools by default
rather than from Python stdlib.

Changes
=======

* yaml/pyyaml#327
  -- Change README format to Markdown
* yaml/pyyaml#483
  -- Add a test for YAML 1.1 types
* yaml/pyyaml#497
  -- fix float resolver to ignore `.` and `._`
* yaml/pyyaml#550
  -- drop Python 2.7
* yaml/pyyaml#553
  -- Fix spelling of “hexadecimal”
* yaml/pyyaml#556
  -- fix representation of Enum subclasses
* yaml/pyyaml#557
  -- fix libyaml extension compiler warnings
* yaml/pyyaml#560
  -- fix ResourceWarning on leaked file descriptors
* yaml/pyyaml#561
  -- always require `Loader` arg to `yaml.load()`
* yaml/pyyaml#564
  -- remove remaining direct distutils usage

(From OE-Core rev: 2abc7a612a71b3594f3183fbb824a708269ae694)

Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants