yaml.load(s, Loader=...) requires Loader= argument always by ingydotnet · Pull Request #561 · yaml/pyyaml

ingydotnet · 2021-09-22T22:58:34Z

No description provided.

perlpunk

Maybe it would make sense to keep the warning for another while.
Note that yaml.add_constructor (and other methods) will add given constructors to Loader, FullLoader and UnsafeLoader, so people will be wondering why none of their custom constructors have an effect.
It should be recommended to only use add_constructor for a specific loader, and ideally to their own loader inheriting from one of the existing loaders.
While (hopefully) most users by now are using a specific loader for loading, there is still code out there that just disables the warning, and will stop working if they used custom constructors via yaml.add_constructor.
If something stops working and they enable warnings to investigate, they should be able to see a helpful message saying that the default loader has now been changed.

ingydotnet · 2021-09-23T13:44:18Z

Maybe it would make sense to keep the warning for another while.

I'll add a warning if Full or Unsafe loaders had constructors added and load() is called without an explicit Loader=

ingydotnet · 2021-09-23T21:01:28Z

This started as load() defaults to Loader=SafeLoader but we all decided it was better to require Loader=... arg for load().

perlpunk

Is there a test for the missing argument case?

tests/lib/test_dump_load.py

nitzmahone · 2021-09-23T21:19:46Z

Makefile

@@ -1,5 +1,5 @@

-.PHONY: default build buildext force forceext install installext test testext dist clean


is this unintended stuff for this PR?

ingydotnet · 2021-09-23T21:29:41Z

Is there a test for the missing argument case?

Done in 1b2f534

PyYAML 6: ``` 6.0 (2021-10-13) * yaml/pyyaml#327 -- Change README format to Markdown * yaml/pyyaml#483 -- Add a test for YAML 1.1 types * yaml/pyyaml#497 -- fix float resolver to ignore `.` and `._` * yaml/pyyaml#550 -- drop Python 2.7 * yaml/pyyaml#553 -- Fix spelling of “hexadecimal” * yaml/pyyaml#556 -- fix representation of Enum subclasses * yaml/pyyaml#557 -- fix libyaml extension compiler warnings * yaml/pyyaml#560 -- fix ResourceWarning on leaked file descriptors * yaml/pyyaml#561 -- always require `Loader` arg to `yaml.load()` * yaml/pyyaml#564 -- remove remaining direct distutils usage ```

Now uses "vendored" distutils from setuptools by default rather than from Python stdlib. Changes ======= * yaml/pyyaml#327 -- Change README format to Markdown * yaml/pyyaml#483 -- Add a test for YAML 1.1 types * yaml/pyyaml#497 -- fix float resolver to ignore `.` and `._` * yaml/pyyaml#550 -- drop Python 2.7 * yaml/pyyaml#553 -- Fix spelling of “hexadecimal” * yaml/pyyaml#556 -- fix representation of Enum subclasses * yaml/pyyaml#557 -- fix libyaml extension compiler warnings * yaml/pyyaml#560 -- fix ResourceWarning on leaked file descriptors * yaml/pyyaml#561 -- always require `Loader` arg to `yaml.load()` * yaml/pyyaml#564 -- remove remaining direct distutils usage Signed-off-by: Tim Orling <timothy.t.orling@intel.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Now uses "vendored" distutils from setuptools by default rather than from Python stdlib. Changes ======= * yaml/pyyaml#327 -- Change README format to Markdown * yaml/pyyaml#483 -- Add a test for YAML 1.1 types * yaml/pyyaml#497 -- fix float resolver to ignore `.` and `._` * yaml/pyyaml#550 -- drop Python 2.7 * yaml/pyyaml#553 -- Fix spelling of “hexadecimal” * yaml/pyyaml#556 -- fix representation of Enum subclasses * yaml/pyyaml#557 -- fix libyaml extension compiler warnings * yaml/pyyaml#560 -- fix ResourceWarning on leaked file descriptors * yaml/pyyaml#561 -- always require `Loader` arg to `yaml.load()` * yaml/pyyaml#564 -- remove remaining direct distutils usage (From OE-Core rev: 2abc7a612a71b3594f3183fbb824a708269ae694) Signed-off-by: Tim Orling <timothy.t.orling@intel.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

PyYAML 6.0 [requires](yaml/pyyaml#561) a Loader argument to be passed to yaml.load. We could pass yaml.SafeLoader, or simply use the yaml.safe_load method instead. This PR opts to do the latter for simplicity. The previous default loader was yaml.Loader, and as such this PR changes the behaviour to yaml.SafeLoader. I don't think this has any actual repurcussions on the data that we're loading in however. https://msg.pyyaml.org/load has more details, and even recommends that FullLoader no longer be used.

… pyaml 6.0 Fixes https://gitlab.com/buildroot.org/buildroot/-/jobs/2088684091 python sample_python_pyyaml_dec.py Traceback (most recent call last): File "/root/sample_python_pyyaml_dec.py", line 5, in <module> data = yaml.load(serialized) TypeError: load() missing 1 required positional argument: 'Loader' yaml.load() requires a loader argument since the move to version 6.0: yaml/pyyaml#561 The test does not need the extra functionality of load(), so instead move to the recommended safe_load(). Signed-off-by: Peter Korsgaard <peter@korsgaard.com> Tested-by: Romain Naour <romain.naour@gmail.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Pyyaml>=6.0 requires to pass the Loader arg to yaml.load(), switching to yaml.safe_load() recovers the old and expected behavior. yaml/pyyaml#561 Closes-Bug: #1951650

* Use yaml.safe_load() Pyyaml>=6.0 requires to pass the Loader arg to yaml.load(), switching to yaml.safe_load() recovers the old and expected behavior. yaml/pyyaml#561 Closes-Bug: #1951650 * Use snapshot_support=True for manila share type The extra specs of a manila share type need to match the share service's capabilities. [1] [1] https://docs.openstack.org/manila/pike/admin/shared-file-systems-troubleshoot.html#id2 Closes-Bug: #1962204 Co-authored-by: Felipe Reyes <felipe.reyes@canonical.com> Co-authored-by: Corey Bryant <corey.bryant@canonical.com>

yaml.load in PyYAML 6 requires a Loader argument. PyYAML recommends using SafeLoader, which is implied if you call yaml.safe_load instead. yaml/pyyaml#561 https://msg.pyyaml.org/load Fixes Kludex#41

yaml.load in PyYAML 6 requires a Loader argument. PyYAML recommends using SafeLoader, which is implied if you call yaml.safe_load instead. yaml/pyyaml#561 https://msg.pyyaml.org/load Fixes #41

ingydotnet changed the base branch from master to release/6.0 September 22, 2021 22:59

perlpunk reviewed Sep 23, 2021

View reviewed changes

ingydotnet force-pushed the load-default-safe branch from 083203f to 1c1c55a Compare September 23, 2021 13:42

ingydotnet mentioned this pull request Sep 23, 2021

Loader dumper objects api #563

Draft

ingydotnet added 3 commits September 23, 2021 13:52

Makefile tweaks

102122a

Add a basic test file for yaml.load and yaml.dump

258ac95

The yaml.load{,_all} functions require Loader= now

af0275b

ingydotnet force-pushed the load-default-safe branch from 1c1c55a to af0275b Compare September 23, 2021 20:58

ingydotnet changed the title ~~yaml.load(s) defaults to yaml.load(s, Loader=yaml.SafeLoader)~~ yaml.load(s, Loader=...) requires Loader= argument always Sep 23, 2021

Thom1729 approved these changes Sep 23, 2021

View reviewed changes

perlpunk approved these changes Sep 23, 2021

View reviewed changes

perlpunk requested changes Sep 23, 2021

View reviewed changes

nitzmahone reviewed Sep 23, 2021

View reviewed changes

Add a test to assert load(s) fails

1b2f534

nitzmahone approved these changes Sep 23, 2021

View reviewed changes

perlpunk approved these changes Sep 23, 2021

View reviewed changes

ingydotnet merged commit 1b2f534 into release/6.0 Sep 23, 2021

ingydotnet deleted the load-default-safe branch September 23, 2021 21:40

sbesson mentioned this pull request Oct 14, 2021

PyYAML 6.0 load() function requires Loader argument #576

Open

zoobestik mentioned this pull request Oct 14, 2021

KTL-544: temporary strong version for pyyaml JetBrains/kotlin-web-site#2576

Merged

musicinmybrain mentioned this pull request Oct 15, 2021

Allow PyYAML 6.x fastapi/fastapi#4054

Closed

redblade7 mentioned this pull request Oct 17, 2021

PyYAML 6.0 changes FloatingGhost/danbooru-fediverse-poster#1

Open

gerritholl mentioned this pull request Oct 20, 2021

trollflow2 fails to launch with pyyaml 6.0 pytroll/trollflow2#121

Closed

ericwb mentioned this pull request Oct 24, 2021

Always use a Loader in yaml.load PyCQA/bandit#745

Merged

anoadragon453 mentioned this pull request Feb 8, 2022

Use yaml.safe_load instead of yaml.load in check-event-schema-examples.py matrix-org/matrix-spec-proposals#3716

Merged

ahesford mentioned this pull request Feb 21, 2022

python3-yaml: update to 6.0. void-linux/void-packages#35743

Merged

gnuoy mentioned this pull request Mar 25, 2022

Use yaml.safe_load() openstack-charmers/zaza-openstack-tests#727

Merged

carlwgeorge mentioned this pull request Apr 20, 2022

Use yaml.safe_load instead of yaml.load Kludex/python-multipart#46

Merged

antonymilne mentioned this pull request May 16, 2022

Update version of PyYAML to 6.x.x, dropping support for >=4.2, <6.0 kedro-org/kedro#1541

Closed

ShivamThukral mentioned this pull request Nov 4, 2022

[RST-6280] Support for YAML 6.0+ locusrobotics/copyrightify#2

Merged

Hawk777 mentioned this pull request Jan 14, 2023

Passing config_buffer option breaks with PyYAML6 due to extra required parameter zabertech/python-izaber#11

Closed

jnasselle mentioned this pull request Jul 18, 2023

Python requirements installation fails due to new Cython3 release wazuh/wazuh-qa#4325

Closed

This was referenced Jan 10, 2024

[euscollada/parseColladaBase.py] use different load function for different PyYAML version ban-masa/jsk_model_tools#1

Closed

[euscollada/parseColladaBase.py] always explicitly indicating SafeLoader when using yaml.load ban-masa/jsk_model_tools#2

Closed

rpatureau mentioned this pull request Apr 19, 2024

Compatibility with newer Python versions lbl-srg/BuildingsPy#547

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

yaml.load(s, Loader=...) requires Loader= argument always#561

yaml.load(s, Loader=...) requires Loader= argument always#561
ingydotnet merged 4 commits intorelease/6.0from
load-default-safe

ingydotnet commented Sep 22, 2021

Uh oh!

perlpunk left a comment

Uh oh!

ingydotnet commented Sep 23, 2021

Uh oh!

ingydotnet commented Sep 23, 2021

Uh oh!

perlpunk left a comment

Uh oh!

Uh oh!

nitzmahone Sep 23, 2021

Uh oh!

ingydotnet Sep 23, 2021

Uh oh!

ingydotnet commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -1,5 +1,5 @@

		.PHONY: default build buildext force forceext install installext test testext dist clean

Conversation

ingydotnet commented Sep 22, 2021

Uh oh!

perlpunk left a comment

Choose a reason for hiding this comment

Uh oh!

ingydotnet commented Sep 23, 2021

Uh oh!

ingydotnet commented Sep 23, 2021

Uh oh!

perlpunk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nitzmahone Sep 23, 2021

Choose a reason for hiding this comment

Uh oh!

ingydotnet Sep 23, 2021

Choose a reason for hiding this comment

Uh oh!

ingydotnet commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants