Skip to content

feat: allow to preserve legal comments with minify: true#4591

Merged
hyf0 merged 3 commits intomainfrom
05-17-feat_allow_to_preserve_legal_comments_with_minify_true_
May 17, 2025
Merged

feat: allow to preserve legal comments with minify: true#4591
hyf0 merged 3 commits intomainfrom
05-17-feat_allow_to_preserve_legal_comments_with_minify_true_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented May 17, 2025

Description

@hyf0 hyf0 marked this pull request as ready for review May 17, 2025 11:29
This was referenced May 17, 2025
Merged
Merged
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented May 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 force-pushed the 05-17-chore_rust_remove_unused_legalcomments_preserve_ branch from 863eb99 to c0094f4 Compare May 17, 2025 11:32
@hyf0 hyf0 force-pushed the 05-17-feat_allow_to_preserve_legal_comments_with_minify_true_ branch 3 times, most recently from f0f1a66 to 702a21e Compare May 17, 2025 11:44
@hyf0 hyf0 mentioned this pull request May 17, 2025
Closed
@hyf0 hyf0 force-pushed the 05-17-feat_allow_to_preserve_legal_comments_with_minify_true_ branch from 702a21e to fb35479 Compare May 17, 2025 11:53
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2025

Benchmarks Rust

  • target: 05-17-chore_rust_remove_unused_legalcomments_preserve_(c0094f4)
  • pr: 05-17-feat_allow_to_preserve_legal_comments_with_minify_true_(fb35479)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     75.1±1.61ms        ? ?/sec    1.00     74.1±0.97ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     93.4±0.88ms        ? ?/sec    1.00     93.2±0.62ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    107.0±0.78ms        ? ?/sec    1.00    107.2±1.09ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     85.4±1.50ms        ? ?/sec    1.01     86.6±3.25ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    115.6±1.79ms        ? ?/sec    1.01    116.6±1.16ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    186.4±1.32ms        ? ?/sec    1.01    188.8±3.78ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.01    230.9±2.01ms        ? ?/sec    1.00    228.1±1.57ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    127.1±0.97ms        ? ?/sec    1.01    128.7±0.93ms        ? ?/sec
bundle/bundle@threejs                                               1.02     40.4±1.50ms        ? ?/sec    1.00     39.6±0.48ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     81.5±0.36ms        ? ?/sec    1.00     81.8±0.70ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.05    101.6±2.36ms        ? ?/sec    1.00     96.9±0.87ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.02     47.1±0.99ms        ? ?/sec    1.00     46.3±0.26ms        ? ?/sec
bundle/bundle@threejs10x                                            1.02    427.1±4.24ms        ? ?/sec    1.00    419.3±3.55ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1015.8±6.30ms        ? ?/sec    1.00   1010.9±5.61ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1194.6±3.77ms        ? ?/sec    1.00   1190.9±7.47ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01    487.1±3.67ms        ? ?/sec    1.00    483.1±2.65ms        ? ?/sec
remapping/remapping                                                 1.00     25.6±0.87ms        ? ?/sec    1.05     26.9±0.52ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     63.4±0.44ms        ? ?/sec    1.06     67.0±3.39ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     89.9±0.94ms        ? ?/sec    1.00     89.6±1.10ms        ? ?/sec
scan/scan@threejs                                                   1.00     30.3±0.33ms        ? ?/sec    1.03     31.2±1.89ms        ? ?/sec
scan/scan@threejs10x                                                1.00    308.9±3.72ms        ? ?/sec    1.00    310.2±2.32ms        ? ?/sec

Base automatically changed from 05-17-chore_rust_remove_unused_legalcomments_preserve_ to main May 17, 2025 13:19
@hyf0 hyf0 added this pull request to the merge queue May 17, 2025
Merged via the queue into main with commit 9a837fc May 17, 2025
28 checks passed
@hyf0 hyf0 deleted the 05-17-feat_allow_to_preserve_legal_comments_with_minify_true_ branch May 17, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @IWANABETHATGUY