Skip to content

chore(rust): remove unused LegalComments::Preserve#4590

Merged
hyf0 merged 2 commits intomainfrom
05-17-chore_rust_remove_unused_legalcomments_preserve_
May 17, 2025
Merged

chore(rust): remove unused LegalComments::Preserve#4590
hyf0 merged 2 commits intomainfrom
05-17-chore_rust_remove_unused_legalcomments_preserve_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented May 17, 2025

Description

@hyf0 hyf0 marked this pull request as ready for review May 17, 2025 10:47
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented May 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 mentioned this pull request May 17, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2025 •
edited
Loading

Benchmarks Rust

  • target: 05-17-chore_rust_remove_unused_ecmacompiler_print_(c01f95d)
  • pr: 05-17-chore_rust_remove_unused_legalcomments_preserve_(c0094f4)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.03     78.4±1.11ms        ? ?/sec    1.00     76.1±1.09ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.04     98.2±2.18ms        ? ?/sec    1.00     94.7±0.84ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    107.7±1.25ms        ? ?/sec    1.00    108.1±1.70ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.02     88.4±1.80ms        ? ?/sec    1.00     86.4±1.88ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    117.6±1.05ms        ? ?/sec    1.01    119.3±2.46ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    190.8±2.52ms        ? ?/sec    1.02    193.9±4.57ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.05    235.7±5.05ms        ? ?/sec    1.00    225.5±3.58ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    129.9±2.37ms        ? ?/sec    1.00    130.1±1.23ms        ? ?/sec
bundle/bundle@threejs                                               1.02     41.0±1.28ms        ? ?/sec    1.00     40.1±0.25ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     82.7±1.41ms        ? ?/sec    1.00     82.4±0.65ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.04    102.9±0.85ms        ? ?/sec    1.00     98.9±1.58ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.02     47.4±0.60ms        ? ?/sec    1.00     46.5±0.24ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    424.8±6.17ms        ? ?/sec    1.00    424.3±4.32ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1024.9±7.53ms        ? ?/sec    1.00   1020.4±5.95ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1202.8±7.51ms        ? ?/sec    1.01   1209.4±8.21ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    487.3±3.14ms        ? ?/sec    1.00    487.8±4.37ms        ? ?/sec
remapping/remapping                                                 1.00     24.6±3.04ms        ? ?/sec    1.05     25.7±0.39ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     64.1±0.52ms        ? ?/sec    1.12     71.7±5.74ms        ? ?/sec
scan/scan@rome-ts                                                   1.06     94.8±3.83ms        ? ?/sec    1.00     89.7±0.74ms        ? ?/sec
scan/scan@threejs                                                   1.04     31.5±0.40ms        ? ?/sec    1.00     30.3±0.44ms        ? ?/sec
scan/scan@threejs10x                                                1.02    313.8±4.81ms        ? ?/sec    1.00    308.0±4.14ms        ? ?/sec

@hyf0 hyf0 mentioned this pull request May 17, 2025
Merged
@hyf0 hyf0 force-pushed the 05-17-chore_rust_remove_unused_legalcomments_preserve_ branch from 863eb99 to c0094f4 Compare May 17, 2025 11:32
Base automatically changed from 05-17-chore_rust_remove_unused_ecmacompiler_print_ to main May 17, 2025 13:06
@hyf0 hyf0 added this pull request to the merge queue May 17, 2025
Merged via the queue into main with commit cbbf998 May 17, 2025
28 checks passed
@hyf0 hyf0 deleted the 05-17-chore_rust_remove_unused_legalcomments_preserve_ branch May 17, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@underfin underfin underfin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @underfin