Skip to content

chore(rust): remove unused EcmaCompiler#print#4589

Merged
shulaoda merged 1 commit intomainfrom
05-17-chore_rust_remove_unused_ecmacompiler_print_
May 17, 2025
Merged

chore(rust): remove unused EcmaCompiler#print#4589
shulaoda merged 1 commit intomainfrom
05-17-chore_rust_remove_unused_ecmacompiler_print_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented May 17, 2025

Description

@hyf0 hyf0 marked this pull request as ready for review May 17, 2025 10:47
Copilot AI review requested due to automatic review settings May 17, 2025 10:47
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented May 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented May 17, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit c01f95d
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68286923ce77ac0008d14638

@hyf0 hyf0 mentioned this pull request May 17, 2025
Merged
Copilot AI reviewed May 17, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unused EcmaCompiler#print function and updates the test to use the existing print_with function.

  • Removed the unused print function
  • Updated the test to call print_with
  • Added derive(Debug, Default) for PrintOptions for consistency

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2025

Benchmarks Rust

  • target: main(df7075d)
  • pr: 05-17-chore_rust_remove_unused_ecmacompiler_print_(c01f95d)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.02     75.9±1.82ms        ? ?/sec    1.00     74.3±1.39ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     94.3±1.29ms        ? ?/sec    1.03     97.2±2.33ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    107.1±1.11ms        ? ?/sec    1.02    109.7±1.90ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     84.8±1.11ms        ? ?/sec    1.05     88.8±3.17ms        ? ?/sec
bundle/bundle@rome-ts                                               1.02    118.5±1.25ms        ? ?/sec    1.00    116.6±1.27ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.03    194.4±1.66ms        ? ?/sec    1.00    188.7±4.41ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.04    237.3±5.94ms        ? ?/sec    1.00    227.9±4.76ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    130.2±1.56ms        ? ?/sec    1.00    128.5±1.02ms        ? ?/sec
bundle/bundle@threejs                                               1.01     41.1±1.65ms        ? ?/sec    1.00     40.6±1.53ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.02     84.0±0.77ms        ? ?/sec    1.00     82.5±1.74ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.03     99.8±1.21ms        ? ?/sec    1.00     96.7±0.95ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.02     47.9±0.65ms        ? ?/sec    1.00     47.1±0.71ms        ? ?/sec
bundle/bundle@threejs10x                                            1.03    427.9±5.32ms        ? ?/sec    1.00    416.9±3.07ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.01   1028.2±6.59ms        ? ?/sec    1.00   1017.3±5.87ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01   1208.6±5.05ms        ? ?/sec    1.00   1192.1±4.30ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01    488.3±1.96ms        ? ?/sec    1.00    483.2±2.07ms        ? ?/sec
remapping/remapping                                                 1.01     25.9±0.59ms        ? ?/sec    1.00     25.6±1.11ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     67.0±4.18ms        ? ?/sec    1.01     67.9±5.11ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     93.1±1.29ms        ? ?/sec    1.00     92.4±1.08ms        ? ?/sec
scan/scan@threejs                                                   1.02     31.5±0.51ms        ? ?/sec    1.00     30.9±0.85ms        ? ?/sec
scan/scan@threejs10x                                                1.03    318.2±3.00ms        ? ?/sec    1.00    310.0±2.72ms        ? ?/sec

@hyf0 hyf0 mentioned this pull request May 17, 2025
Merged
@shulaoda shulaoda added this pull request to the merge queue May 17, 2025
Merged via the queue into main with commit d2b8076 May 17, 2025
35 checks passed
@shulaoda shulaoda deleted the 05-17-chore_rust_remove_unused_ecmacompiler_print_ branch May 17, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@underfin underfin underfin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hyf0 @underfin @shulaoda