Skip to content
/ rector-src Public

[TypeDeclaration] Add AddClosureReturnTypeFromStrictNativeCallRector#6059

Merged
TomasVotruba merged 1 commit intomainfrom
native-return-closure
Jun 28, 2024
Merged

[TypeDeclaration] Add AddClosureReturnTypeFromStrictNativeCallRector#6059
TomasVotruba merged 1 commit intomainfrom
native-return-closure

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Jun 27, 2024

Part of resolve this issue effort:

Ref from PR comment:

this PR extract Closure from ReturnTypeFromStrictNativeCallRector into separate new rule: AddClosureReturnTypeFromStrictNativeCallRector special for Closure only.

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Jun 27, 2024

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Jun 27, 2024

Rebase is needed

@samsonasik samsonasik force-pushed the native-return-closure branch from 545adad to 636bace Compare June 28, 2024 01:24
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Jun 28, 2024

Rebased 👍

@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Jun 28, 2024

Thank you 👍

@TomasVotruba TomasVotruba merged commit 0796b92 into main Jun 28, 2024
@TomasVotruba TomasVotruba deleted the native-return-closure branch June 28, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik @TomasVotruba