Skip to content

[TypeDeclaration] Separate Closure return type#6029

Closed
samsonasik wants to merge 4 commits intomainfrom
narrow-closure
Closed

[TypeDeclaration] Separate Closure return type#6029
samsonasik wants to merge 4 commits intomainfrom
narrow-closure

Conversation

@samsonasik
Copy link
Copy Markdown
Member

No description provided.

@samsonasik samsonasik marked this pull request as draft June 25, 2024 04:22
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Jun 25, 2024

I removed failing fixtures for Closure/ArrowFunction add return 6515c39, based on them, I think we can categorize by type, eg:

  • AddClosureArrayReturnTypeRector
  • AddClosureScalarReturnTypeRector
  • AddClosureUnionReturnTypeRector
  • etc

that can be in separate PRs to add first, before it can be merged so all features covered first...

existing rules for Closure are:

  • AddClosureVoidReturnTypeWhereNoReturnRector

for ArrowFunction, we have already AddArrowFunctionReturnTypeRector ;)

@TomasVotruba
Copy link
Copy Markdown
Member

Could you rebase this one? I want to merge it before I do some duplicated/conflicting changes in the set

@TomasVotruba TomasVotruba marked this pull request as ready for review July 2, 2024 13:56
@samsonasik
Copy link
Copy Markdown
Member Author

I think I can close it for now, to revisit later for possible more by type improvement, as currently the left over is too detail and make it too much rules to extract...

@samsonasik samsonasik closed this Jul 2, 2024
@samsonasik samsonasik deleted the narrow-closure branch July 2, 2024 14:00
@TomasVotruba
Copy link
Copy Markdown
Member

I see, I'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants