feat(config): add support for engine?: 'js' | 'classic'#28266
Merged
Conversation
engine?: 'js' | 'classic'
…neConfig", which influences the "primaryDatasource" output
Contributor
size-limit report 📦
|
Contributor
|
Client memory tests, node 24, library: ✅ Success |
…into feat/prisma-config-engine
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying the schema engine type via an engine?: 'js' | 'classic' configuration option in Prisma config files, replacing the previous implicit adapter field approach.
Key Changes:
- Replaces
adapterfield with explicitengineconfiguration to select between JavaScript and classic schema engines - Updates validation logic to check
engine === 'js'instead of presence ofadapterfield - Refactors schema loading to support classic engine with direct datasource configuration
Reviewed Changes
Copilot reviewed 47 out of 48 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/config/src/PrismaConfig.ts | Adds new schema engine config types and shapes, replaces adapter-based validation |
| packages/config/src/defineConfig.ts | Refactors engine configuration logic to handle both 'js' and 'classic' engines |
| packages/migrate/src/Migrate.ts | Updates Migrate.setup to use schemaEngineConfig instead of adapter parameter |
| packages/internals/src/cli/schemaContext.ts | Adds support for classic engine datasource overrides in schema context |
| packages/migrate/src/commands/*.ts | Updates all migrate commands to use new engine configuration pattern |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
🟢 All good, this PR is no longer uses custom engine. |
This reverts commit 5cfe495.
jkomyno
commented
Oct 13, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…into feat/prisma-config-engine
jkomyno
commented
Oct 13, 2025
jkomyno
commented
Oct 13, 2025
jkomyno
commented
Oct 13, 2025
jkomyno
added a commit
to prisma/prisma-engines
that referenced
this pull request
Oct 14, 2025
…a Config file (#5645) This PR: - contributes to [TML-1332](https://linear.app/prisma-company/issue/TML-1332/prisma-config-alternative-to-url-directurl-shadowdatabaseurl) - complements prisma/prisma#28266 - adds `--datasource` to `schema-engine-cli`, which is a JSON-encoded object used to override PSL's `datasource` URL-like attributes --------- Co-authored-by: jkomyno <12381818+jkomyno@users.noreply.github.com>
…into feat/prisma-config-engine
jacek-prisma
approved these changes
Oct 14, 2025
aqrln
added a commit
that referenced
this pull request
Oct 16, 2025
Conflicts in `packages/config` were automatically solved using [Mergiraf](https://mergiraf.org/). Commits: - **fix: fix neon listener leak (#28255)** - **feat(qpe): add an option to disable logging to console (#28253)** - **feat(adapter-mssql): support multiSubnetFailover flag in connection string (#28261)** - **chore: use pnpm catalog (#28236)** - **fix: revert "chore: use pnpm catalog (#28236)" (#28271)** - **chore: upgrade OpenTelemetry deps and refresh tracing setup in client (#28268)** - **chore(deps): update engines to 6.18.0-3.b03d75f1a67e62289420f5697c28a3ff8dbb0424 (#28258)** - **feat(qpe): expose package version as an export (#28275)** - **feat: support OpenTelemetry in loadable sub-commands (#28272)** - **chore(deps): update engines to 6.18.0-6.9bf76dbea6c9e34d59a3577015bd1e94bfda7624 (#28288)** - **fix(adapter-pg): historical dates (#28212)** - **chore(deps): update engines to 6.18.0-7.d3fc122f88ca3ce86f67a797debfb179a39ccf48 (#28293)** - **fix: support multiple Prisma instances with different providers (#28291)** - **feat(config): add support for `engine?: 'js' | 'classic'` (#28266)**
Contributor
|
I've been wondering about these changes: I would expect that when I'm adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
engine: 'classic'in Prisma Config file prisma-engines#5645.