Merged
Conversation
Contributor
Author
|
@aqrln @jacek-prisma any suggestions? should I proceed with it and put more dependencies into catalog? |
Contributor
|
@dulmandakh I think it's a good idea to use the catalog for most dependencies |
Member
|
I like this as well. We are already using workspace dependencies in https://github.com/prisma/prisma-engines, so it's nice if we can do the same on TypeScript side. |
8652af1 to
59382f9
Compare
59382f9 to
20a3a45
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces PNPM catalog to centralize dependency version management across the workspace. The catalog allows for consistent versioning by defining dependency versions once in the root workspace file.
Key changes:
- Added catalog section to
pnpm-workspace.yamlwith 68 common dependencies and their versions - Updated all package.json files to reference catalog versions using
"catalog:"instead of explicit version numbers - Removed some unused devDependencies (like
vitest) from certain packages
Reviewed Changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Added catalog section with 68 dependency versions |
| packages/*/package.json | Updated dependency references to use catalog versions |
| package.json | Updated root dependencies to use catalog versions |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aqrln
approved these changes
Oct 9, 2025
Contributor
Author
|
@aqrln please retry the failing test |
jacek-prisma
added a commit
that referenced
this pull request
Oct 10, 2025
This reverts commit 10fab6b.
jacek-prisma
added a commit
that referenced
this pull request
Oct 10, 2025
This reverts commit 10fab6b. This reverts the inclusion and usages of pnpm catalog. The reason for reverting the change is that it breaks the prisma-engines test pipeline (see https://github.com/prisma/prisma-engines/actions/runs/18382915995/job/52373895545) and we have no simple fix for it.
aqrln
added a commit
that referenced
this pull request
Oct 16, 2025
Conflicts in `packages/config` were automatically solved using [Mergiraf](https://mergiraf.org/). Commits: - **fix: fix neon listener leak (#28255)** - **feat(qpe): add an option to disable logging to console (#28253)** - **feat(adapter-mssql): support multiSubnetFailover flag in connection string (#28261)** - **chore: use pnpm catalog (#28236)** - **fix: revert "chore: use pnpm catalog (#28236)" (#28271)** - **chore: upgrade OpenTelemetry deps and refresh tracing setup in client (#28268)** - **chore(deps): update engines to 6.18.0-3.b03d75f1a67e62289420f5697c28a3ff8dbb0424 (#28258)** - **feat(qpe): expose package version as an export (#28275)** - **feat: support OpenTelemetry in loadable sub-commands (#28272)** - **chore(deps): update engines to 6.18.0-6.9bf76dbea6c9e34d59a3577015bd1e94bfda7624 (#28288)** - **fix(adapter-pg): historical dates (#28212)** - **chore(deps): update engines to 6.18.0-7.d3fc122f88ca3ce86f67a797debfb179a39ccf48 (#28293)** - **fix: support multiple Prisma instances with different providers (#28291)** - **feat(config): add support for `engine?: 'js' | 'classic'` (#28266)**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR introduces PNPM catalog to ease dependency version management. https://pnpm.io/catalogs