feat(qpe): add an option to disable logging to console#28253
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to disable console logging in the query plan executor by introducing an 'off' log level option. This is needed for prisma dev integration where console logging may not be desired.
- Added a new
ConsoleLogLeveltype that extendsLogLevelwith an 'off' option - Implemented a
DroppingSinkclass that silently discards all log events - Updated the console logger factory to use the dropping sink when log level is 'off'
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/query-plan-executor/src/options.ts | Defines new ConsoleLogLevel type and updates LogOptions interface |
| packages/query-plan-executor/src/log/sink.ts | Adds DroppingSink class for discarding log events |
| packages/query-plan-executor/src/log/sink.test.ts | Adds unit tests for the new DroppingSink class |
| packages/query-plan-executor/src/log/factory.ts | Updates console logger factory to handle 'off' log level |
| packages/query-plan-executor/src/log/factory.test.ts | Adds comprehensive tests for the updated logger factory |
| packages/query-plan-executor/src/index.ts | Exports the new ConsoleLogLevel type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
6df60ca to
9cba426
Compare
jacek-prisma
reviewed
Oct 9, 2025
Contributor
size-limit report 📦
|
jacek-prisma
previously approved these changes
Oct 9, 2025
1d82e61 to
2be28d8
Compare
jacek-prisma
approved these changes
Oct 9, 2025
aqrln
added a commit
that referenced
this pull request
Oct 16, 2025
Conflicts in `packages/config` were automatically solved using [Mergiraf](https://mergiraf.org/). Commits: - **fix: fix neon listener leak (#28255)** - **feat(qpe): add an option to disable logging to console (#28253)** - **feat(adapter-mssql): support multiSubnetFailover flag in connection string (#28261)** - **chore: use pnpm catalog (#28236)** - **fix: revert "chore: use pnpm catalog (#28236)" (#28271)** - **chore: upgrade OpenTelemetry deps and refresh tracing setup in client (#28268)** - **chore(deps): update engines to 6.18.0-3.b03d75f1a67e62289420f5697c28a3ff8dbb0424 (#28258)** - **feat(qpe): expose package version as an export (#28275)** - **feat: support OpenTelemetry in loadable sub-commands (#28272)** - **chore(deps): update engines to 6.18.0-6.9bf76dbea6c9e34d59a3577015bd1e94bfda7624 (#28288)** - **fix(adapter-pg): historical dates (#28212)** - **chore(deps): update engines to 6.18.0-7.d3fc122f88ca3ce86f67a797debfb179a39ccf48 (#28293)** - **fix: support multiple Prisma instances with different providers (#28291)** - **feat(config): add support for `engine?: 'js' | 'classic'` (#28266)**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary for
prisma dev: https://github.com/prisma/team-expansion/pull/1903/files#r2322689633Part of https://linear.app/prisma-company/issue/TML-1317/add-qc-support-in-local-ppg-with-accelerate-api