Skip to content

[backport 24.0] builder-next: Set moby exporter as default#45692

Merged
neersighted merged 1 commit intomoby:24.0from
vvoland:builder-use-moby-exporter-by-default-24
Jun 2, 2023
Merged

[backport 24.0] builder-next: Set moby exporter as default#45692
neersighted merged 1 commit intomoby:24.0from
vvoland:builder-use-moby-exporter-by-default-24

Conversation

@vvoland
Copy link
Copy Markdown
Contributor

@vvoland vvoland commented Jun 2, 2023

Building via ImageBuild without exporter set made it use the image exporter by default, which didn't go through the same special handling as moby (setting unpack to true, sanitizing names, setting dangling image prefix).

(cherry picked from commit d63569c)

- What I did

  • Use moby exporter by default in the ImageBuild.

- How I did it

- How to verify it

- Description for the changelog
containerd integration: Fix images built with ImageBuild endpoint not created in Docker

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit d63569c)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added area/api API kind/bugfix PR's that fix bugs area/builder/buildkit Build containerd-integration Issues and PRs related to containerd integration labels Jun 2, 2023
@vvoland vvoland added this to the 24.0.3 milestone Jun 2, 2023
@vvoland vvoland requested a review from tonistiigi as a code owner June 2, 2023 14:07
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neersighted neersighted merged commit 8e70a1b into moby:24.0 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api API area/builder/buildkit Build containerd-integration Issues and PRs related to containerd integration kind/bugfix PR's that fix bugs status/4-merge

Projects

Development

Successfully merging this pull request may close these issues.

3 participants