Skip to content

builder-next: Set moby exporter as default#45690

Merged
thaJeztah merged 1 commit intomoby:masterfrom
vvoland:builder-use-moby-exporter-by-default
Jun 2, 2023
Merged

builder-next: Set moby exporter as default#45690
thaJeztah merged 1 commit intomoby:masterfrom
vvoland:builder-use-moby-exporter-by-default

Conversation

@vvoland
Copy link
Copy Markdown
Contributor

@vvoland vvoland commented Jun 2, 2023

Building via ImageBuild without exporter set made it use the image exporter by default, which didn't go through the same special handling as moby (setting unpack to true, sanitizing names, setting dangling image prefix).

- What I did

  • Use moby exporter by default in the ImageBuild.

- How I did it

- How to verify it

- Description for the changelog
containerd integration: Fix images built with ImageBuild endpoint not created in Docker

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added area/api API status/2-code-review kind/bugfix PR's that fix bugs area/builder/buildkit Build containerd-integration Issues and PRs related to containerd integration labels Jun 2, 2023
@vvoland vvoland added this to the 25.0.0 milestone Jun 2, 2023
@vvoland vvoland requested a review from tonistiigi as a code owner June 2, 2023 13:42
@thaJeztah thaJeztah merged commit 4d34c1c into moby:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

build: ImageBuild api sending incorrect SHA when building without tag

4 participants