build: ImageBuild api sending incorrect SHA when building without tag #45665
Description
Description
When you build an image without a tag, the ImageBuild API sends back a SHA that doesn't match where the image is stored.
Reproduce
The only way to reproduce this is to interact with the API directly. Here's a helper script I wrote to print the build events as a JSON stream:
- Check out tilt's buildkitapi script.
git clone git@github.com:tilt-dev/tilt
cd tilt
go install ./cmd/buildkitapi
- Run
buildkitapi --legacy build .You should get ouptut like this:
$ DOCKER_HOST=unix:///home/nick/.docker/desktop/docker.sock buildkitapi --legacy build .
{"ID":"sha256:822125e0d81c31235dbc3909e91f24e49246365b1f8f344c3ca683abe5caf2eb"}
- Inspect the SHA that you get back.
docker image inspect sha256:822125e0d81c31235dbc3909e91f24e49246365b1f8f344c3ca683abe5caf2eb
[]
Error response from daemon: No such image: sha256:822125e0d81c31235dbc3909e91f24e49246365b1f8f344c3ca683abe5caf2eb
Expected behavior
The image should be in the containerd image store.
docker version
Client: Docker Engine - Community
Cloud integration: v1.0.33
Version: 24.0.2
API version: 1.43
Go version: go1.20.4
Git commit: cb74dfc
Built: Thu May 25 21:51:00 2023
OS/Arch: linux/amd64
Context: desktop-linux
Server: Docker Desktop 4.21.0 (110149)
Engine:
Version: 24.0.2
API version: 1.43 (minimum version 1.12)
Go version: go1.20.4
Git commit: 659604f9ee60f147020bdd444b26e4b5c636dc28
Built: Fri May 26 00:37:28 2023
OS/Arch: linux/amd64
Experimental: false
containerd:
Version: 1.6.21
GitCommit: 3dce8eb055cbb6872793272b4f20ed16117344f8
runc:
Version: 1.1.7
GitCommit: v1.1.7-0-g860f061
docker-init:
Version: 0.19.0
GitCommit: de40ad0docker info
Client: Docker Engine - Community
Version: 24.0.2
Context: desktop-linux
Debug Mode: false
Plugins:
buildx: Docker Buildx (Docker Inc.)
Version: v0.0.1-cloud-driver+005
Path: /home/nick/.docker/cli-plugins/docker-buildx
compose: Docker Compose (Docker Inc.)
Version: v2.18.1
Path: /usr/lib/docker/cli-plugins/docker-compose
dev: Docker Dev Environments (Docker Inc.)
Version: v0.1.0
Path: /usr/lib/docker/cli-plugins/docker-dev
extension: Manages Docker extensions (Docker Inc.)
Version: v0.2.19
Path: /usr/lib/docker/cli-plugins/docker-extension
init: Creates Docker-related starter files for your project (Docker Inc.)
Version: v0.1.0-beta.4
Path: /usr/lib/docker/cli-plugins/docker-init
sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc.)
Version: 0.6.0
Path: /usr/lib/docker/cli-plugins/docker-sbom
scan: Docker Scan (Docker Inc.)
Version: v0.26.0
Path: /usr/lib/docker/cli-plugins/docker-scan
scout: Command line tool for Docker Scout (Docker Inc.)
Version: v0.12.0
Path: /usr/lib/docker/cli-plugins/docker-scout
WARNING: Plugin "/usr/lib/docker/cli-plugins/docker-compose.14.backup" is not valid: plugin candidate "compose.14.backup" did not match "^[a-z][a-z0-9]*$"
Server:
Containers: 12
Running: 5
Paused: 0
Stopped: 7
Images: 104
Server Version: 24.0.2
Storage Driver: stargz
driver-type: io.containerd.snapshotter.v1
Logging Driver: json-file
Cgroup Driver: cgroupfs
Cgroup Version: 2
Plugins:
Volume: local
Network: bridge host ipvlan macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
Swarm: inactive
Runtimes: io.containerd.runc.v2 runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 3dce8eb055cbb6872793272b4f20ed16117344f8
runc version: v1.1.7-0-g860f061
init version: de40ad0
Security Options:
seccomp
Profile: builtin
cgroupns
Kernel Version: 5.15.49-linuxkit-pr
Operating System: Docker Desktop
OSType: linux
Architecture: x86_64
CPUs: 6
Total Memory: 7.526GiB
Name: docker-desktop
ID: a92cef06-564f-4766-91bd-bc9e839af9fa
Docker Root Dir: /var/lib/docker
Debug Mode: false
HTTP Proxy: http.docker.internal:3128
HTTPS Proxy: http.docker.internal:3128
No Proxy: hubproxy.docker.internal
Experimental: false
Insecure Registries:
hubproxy.docker.internal:5555
127.0.0.0/8
Live Restore Enabled: falseAdditional Info
This works on previous versions of Docker Desktop.
This also works if you turn off the containerd beta
This is boiled down from a much larger repro case.