Skip to content

Revert "chore: remove fake error from expect calls (#28112)"#29271

Merged
mxschmitt merged 1 commit intomicrosoft:mainfrom
mxschmitt:revert-2c3955a28c2af6b97a430dfc97fe756d40fcfbda
Jan 31, 2024
Merged

Revert "chore: remove fake error from expect calls (#28112)"#29271
mxschmitt merged 1 commit intomicrosoft:mainfrom
mxschmitt:revert-2c3955a28c2af6b97a430dfc97fe756d40fcfbda

Conversation

@mxschmitt
Copy link
Contributor

@mxschmitt mxschmitt commented Jan 31, 2024

This reverts commit 2c3955a.

Relates microsoft/playwright-python#2258

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › watch.spec.ts:607:5 › should run CT on indirect deps change

5 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

21233 passed, 577 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 622153d into microsoft:main Jan 31, 2024
github-actions bot added a commit that referenced this pull request Feb 1, 2024
mxschmitt pushed a commit that referenced this pull request Feb 1, 2024
…alls (#28112)" (#29296)

This PR cherry-picks the following commits:

- 622153d

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants