Skip to content

cherry-pick(#29271): Revert "chore: remove fake error from expect calls (#28112)"#29296

Merged
mxschmitt merged 1 commit intorelease-1.41from
cherry-pick-1.41-2024-02-01-17-08-09
Feb 1, 2024
Merged

cherry-pick(#29271): Revert "chore: remove fake error from expect calls (#28112)"#29296
mxschmitt merged 1 commit intorelease-1.41from
cherry-pick-1.41-2024-02-01-17-08-09

Conversation

@playwrightmachine
Copy link
Contributor

@playwrightmachine playwrightmachine commented Feb 1, 2024

This PR cherry-picks the following commits:

@mxschmitt mxschmitt merged commit 414affa into release-1.41 Feb 1, 2024
@mxschmitt mxschmitt deleted the cherry-pick-1.41-2024-02-01-17-08-09 branch February 1, 2024 17:11
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Test results for "tests 1"

5 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-screenshot.spec.ts:642:5 › page screenshot animations › should stop animations that happen right before screenshot
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › components/splitView.spec.tsx:34:5 › should render sidebar first

21118 passed, 574 skipped
✔️✔️✔️

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Test results for "tests 2"

2 fatal errors, not part of any test

73 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/locator-misc-1.spec.ts:28:3 › should hover when Node is removed
⚠️ [chromium] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [chromium] › page/page-mouse.spec.ts:186:3 › should trigger hover state on disabled button
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-screenshot.spec.ts:215:5 › page screenshot › should take fullPage screenshots
⚠️ [chromium] › page/page-set-input-files.spec.ts:132:3 › should upload large file with relative path
⚠️ [chromium] › page/retarget.spec.ts:350:3 › check retargeting
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-evaluate.spec.ts:507:3 › should transfer 100Mb of data from page to node.js
⚠️ [chromium] › library/inspector/cli-codegen-1.spec.ts:22:7 › cli codegen › should click
⚠️ [chromium] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:110:3 › should report navigation requests and responses handled by service worker
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/capabilities.spec.ts:257:3 › requestFullscreen
⚠️ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page
⚠️ [firefox] › library/video.spec.ts:351:5 › screencast › should capture navigation
⚠️ [firefox] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [firefox] › page/page-goto.spec.ts:431:3 › js redirect overrides url bar navigation
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
⚠️ [firefox] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts
⚠️ [firefox] › library/browsercontext-storage-state.spec.ts:76:3 › should round-trip through the file
⚠️ [firefox] › library/tracing.spec.ts:525:5 › should export trace concurrently to second navigation
⚠️ [firefox] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/workers.spec.ts:106:3 › should clear upon navigation
⚠️ [firefox] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/browsercontext-credentials.spec.ts:55:1 › should work with correct credentials @smoke
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/locator-misc-1.spec.ts:28:3 › should hover when Node is removed
⚠️ [chromium] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium] › page/page-drag.spec.ts💯5 › Drag and drop › should cancel on escape
⚠️ [chromium] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [chromium] › library/inspector/cli-codegen-2.spec.ts:518:7 › cli codegen › should fill tricky characters
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/inspector/cli-codegen-1.spec.ts:22:7 › cli codegen › should click
⚠️ [firefox] › library/emulation-focus.spec.ts:65:3 › should not affect mouse event target page
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:444:7 › cli codegen › should generate getByAltText
⚠️ [webkit] › page/elementhandle-misc.spec.ts:27:3 › should hover when Node is removed
⚠️ [webkit] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position
⚠️ [webkit] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:158:7 › cli codegen › should work with TrustedTypes
⚠️ [webkit] › library/inspector/cli-codegen-1.spec.ts:425:7 › cli codegen › should emit single keyup on ArrowDown
⚠️ [webkit] › library/inspector/cli-codegen-3.spec.ts:531:7 › cli codegen › should consume pointer events
⚠️ [webkit] › library/inspector/cli-codegen-python-async.spec.ts:26:5 › should print the correct imports and context options
⚠️ [webkit] › page/page-request-continue.spec.ts:196:5 › post data › should compute content-length from post data
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
1 interrupted ⚠️ [chromium] › library/inspector/pause.spec.ts:33:3 › should not reset timeouts

173981 passed, 7798 skipped, 23 did not run
✔️✔️✔️

Merge workflow run.

@yury-s yury-s mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CQ1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@playwrightmachine @mxschmitt