chore: remove fake error from expect calls#28112
Merged
dgozman merged 1 commit intomicrosoft:mainfrom Nov 14, 2023
Merged
Conversation
We used to have a fake `error` property, so that trace viewer shows failed expectes as such. Today, we have a step for each expect that contains a proper error. Sending the fake error to the client confuses language ports.
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Nov 13, 2023
Contributor
Test results for "tests 1"5 flaky26133 passed, 612 skipped Merge workflow run. |
mxschmitt
added a commit
to mxschmitt/playwright
that referenced
this pull request
Jan 31, 2024
This reverts commit 2c3955a.
mxschmitt
added a commit
that referenced
this pull request
Jan 31, 2024
This reverts commit 2c3955a. Relates microsoft/playwright-python#2258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to have a fake
errorproperty, so that trace viewer shows failed expectes as such. Today, we have a step for each expect that contains a proper error. Sending the fake error to the client confuses language ports.