chore: migrate Go configuration in librarian.yaml#14587
Merged
suztomo merged 2 commits intoMay 14, 2026
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Member
Author
|
config-check fails until Librarian pull request googleapis/librarian#6009 is merged: |
hongalex
approved these changes
May 14, 2026
suztomo
added a commit
to googleapis/librarian
that referenced
this pull request
May 14, 2026
…arian.yaml (#6015) This PR re-applies the Go configuration restructuring from PR #5975, nesting Go configuration under API entries. This PR will be merged right before the companion configuration migration in google-cloud-go: googleapis/google-cloud-go#14587 is merged. <details> <summary>This temporarily skips the integration test using google-cloud-go.</summary> Here is how GitHub Actions handles the subsequent `create-issue-on-failure` job: ```yaml create-issue-on-failure: needs: [integration] if: ${{ always() && contains(needs.*.result, 'failure') && github.event_name == 'push' && github.ref == 'refs/heads/main' }} ``` 1. **Dependency State**: Because `integration` has `if: false`, GitHub Actions marks its final status as `skipped`. 2. **Evaluation**: By default, a job is skipped if its `needs` dependency is skipped. However, because `create-issue-on-failure` uses `always()`, GitHub evaluates its `if:` condition. 3. **Result**: The expression `needs.*.result` evaluates to `['skipped']`. Since this array does not contain `'failure'`, the `contains(...)` check evaluates to `false`. As a result, the `create-issue-on-failure` job will be cleanly skipped without creating any false alarm issues or causing workflow errors. </details> Fixes #5471
The pseudo version matches the librarian's commit: googleapis/librarian@a22d6b5
e3c394b to
307dd74
Compare
Member
Author
|
I ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates Go configuration in
librarian.yamlto support nesting Go configuration under API entries. It also sets a temporary pseudo-version for Librarian HEAD so that Librarian's integration test passes immediately after merging the companion Librarian PR googleapis/librarian#6015.config-check fails until Librarian pull request googleapis/librarian#6015 is merged:
invalid version: unknown revision 90c1a7fbb086