Skip to content

chore: migrate Go configuration in librarian.yaml#14587

Merged
suztomo merged 2 commits into
googleapis:mainfrom
suztomo:feat-restructure-go-config-only
May 14, 2026
Merged

chore: migrate Go configuration in librarian.yaml#14587
suztomo merged 2 commits into
googleapis:mainfrom
suztomo:feat-restructure-go-config-only

Conversation

@suztomo

@suztomo suztomo commented May 14, 2026

Copy link
Copy Markdown
Member

This PR migrates Go configuration in librarian.yaml to support nesting Go configuration under API entries. It also sets a temporary pseudo-version for Librarian HEAD so that Librarian's integration test passes immediately after merging the companion Librarian PR googleapis/librarian#6015.

config-check fails until Librarian pull request googleapis/librarian#6015 is merged: invalid version: unknown revision 90c1a7fbb086

)

This migrates Go configuration to nest under API entries and sets a temporary pseudo-version for Librarian HEAD.
@suztomo suztomo requested review from a team as code owners May 14, 2026 18:45
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@suztomo

suztomo commented May 14, 2026

Copy link
Copy Markdown
Member Author

config-check fails until Librarian pull request googleapis/librarian#6009 is merged: invalid version: unknown revision 90c1a7fbb086

@suztomo suztomo marked this pull request as draft May 14, 2026 18:52
@suztomo suztomo changed the title chore: migrate Go configuration in librarian.yaml (#14572) chore: migrate Go configuration in librarian.yaml\ May 14, 2026
@suztomo suztomo changed the title chore: migrate Go configuration in librarian.yaml\ chore: migrate Go configuration in librarian.yaml May 14, 2026
suztomo added a commit to googleapis/librarian that referenced this pull request May 14, 2026
…arian.yaml (#6015)

This PR re-applies the Go configuration restructuring from PR #5975,
nesting Go configuration under API entries. This PR will be merged right
before the companion configuration migration in google-cloud-go:
googleapis/google-cloud-go#14587 is merged.

<details>
<summary>This temporarily skips the integration test using
google-cloud-go.</summary>

Here is how GitHub Actions handles the subsequent
`create-issue-on-failure` job:

```yaml
  create-issue-on-failure:
    needs: [integration]
    if: ${{ always() && contains(needs.*.result, 'failure') && github.event_name == 'push' && github.ref == 'refs/heads/main' }}
```

1. **Dependency State**: Because `integration` has `if: false`, GitHub
Actions marks its final status as `skipped`.
2. **Evaluation**: By default, a job is skipped if its `needs`
dependency is skipped. However, because `create-issue-on-failure` uses
`always()`, GitHub evaluates its `if:` condition.
3. **Result**: The expression `needs.*.result` evaluates to
`['skipped']`. Since this array does not contain `'failure'`, the
`contains(...)` check evaluates to `false`.

As a result, the `create-issue-on-failure` job will be cleanly skipped
without creating any false alarm issues or causing workflow errors.
</details>

Fixes #5471
@suztomo suztomo force-pushed the feat-restructure-go-config-only branch from e3c394b to 307dd74 Compare May 14, 2026 22:46
@suztomo

suztomo commented May 14, 2026

Copy link
Copy Markdown
Member Author

I ran go run github.com/googleapis/librarian/cmd/librarian@v0.13.2-0.20260514223035-a22d6b5a1329 generate --all and there's no diff.

@suztomo suztomo marked this pull request as ready for review May 14, 2026 22:52
@suztomo suztomo merged commit c5aaedc into googleapis:main May 14, 2026
11 checks passed
@suztomo suztomo deleted the feat-restructure-go-config-only branch May 14, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants