feat(internal/librarian/golang): restructure Go configuration in librarian.yaml#6015
Merged
suztomo merged 19 commits intoMay 14, 2026
Merged
Conversation
This removes support for top-level Go defaults (Issue googleapis#5246) to focus this branch solely on nesting Go configuration under API entries (Issue googleapis#5471).
With Go configuration now nested directly under API entries (Issue googleapis#5471), the API path is always known from the containing API structure. Removing GoAPI.Path eliminates redundancy and prevents potential state drift.
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the configuration schema by moving Go-specific API configurations from a central list in GoModule directly into the API struct. This change simplifies the relationship between general API definitions and language-specific overrides. The refactor includes updates to the core configuration types, the generation logic, and extensive updates to the test suites. I have no feedback to provide as there were no review comments to assess.
This avoids integration test failures on main when Librarian merges before google-cloud-go.
noahdietz
approved these changes
May 14, 2026
suztomo
added a commit
to googleapis/google-cloud-go
that referenced
this pull request
May 14, 2026
This PR migrates Go configuration in `librarian.yaml` to support nesting Go configuration under API entries. It also sets a temporary pseudo-version for Librarian HEAD so that Librarian's integration test passes immediately after merging the companion Librarian PR googleapis/librarian#6015.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-applies the Go configuration restructuring from PR #5975, nesting Go configuration under API entries. This PR will be merged right before the companion configuration migration in google-cloud-go: googleapis/google-cloud-go#14587 is merged.
This temporarily skips the integration test using google-cloud-go.
Here is how GitHub Actions handles the subsequent
create-issue-on-failurejob:integrationhasif: false, GitHub Actions marks its final status asskipped.needsdependency is skipped. However, becausecreate-issue-on-failureusesalways(), GitHub evaluates itsif:condition.needs.*.resultevaluates to['skipped']. Since this array does not contain'failure', thecontains(...)check evaluates tofalse.As a result, the
create-issue-on-failurejob will be cleanly skipped without creating any false alarm issues or causing workflow errors.Fixes #5471