feat(internal/librarian/golang): restructure Go configuration in librarian.yaml (#5471)#6009
Merged
suztomo merged 17 commits intoMay 14, 2026
Merged
Conversation
This removes support for top-level Go defaults (Issue googleapis#5246) to focus this branch solely on nesting Go configuration under API entries (Issue googleapis#5471).
With Go configuration now nested directly under API entries (Issue googleapis#5471), the API path is always known from the containing API structure. Removing GoAPI.Path eliminates redundancy and prevents potential state drift.
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the configuration schema by moving the Go-specific API configuration (GoAPI) from a list within the GoModule struct directly into the API struct. This change simplifies the association between an API path and its Go-specific settings. Corresponding updates were made to the documentation, configuration parsing, generation logic, and the entire test suite to accommodate this structural shift. I have no feedback to provide as there were no review comments to assess.
Member
Author
|
I accidentally merged this. Reverting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-applies the Go configuration restructuring from PR #5975, nesting Go configuration under API entries. This PR will be merged concurrently with the companion configuration migration in google-cloud-go.