chore: add linter that denies importing math/rand#270
Merged
mauri870 merged 2 commits intoelastic:mainfrom Feb 3, 2025
Merged
Conversation
kruskall
approved these changes
Jan 31, 2025
Collaborator
💚 Build Succeeded
History
cc @mauri870 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
In order to ensure consistency between beats, elastic-agent and libs this commit migrates from math/rand to the newer math/rand/v2 package as well as introducing a linter that catches math/rand imports in Go files.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Logs
Offending code gets warned like this:
file.go:24:2: import 'math/rand' is not allowed from list 'main': superseded by math/rand/v2 (depguard) "math/rand"