chore: add linter that catches math/rand imports#42513
Merged
mauri870 merged 3 commits intoelastic:mainfrom Feb 5, 2025
Merged
chore: add linter that catches math/rand imports#42513mauri870 merged 3 commits intoelastic:mainfrom
mauri870 merged 3 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
|
6 tasks
AndersonQ
approved these changes
Feb 4, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
(cherry picked from commit 8cb39a0)
6 tasks
mauri870
added a commit
that referenced
this pull request
Feb 5, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
(cherry picked from commit 8cb39a0)
6 tasks
pierrehilbert
pushed a commit
that referenced
this pull request
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This is a follow up to #42025 that migrated from math/rand to the newer math/rand/v2 package. Currently there is nothing preventing contributors to commiting code using math/rand and regressing these changes.
There is still code in beats that use math/rand, but it is mainly in tests. Since the linter only runs on new code I'm not fixing it here.
Introduce a linter that catches math/rand imports in Go files.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Logs
Offending code gets warned like this:
filebeat/input/filestream/internal/task/group_test.go:24:2: import 'math/rand' is not allowed from list 'main': superseded by math/rand/v2 (depguard) "math/rand"