Skip to content

chore: add linter that denies importing math/rand#6650

Merged
mauri870 merged 1 commit intoelastic:mainfrom
mauri870:golangci-lint-math-rand
Jan 30, 2025
Merged

chore: add linter that denies importing math/rand#6650
mauri870 merged 1 commit intoelastic:mainfrom
mauri870:golangci-lint-math-rand

Conversation

@mauri870
Copy link
Copy Markdown
Member

@mauri870 mauri870 commented Jan 30, 2025 •
edited
Loading

What does this PR do?

We had previous PRs at #5335 and elastic/beats#42025 moving away from math/rand to the newer math/rand/v2 package. Currently there is nothing preventing contributors to commiting code using math/rand and regressing these changes.

Introduce a linter that catches math/rand imports in Go files.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Cleanup backport-8.x Automated backport to the 8.x branch with mergify labels Jan 30, 2025
@mauri870 mauri870 self-assigned this Jan 30, 2025
@mauri870 mauri870 requested a review from a team as a code owner January 30, 2025 14:55
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 30, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870
Copy link
Copy Markdown
Member Author

mauri870 commented Jan 30, 2025

/test

leehinman
leehinman approved these changes Jan 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You.

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Jan 30, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mauri870 mauri870 merged commit cc84f9e into elastic:main Jan 30, 2025
mergify bot pushed a commit that referenced this pull request Jan 30, 2025
@mauri870 @mergify
chore: add linter that denies importing math/rand (#6650)
1b3464b 
(cherry picked from commit cc84f9e)
@mergify mergify bot mentioned this pull request Jan 30, 2025
Merged
8 tasks
This was referenced Jan 30, 2025
Merged
Merged
mauri870 added a commit that referenced this pull request Jan 31, 2025
@mergify @mauri870
chore: add linter that denies importing math/rand (#6650) (#6657)
de0cc30 
(cherry picked from commit cc84f9e)

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
This was referenced Feb 5, 2025
Merged
Merged
@mauri870 mauri870 added the backport-9.0 Automated backport to the 9.0 branch label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leehinman leehinman leehinman approved these changes

@swiatekm swiatekm swiatekm approved these changes

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@mauri870 mauri870

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch Cleanup skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mauri870 @elasticmachine @leehinman @swiatekm