Skip to content

[8.x](backport #6650) chore: add linter that denies importing math/rand#6657

Merged
mauri870 merged 1 commit into8.xfrom
mergify/bp/8.x/pr-6650
Jan 31, 2025
Merged

[8.x](backport #6650) chore: add linter that denies importing math/rand#6657
mauri870 merged 1 commit into8.xfrom
mergify/bp/8.x/pr-6650

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jan 30, 2025

What does this PR do?

We had previous PRs at #5335 and elastic/beats#42025 moving away from math/rand to the newer math/rand/v2 package. Currently there is nothing preventing contributors to commiting code using math/rand and regressing these changes.

Introduce a linter that catches math/rand imports in Go files.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues


This is an automatic backport of pull request #6650 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner January 30, 2025 18:22
@mergify mergify bot added the backport label Jan 30, 2025
@mergify mergify bot requested review from andrzej-stencel and kaanyalti and removed request for a team January 30, 2025 18:22
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mauri870 mauri870 requested review from mauri870 and removed request for andrzej-stencel and kaanyalti January 31, 2025 11:01
@mauri870 mauri870 merged commit de0cc30 into 8.x Jan 31, 2025
@mauri870 mauri870 deleted the mergify/bp/8.x/pr-6650 branch January 31, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants