Skip to content

[release/1.7] update runners to ubuntu 24.04#11802

Merged
estesp merged 5 commits intocontainerd:release/1.7from
austinvazquez:update-gha-runner-image-in-1.7-ci
Jul 16, 2025
Merged

[release/1.7] update runners to ubuntu 24.04#11802
estesp merged 5 commits intocontainerd:release/1.7from
austinvazquez:update-gha-runner-image-in-1.7-ci

Conversation

@austinvazquez
Copy link
Member

@austinvazquez austinvazquez commented May 6, 2025

Partial cherry-pick of #10217 and #10817

(cherry picked from commit 9077968)

@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review May 6, 2025
@dosubot dosubot bot added the github_actions Pull requests that update GitHub Actions code label May 6, 2025
@akhilerm
Copy link
Member

akhilerm commented May 6, 2025

Can you update the description. Because the binary building job is already at 24.04

@austinvazquez
Copy link
Member Author

@akhilerm, updated. PTAL.

Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vagrant integration[1] and userns[2] test still uses 22.04 . Can those also be updated to 24.04?

@austinvazquez austinvazquez force-pushed the update-gha-runner-image-in-1.7-ci branch from be6dc9f to 16ed701 Compare May 16, 2025 05:08
@austinvazquez austinvazquez force-pushed the update-gha-runner-image-in-1.7-ci branch from 16ed701 to 9fa44b0 Compare May 25, 2025 19:59
@austinvazquez austinvazquez marked this pull request as draft May 25, 2025 20:09
@austinvazquez austinvazquez force-pushed the update-gha-runner-image-in-1.7-ci branch from ce261a0 to a5f852a Compare May 25, 2025 22:33
@austinvazquez austinvazquez force-pushed the update-gha-runner-image-in-1.7-ci branch from a5f852a to 5e4ee9d Compare May 26, 2025 00:01
@austinvazquez austinvazquez changed the title [release/1.7] update release runners to ubuntu 24.04 [release/1.7] update runners to ubuntu 24.04 May 26, 2025
@austinvazquez austinvazquez marked this pull request as ready for review May 26, 2025 17:18
@dosubot dosubot bot added the kind/test label May 26, 2025
@austinvazquez
Copy link
Member Author

@akhilerm, this change is almost ready to go. The last remaining issue is the fuzzing seems to be failing in release/1.7; I haven't been able to pin it down just yet. Going to try to figure that out next.

@akhilerm
Copy link
Member

/retest

Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The fuzz failure seems unrelated

@akhilerm
Copy link
Member

akhilerm commented Jun 1, 2025

This is the change AdamKorcz/instrumentation@d665541 that went into instrumentation before the issues started coming up with CI Fuzz. But not sure how it is affecting only in 1.7 branch and not in 2.0 branches, even pinning the version to the same as used in 2.0 does not work . Ref: https://github.com/containerd/containerd/actions/runs/15374434828/job/43257595706?pr=11924 , #11892.

Running the code directly also gives the error

akhil@akhil-ThinkPad-L14:~/A/instrumentation (main)$ go run main.go --target_dir /home/akhil/go/src/github.com/containerd/containerd/images
2025/06/01 17:31:59 internal error: package "archive/tar" without types was imported from "command-line-arguments"
exit status 1

@estesp
Copy link
Member

estesp commented Jul 15, 2025

This can be rebased now as the fuzzer removals have been cherry-picked into release/1.7

akhilerm added 2 commits July 16, 2025 07:28
update all runners except the binary building job to ubuntu-24.04

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
(cherry picked from commit 9077968)
Signed-off-by: Austin Vazquez <austin.vazquez.dev@gmail.com>
Partial cherry-pick of 027414e to
enable vagrant and CRI integration runners to run on ubuntu-24.04
runners.

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
(cherry picked from commit 027414e)
Signed-off-by: Austin Vazquez <austin.vazquez.dev@gmail.com>
akhilerm and others added 3 commits July 16, 2025 07:28
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
(cherry picked from commit 769e0c8)
Signed-off-by: Austin Vazquez <austin.vazquez.dev@gmail.com>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit 4d02217)
Signed-off-by: Austin Vazquez <austin.vazquez.dev@gmail.com>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit 1db0064)
Signed-off-by: Austin Vazquez <austin.vazquez.dev@gmail.com>
@austinvazquez austinvazquez force-pushed the update-gha-runner-image-in-1.7-ci branch from 5e4ee9d to c362e18 Compare July 16, 2025 14:29
@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Jul 16, 2025
@estesp estesp merged commit 2e3eb3d into containerd:release/1.7 Jul 16, 2025
93 of 95 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Jul 16, 2025
@austinvazquez austinvazquez deleted the update-gha-runner-image-in-1.7-ci branch July 16, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code kind/test size/S

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants