Skip to content

ci: enable ubuntu-24 runners#10217

Merged
dmcgowan merged 6 commits intocontainerd:mainfrom
akhilerm:ubuntu-24
Jun 24, 2024
Merged

ci: enable ubuntu-24 runners#10217
dmcgowan merged 6 commits intocontainerd:mainfrom
akhilerm:ubuntu-24

Conversation

@akhilerm
Copy link
Member

@akhilerm akhilerm commented May 13, 2024 •
edited
Loading

  • add ubuntu-24 github action runners into the test matrix
  • all runners have been updated to ubuntu-24 except the job where release binaries are built. Its still kept at ubuntu-20 for maintaining compatibility

Notes to reviewers:

.
edk2 (2023.11-2) unstable; urgency=medium

  * ovmf: Remove dangling symlink to removed 2M image:
    - /usr/share/OVMF/OVMF_CODE.ms.fd
.

@k8s-ci-robot
Copy link

k8s-ci-robot commented May 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@akhilerm
Copy link
Member Author

akhilerm commented May 13, 2024 •
edited
Loading

The runners are not completely deployed from github actions side, hence the jobs queue up for long time https://github.com/actions/runner-images/blob/main/README.md#available-images

UPDATE: 03 Jun 2024
The runners are now completely deployed and issue of job queuing up is resolved.

@akhilerm akhilerm closed this May 13, 2024
@akhilerm akhilerm reopened this May 27, 2024
@akhilerm akhilerm force-pushed the ubuntu-24 branch 2 times, most recently from 7bd4d33 to 8584f8c Compare June 3, 2024 15:06
@akhilerm akhilerm marked this pull request as ready for review June 3, 2024 15:42
@akhilerm akhilerm requested review from AkihiroSuda and fuweid June 3, 2024 15:44
@samuelkarp samuelkarp enabled auto-merge June 3, 2024 21:27
@akhilerm
Copy link
Member Author

akhilerm commented Jun 4, 2024

The vagrant box links for downloading rockylinux/8@v9 given by the vagrantcloud API are returning 404. https://vagrantcloud.com/api/v2/vagrant/rockylinux/8, hence the failure in vagrant test

@akhilerm akhilerm force-pushed the ubuntu-24 branch 2 times, most recently from 7338f55 to 3eb67a9 Compare June 5, 2024 01:50
fuweid
fuweid reviewed Jun 5, 2024
View reviewed changes
akhilerm added 3 commits June 19, 2024 00:07
@akhilerm
enable ubuntu 24 runners
027414e 
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@akhilerm
increase xfs base image size to 300Mb
624aa49 
from xfsprogs 5.19.0, minimum size of xfs volume has to be 300MB

Ref: https://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git/commit/?id=6e0ed3d19c54603f0f7d628ea04b550151d8a262
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@akhilerm
add debian sources for ubuntu-24
769e0c8 
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@akhilerm akhilerm marked this pull request as draft June 18, 2024 20:24
auto-merge was automatically disabled June 18, 2024 20:24

Pull request was converted to draft

@akhilerm
Copy link
Member Author

akhilerm commented Jun 18, 2024

converting to draft as we are still hitting issues with running vagrant on ubuntu-24.

Currently for testing, switched to vagrant for ubuntu22.04 and using it in ubuntu 24.04

@akhilerm
Copy link
Member Author

akhilerm commented Jun 18, 2024

UPDATE: There was a change in ovmf package that removed a symlink, Ref: changelog which may be causing issue with boot up.

edk2 (2023.11-2) unstable; urgency=medium

  * ovmf: Remove dangling symlink to removed 2M image:
    - /usr/share/OVMF/OVMF_CODE.ms.fd

@akhilerm
use vagrant from jammy in noble
1bfdcce 
Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@akhilerm akhilerm force-pushed the ubuntu-24 branch 2 times, most recently from 24bffa7 to 5ca400f Compare June 18, 2024 21:07
@akhilerm
use older version of OVMF package
c25183f 
use ovmf 2022.02-3ubuntu0.22.04.2 so that the OVMF_CODE.fd which vagrant
looks for is still available

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
@akhilerm akhilerm marked this pull request as ready for review June 20, 2024 01:32
@akhilerm
update release runners to ubuntu 24.04
9077968 
update all runners except the binary building job to ubuntu-24.04

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
mikebrow
mikebrow approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan added this pull request to the merge queue Jun 24, 2024
Merged via the queue into containerd:main with commit 7310674 Jun 24, 2024
@akhilerm akhilerm deleted the ubuntu-24 branch June 25, 2024 15:30
@austinvazquez austinvazquez mentioned this pull request May 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuweid fuweid fuweid left review comments

@dmcgowan dmcgowan dmcgowan approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@mikebrow mikebrow mikebrow approved these changes

@samuelkarp samuelkarp Awaiting requested review from samuelkarp

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@akhilerm @k8s-ci-robot @dmcgowan @samuelkarp @AkihiroSuda @mikebrow @fuweid