Reorder workflow to update changelogs first#109
Merged
cryptodev-2s merged 22 commits intomainfrom Dec 4, 2023
Merged
Conversation
mcmire
reviewed
Nov 17, 2023
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Good changes! But there are some tests missing, and I think there's some code we can drop as well.
mcmire
reviewed
Nov 29, 2023
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Nice work. I think all of the pieces are in place, it's just a matter of polishing them a bit. I made some suggestions below.
cryptodev-2s
commented
Nov 29, 2023
mcmire
reviewed
Nov 29, 2023
mcmire
reviewed
Nov 29, 2023
3 tasks
mikesposito
previously approved these changes
Dec 1, 2023
Member
mikesposito
left a comment
There was a problem hiding this comment.
Looks good! I only have a non-blocking suggestion
mcmire
previously approved these changes
Dec 1, 2023
Contributor
mcmire
left a comment
There was a problem hiding this comment.
I just tested this out on the core repo, and it seems everything works as designed, so well done. There are more workflow improvements we could possibly make, but we can add those in future PRs.
mikesposito
approved these changes
Dec 4, 2023
cryptodev-2s
added a commit
to MetaMask/core
that referenced
this pull request
Dec 7, 2023
## Explanation This PR updates the release process to take in considerations recent changes on create-release-branch. - Compel users to release packages with breaking changes alongside their dependents [MetaMask/create-release-branch#101] - Compel users to release new versions of dependencies alongside their dependents [MetaMask/create-release-branch#102] - Reorder workflow to update changelogs first [MetaMask/create-release-branch#109] ## References - Closes #1741 ## Changelog N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder workflow to update changelogs first
Issue: 88