Compel users to release new versions of dependencies alongside their dependents#102
Merged
cryptodev-2s merged 13 commits intomainfrom Oct 11, 2023
Merged
Conversation
Gudahtt
reviewed
Oct 2, 2023
Gudahtt
reviewed
Oct 2, 2023
Gudahtt
reviewed
Oct 2, 2023
Gudahtt
reviewed
Oct 2, 2023
Gudahtt
reviewed
Oct 2, 2023
mcmire
reviewed
Oct 5, 2023
cryptodev-2s
commented
Oct 10, 2023
mcmire
reviewed
Oct 10, 2023
Contributor
mcmire
left a comment
There was a problem hiding this comment.
This is looking better! Just some user experience tweaks and attempts to simplify the logic so it's a bit easier to parse.
mcmire
reviewed
Oct 10, 2023
legobeat
previously requested changes
Oct 10, 2023
Contributor
legobeat
left a comment
There was a problem hiding this comment.
https://github.com/MetaMask/create-release-branch/actions/runs/6475554242/job/17582760139?pr=102
Error: src/package-manifest.ts(32,12): error TS1170: A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type.
Error: src/package-manifest.ts(32,39): error TS2339: Property 'Dependencies' does not exist on type 'typeof ManifestFieldNames'.
Error: src/package-manifest.ts(33,12): error TS1170: A computed property name in a type literal must refer to an expression whose type is a literal type or a 'unique symbol' type.
Error: src/package-manifest.ts(33,39): error TS2339: Property 'PeerDependencies' does not exist on type 'typeof ManifestFieldNames'.
Error: src/package-manifest.ts(88,30): error TS2339: Property 'Dependencies' does not exist on type 'typeof ManifestFieldNames'.
Error: src/package-manifest.ts(92,30): error TS2339: Property 'PeerDependencies' does not exist on type 'typeof ManifestFieldNames'.
Error: src/package-manifest.ts(306,33): error TS2694: Namespace '"/home/runner/work/create-release-branch/create-release-branch/node_modules/@metamask/action-utils/dist/package-utils".ManifestFieldNames' has no exported member 'Dependencies'.
Error: src/package-manifest.ts(307,33): error TS2694: Namespace '"/home/runner/work/create-release-branch/create-release-branch/node_modules/@metamask/action-utils/dist/package-utils".ManifestFieldNames' has no exported member 'PeerDependencies'.
Error: src/package-manifest.ts(354,31): error TS2339: Property 'Dependencies' does not exist on type 'typeof ManifestFieldNames'.
Error: src/package-manifest.ts(359,31): error TS2339: Property 'PeerDependencies' does not exist on type 'typeof ManifestFieldNames'.
Error: src/package-manifest.ts(367,32): error TS2339: Property 'Dependencies' does not exist on type 'typeof ManifestFieldNames'.
Error: src/package-manifest.ts(368,32): error TS2339: Property 'PeerDependencies' does not exist on type 'typeof ManifestFieldNames'.
Error: src/release-specification.ts(218,17): error TS2339: Property 'dependencies' does not exist on type 'ValidatedPackageManifest'.
Error: src/release-specification.ts(218,31): error TS2339: Property 'peerDependencies' does not exist on type 'ValidatedPackageManifest'.
Error: src/release-specification.ts(328,36): error TS2339: Property 'dependencies' does not exist on type 'ValidatedPackageManifest'.
Error: src/release-specification.ts(329,36): error TS2339: Property 'peerDependencies' does not exist on type 'ValidatedPackageManifest'.
Error: Process completed with exit code 2.
https://github.com/MetaMask/action-utils/blob/main/src/package-utils.ts#L20
mcmire
reviewed
Oct 10, 2023
mcmire
reviewed
Oct 10, 2023
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Suggestions to fix the TypeScript errors.
mcmire
reviewed
Oct 11, 2023
Contributor
mcmire
left a comment
There was a problem hiding this comment.
This looks great! Just two more things and then I think we can call this good:
mcmire
approved these changes
Oct 11, 2023
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Sorry this took so long and thanks for sticking with it. Looks good now!
This was referenced Nov 8, 2023
3 tasks
cryptodev-2s
added a commit
to MetaMask/core
that referenced
this pull request
Dec 7, 2023
## Explanation This PR updates the release process to take in considerations recent changes on create-release-branch. - Compel users to release packages with breaking changes alongside their dependents [MetaMask/create-release-branch#101] - Compel users to release new versions of dependencies alongside their dependents [MetaMask/create-release-branch#102] - Reorder workflow to update changelogs first [MetaMask/create-release-branch#109] ## References - Closes #1741 ## Changelog N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Compel users to release new versions of dependencies alongside their dependents
Issue: 91