Skip to content

Update releasing process#3592

Merged
cryptodev-2s merged 14 commits intomainfrom
update-release-process-documentation
Dec 7, 2023
Merged

Update releasing process#3592
cryptodev-2s merged 14 commits intomainfrom
update-release-process-documentation

Conversation

@cryptodev-2s
Copy link
Copy Markdown
Contributor

@cryptodev-2s cryptodev-2s commented Nov 30, 2023

Explanation

This PR updates the release process to take in considerations recent changes on create-release-branch.

References

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@cryptodev-2s cryptodev-2s requested a review from a team as a code owner November 30, 2023 15:44
@cryptodev-2s cryptodev-2s added the team-wallet-framework Deprecated: Please use `team-core-platform` instead. label Nov 30, 2023
@cryptodev-2s cryptodev-2s self-assigned this Nov 30, 2023
mikesposito
mikesposito reviewed Dec 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! I left some suggestions

mikesposito
mikesposito previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two more non blocking suggestions, but it looks good

@mikesposito
Copy link
Copy Markdown
Member

mikesposito commented Dec 4, 2023 •
edited
Loading

Should we wait for the create-release-branch package to be released and updated in core before merging this?

Perhaps we can bump the package in this PR, so that we effectively change the release process along with the docs

mcmire
mcmire reviewed Dec 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @mikesposito that we will want to wait until we make a new release of create-release-branch, after which we can bump the version in this repo, but I've made some suggestions in the meantime.

mcmire
mcmire reviewed Dec 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more suggestions below. Also, do you want to update create-release-branch in this branch?

@socket-security
Copy link
Copy Markdown

socket-security bot commented Dec 6, 2023 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/create-release-branch 1.1.0...2.0.1 None +1/-0 429 kB

@socket-security
Copy link
Copy Markdown

socket-security bot commented Dec 6, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/create-release-branch@2.0.1

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@mikesposito
Copy link
Copy Markdown
Member

mikesposito commented Dec 7, 2023 

@SocketSecurity ignore @metamask/create-release-branch@2.0.1

The package version 2.0.1 has been published ~30 mins ago: https://www.npmjs.com/package/@metamask/create-release-branch/v/2.0.1?activeTab=versions

mikesposito
mikesposito approved these changes Dec 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cryptodev-2s cryptodev-2s merged commit d7bc126 into main Dec 7, 2023
@cryptodev-2s cryptodev-2s deleted the update-release-process-documentation branch December 7, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmire mcmire mcmire left review comments

@mikesposito mikesposito mikesposito approved these changes

Assignees

@cryptodev-2s cryptodev-2s

Labels

team-wallet-framework Deprecated: Please use `team-core-platform` instead.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update creating partial release documentation

3 participants

@cryptodev-2s @mikesposito @mcmire