Compel users to release packages with breaking changes alongside their dependents#101
Conversation
eff572d to
33d8a21
Compare
Gudahtt
left a comment
There was a problem hiding this comment.
Looks great! Left a few suggestions, the most important of which is ensuring that packages set to null still produce this error
mcmire
left a comment
There was a problem hiding this comment.
Sorry it took me so long to get to this PR. I was unable to get to the end of this PR today, but would definitely like to take a closer look Monday.
…to-release-dependents
There was a problem hiding this comment.
I have a few more suggestions for making this code a bit easier to read, but I know I've also suggested refactoring this code, so considering you've been waiting on this PR for a while, that's something we can put off. The logic at least seems correct here, so feel free to merge!
mcmire
left a comment
There was a problem hiding this comment.
Looks good! Again sorry for the long wait on this.
## Explanation This PR updates the release process to take in considerations recent changes on create-release-branch. - Compel users to release packages with breaking changes alongside their dependents [MetaMask/create-release-branch#101] - Compel users to release new versions of dependencies alongside their dependents [MetaMask/create-release-branch#102] - Reorder workflow to update changelogs first [MetaMask/create-release-branch#109] ## References - Closes #1741 ## Changelog N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
This PR Compel users to release packages with breaking changes alongside their dependents.
Issue: 90