Fix custom function parameter binding for SQL and JavaScript functions by Copilot · Pull Request #3049 · ArcadeData/arcadedb

Copilot · 2025-12-17T20:04:28Z

What does this PR do?

Fixes parameter handling in custom functions where SQL functions returned null for all parameter references and JavaScript functions threw ClassCastException.

Motivation

Custom functions defined via DEFINE FUNCTION were broken:

-- Previously returned null
DEFINE FUNCTION my.getBeerId "SELECT @rid FROM Beer WHERE name=:a" PARAMETERS [a] LANGUAGE sql
SELECT `my.getBeerId`('Hocus Pocus')

-- Previously threw ClassCastException
DEFINE FUNCTION my.returnInputJS "return a" PARAMETERS [a] LANGUAGE js
SELECT `my.returnInputJS`('Hocus Pocus')

Related issues

Addresses GitHub issue regarding custom function arguments.

Additional Notes

Changes:

SQLFunctionDefinition: Added parameter names field; bind parameters to Map using SQL named parameter syntax (:paramName)
JavascriptFunctionDefinition: Serialize Java values to JavaScript source with proper quoting/escaping; backward compatible with JSON strings and pre-quoted strings
DefineFunctionStatement: Pass parameter names to both SQL and JS function constructors

Testing:

Added CustomFunctionParametersTest (9 tests) and GitHubIssueCustomFunctionTest (4 tests). All 243 function-related tests pass.

Checklist

I have run the build using mvn clean package command
My unit tests cover both failure and success scenarios

Original prompt

This section details on the original issue you should resolve

<issue_title>Bug: Custom function with arguments</issue_title>
<issue_description>Version: 25.11.1

Steps to reproduce

Spin up the sample dataset in a Docker container:
docker run --rm -p 2480:2480 -p 2424:2424 -v ./data:/data -e JAVA_OPTS="-Darcadedb.server.databaseDirectory=/data -Darcadedb.server.name=ArcadeDB_0 -Darcadedb.server.rootPassword=playwithdata -Darcadedb.serverMetrics=true -Darcadedb.serverMetrics.logging=true -Darcadedb.server.mode=development" arcadedata/arcadedb:25.11.1
Case 1:

In the console and using the Imported dataset, create a function to retrieve data using a string argument:
DEFINE FUNCTION my.getBeerId "SELECT @rid AS result FROM `Beer` WHERE name=a" PARAMETERS [a] LANGUAGE sql
Attempt to retrieve an ID using the newly created function:
SELECT `my.getBeerId`('"Hocus Pocus"')
Observe the null result

Case 2:

Define a function to return the input directly:
DEFINE FUNCTION my.returnInput "SELECT a AS result" PARAMETERS [a] LANGUAGE sql
Run the function:
SELECT `my.returnInput`('"Hocus Pocus"')
Observe the null result

Case 3:

Attempt to define a JS version of the previous function:
DEFINE FUNCTION my.returnInputJS "return a" PARAMETERS [a] LANGUAGE js
Observe the error:
class com.arcadedb.function.polyglot.JavascriptFunctionDefinition cannot be cast to class com.arcadedb.function.sql.SQLFunctionDefinition (com.arcadedb.function.polyglot.JavascriptFunctionDefinition and com.arcadedb.function.sql.SQLFunctionDefinition are in unnamed module of loader 'app')
Observation

It would be good if strings didn't need to be double quoted when supplied as arguments, if this is possible?</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Bug: Custom function with arguments #3046

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: lvca <312606+lvca@users.noreply.github.com>

…S functions Co-authored-by: lvca <312606+lvca@users.noreply.github.com>

mergify · 2025-12-17T20:23:32Z

🧪 CI Insights

Here's what we observed from your CI run for 8fa60d6.

🟢 All jobs passed!

But CI Insights is watching 👀

Co-authored-by: lvca <312606+lvca@users.noreply.github.com>

…ling Co-authored-by: lvca <312606+lvca@users.noreply.github.com>

….1 [skip ci] Bumps [com.arcadedb:arcadedb-network](https://github.com/ArcadeData/arcadedb) from 25.11.1 to 25.12.1. Release notes *Sourced from [com.arcadedb:arcadedb-network's releases](https://github.com/ArcadeData/arcadedb/releases).* > 25.12.1 > ------- > > ArcadeDB 25.12.1 Release Notes > ============================== > > We're excited to announce the release of ArcadeDB v25.12.1! This release includes significant bug fixes, new features, performance improvements, and dependency updates. > > Highlights > ---------- > > ### Vector Search Enhancements > > * **Fixed critical vector quantization bug** ([#3052](https://redirect.github.com/ArcadeData/arcadedb/issues/3052), [#3053](https://redirect.github.com/ArcadeData/arcadedb/issues/3053)) - INT8 and BINARY vector quantization now works correctly across all dimensions > * **New filtered vector search** ([#3071](https://redirect.github.com/ArcadeData/arcadedb/issues/3071), [#3072](https://redirect.github.com/ArcadeData/arcadedb/issues/3072)) - LSMVectorIndex now supports filtered searches for more precise queries > * **Better vector type support** ([#3090](https://redirect.github.com/ArcadeData/arcadedb/issues/3090)) - Added support for `List<Float>` in vector indexes > * **Improved compression** ([#2911](https://redirect.github.com/ArcadeData/arcadedb/issues/2911)) - Enhanced compression for LSM vector indexes > * **Fixed HNSW graph persistence** ([#2916](https://redirect.github.com/ArcadeData/arcadedb/issues/2916)) - Ensures JVector HNSW graph file is properly closed and flushed to disk > > ### SQL and Query Improvements > > * **Fixed IF statement execution** ([#2775](https://redirect.github.com/ArcadeData/arcadedb/issues/2775)) - SQL scripts with IF statements now execute correctly from console > * **Fixed index creation with IF NOT EXISTS** ([#1819](https://redirect.github.com/ArcadeData/arcadedb/issues/1819)) - Console no longer errors when creating existing indexes with IF NOT EXISTS clause > * **Custom function parameter binding** ([#3046](https://redirect.github.com/ArcadeData/arcadedb/issues/3046), [#3049](https://redirect.github.com/ArcadeData/arcadedb/issues/3049)) - Fixed parameter binding for SQL and JavaScript custom functions > * **SQL method consistency** ([#2964](https://redirect.github.com/ArcadeData/arcadedb/issues/2964), [#2967](https://redirect.github.com/ArcadeData/arcadedb/issues/2967)) - `values()` method now behaves consistently with `keys()` method > * **CONTAINSANY index fix** ([#3051](https://redirect.github.com/ArcadeData/arcadedb/issues/3051)) - Fixed index usage for lists of embedded documents with CONTAINSANY > > ### Transaction Management > > * **Revised transaction logic** ([#3074](https://redirect.github.com/ArcadeData/arcadedb/issues/3074)) - Improved transaction handling and consistency > * **Fixed edge index invalidation** ([#3091](https://redirect.github.com/ArcadeData/arcadedb/issues/3091)) - Edge indexes now remain valid in edge-case scenarios > > ### New Features > > * **Database size API** ([#3045](https://redirect.github.com/ArcadeData/arcadedb/issues/3045)) - Added new `database.getSize()` API method > * **Version display enhancement** ([#2905](https://redirect.github.com/ArcadeData/arcadedb/issues/2905)) - Server log version number now displayed consistently > > What's Changed > -------------- > > ### Bug Fixes > > * Fix INT8 and BINARY vector quantization offset bug in LSMVectorIndex page loading by [`@Copilot`](https://github.com/Copilot) in [ArcadeData/arcadedb#3053](https://redirect.github.com/ArcadeData/arcadedb/pull/3053) > * fix: revert SQL grammar changes and disable deep level JSON insert tests by [`@robfrank`](https://github.com/robfrank) in [ArcadeData/arcadedb#2961](https://redirect.github.com/ArcadeData/arcadedb/pull/2961) > * [#2915](https://redirect.github.com/ArcadeData/arcadedb/issues/2915) fix: ensure Jvector HNSW graph file is closed and flushed to disk on database close by [`@robfrank`](https://github.com/robfrank) in [ArcadeData/arcadedb#2916](https://redirect.github.com/ArcadeData/arcadedb/pull/2916) > * fix: make values method behave like keys method by [`@gramian`](https://github.com/gramian) in [ArcadeData/arcadedb#2967](https://redirect.github.com/ArcadeData/arcadedb/pull/2967) > * Fix custom function parameter binding for SQL and JavaScript functions by [`@Copilot`](https://github.com/Copilot) in [ArcadeData/arcadedb#3049](https://redirect.github.com/ArcadeData/arcadedb/pull/3049) > * fix CONTAINSANY index use for lists of embedded documents by [`@gramian`](https://github.com/gramian) in [ArcadeData/arcadedb#3051](https://redirect.github.com/ArcadeData/arcadedb/pull/3051) > * fix: support List in vector index by [`@szekelyszabi`](https://github.com/szekelyszabi) in [ArcadeData/arcadedb#3090](https://redirect.github.com/ArcadeData/arcadedb/pull/3090) > > ### Features > > * Show version number same as in server log by [`@gramian`](https://github.com/gramian) in [ArcadeData/arcadedb#2905](https://redirect.github.com/ArcadeData/arcadedb/pull/2905) > * feat: added new `database.getSize()` api by [`@lvca`](https://github.com/lvca) in [ArcadeData/arcadedb#3045](https://redirect.github.com/ArcadeData/arcadedb/pull/3045) > * Add filtered vector search support to LSMVectorIndex by [`@Copilot`](https://github.com/Copilot) in [ArcadeData/arcadedb#3072](https://redirect.github.com/ArcadeData/arcadedb/pull/3072) > * add stars chart by [`@robfrank`](https://github.com/robfrank) in [ArcadeData/arcadedb#3084](https://redirect.github.com/ArcadeData/arcadedb/pull/3084) > > ### Performance Improvements > > * Lsm vector fix by [`@lvca`](https://github.com/lvca) in [ArcadeData/arcadedb#2907](https://redirect.github.com/ArcadeData/arcadedb/pull/2907) > * perf: improved compression with lsm vectors by [`@lvca`](https://github.com/lvca) in [ArcadeData/arcadedb#2911](https://redirect.github.com/ArcadeData/arcadedb/pull/2911) ... (truncated) Commits * [`6290454`](ArcadeData/arcadedb@6290454) Set release version to 25.12.1 * [`5bdbdfa`](ArcadeData/arcadedb@5bdbdfa) chore: removed system.out * [`5764b95`](ArcadeData/arcadedb@5764b95) fix: deletion of light edge after last fix * [`a81163a`](ArcadeData/arcadedb@a81163a) fix: avoid reuse of deleted record in same tx * [`a42ae5e`](ArcadeData/arcadedb@a42ae5e) perf: avoid conversion of float[] into List<Float> in SQL engine * [`c8fb3e5`](ArcadeData/arcadedb@c8fb3e5) chore: refactoring conversion functions to float[] in a centralized method * [`de9bfcf`](ArcadeData/arcadedb@de9bfcf) fix: support List<Float> in vector index ([#3090](https://redirect.github.com/ArcadeData/arcadedb/issues/3090)) * [`9e964ef`](ArcadeData/arcadedb@9e964ef) Merge branch 'main' of <https://github.com/ArcadeData/arcadedb> * [`07c7d3e`](ArcadeData/arcadedb@07c7d3e) Fixed failing test using java * [`51a058b`](ArcadeData/arcadedb@51a058b) fix CONTAINSANY index use for lists of embedded documents ([#3051](https://redirect.github.com/ArcadeData/arcadedb/issues/3051)) * Additional commits viewable in [compare view](ArcadeData/arcadedb@25.11.1...25.12.1) [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=com.arcadedb:arcadedb-network&package-manager=maven&previous-version=25.11.1&new-version=25.12.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

#3049) * Initial plan * Fix custom function parameter binding for SQL and JavaScript functions Co-authored-by: lvca <312606+lvca@users.noreply.github.com> * Add backward compatibility for JSON and quoted string parameters in JS functions Co-authored-by: lvca <312606+lvca@users.noreply.github.com> * Add tests reproducing the original GitHub issue scenarios - all passing Co-authored-by: lvca <312606+lvca@users.noreply.github.com> * Address code review feedback: improve JSON detection and map key handling Co-authored-by: lvca <312606+lvca@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lvca <312606+lvca@users.noreply.github.com> (cherry picked from commit d555191)

Initial plan

10f1635

Copilot AI assigned Copilot and lvca Dec 17, 2025

Copilot started work on behalf of lvca December 17, 2025 20:05 View session

Copilot AI and others added 2 commits December 17, 2025 20:12

Fix custom function parameter binding for SQL and JavaScript functions

23b027d

Co-authored-by: lvca <312606+lvca@users.noreply.github.com>

Add backward compatibility for JSON and quoted string parameters in J…

27cd3b4

…S functions Co-authored-by: lvca <312606+lvca@users.noreply.github.com>

Copilot AI and others added 2 commits December 17, 2025 20:25

Add tests reproducing the original GitHub issue scenarios - all passing

8c5b308

Co-authored-by: lvca <312606+lvca@users.noreply.github.com>

Address code review feedback: improve JSON detection and map key hand…

8fa60d6

…ling Co-authored-by: lvca <312606+lvca@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix bug in custom function with arguments~~ Fix custom function parameter binding for SQL and JavaScript functions Dec 17, 2025

Copilot AI requested a review from lvca December 17, 2025 20:30

Copilot finished work on behalf of lvca December 17, 2025 20:30

lvca approved these changes Dec 17, 2025

View reviewed changes

lvca marked this pull request as ready for review December 17, 2025 21:20

lvca merged commit d555191 into main Dec 17, 2025
16 of 19 checks passed

lvca deleted the copilot/fix-custom-function-arguments branch December 17, 2025 21:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix custom function parameter binding for SQL and JavaScript functions#3049

Fix custom function parameter binding for SQL and JavaScript functions#3049
lvca merged 5 commits intomainfrom
copilot/fix-custom-function-arguments

Copilot AI commented Dec 17, 2025 •

edited

Loading

Uh oh!

mergify bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Copilot AI commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Related issues

Additional Notes

Checklist

Steps to reproduce

Case 1:

Case 2:

Case 3:

Observation

Comments on the Issue (you are @copilot in this section)

Uh oh!

mergify bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 CI Insights

🟢 All jobs passed!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 17, 2025 •

edited

Loading

mergify bot commented Dec 17, 2025 •

edited

Loading