Skip to content

Update DNSSEC05 implementation#1473

Merged
tgreenx merged 1 commit into
zonemaster:developfrom
tgreenx:update-dnssec05
Nov 14, 2025
Merged

Update DNSSEC05 implementation#1473
tgreenx merged 1 commit into
zonemaster:developfrom
tgreenx:update-dnssec05

Conversation

@tgreenx

@tgreenx tgreenx commented Oct 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Purpose

This PR proposes an update of test case DNSSEC05 implementation.

Context

Test case specification: zonemaster/zonemaster#1409
Test scenarios specification: zonemaster/zonemaster#1410

Changes

  • Update implementation (test case, message tags, profile, DNSSEC algorithms table)
  • Update unit tests
  • Update unit test data

How to test this PR

Unit tests are created and should pass.

@tgreenx tgreenx added this to the v2025.2 milestone Oct 28, 2025
@tgreenx tgreenx added A-TestCase Area: Test case specification or implementation of test case V-Patch Versioning: The change gives an update of patch in version. RC-Features Release category: Features. labels Oct 28, 2025
This was referenced Oct 28, 2025
Merged
Merged
@matsduf

matsduf commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

You do not want to use the new unit test file format introduced by #1467?

matsduf
matsduf requested changes Oct 29, 2025
View reviewed changes

@matsduf matsduf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

"/usr/local/bin/perl" "-Iinc" "-MExtUtils::Manifest=fullcheck" -e fullcheck
No such file: t/Test-dnssec05-A.data
No such file: t/Test-dnssec05-A.t
No such file: t/Test-dnssec05-B.data
No such file: t/Test-dnssec05-B.t
No such file: t/Test-dnssec05-C.data
No such file: t/Test-dnssec05-C.t
No such file: t/Test-dnssec05-D.data
No such file: t/Test-dnssec05-D.t
No such file: t/Test-dnssec05-E.data
No such file: t/Test-dnssec05-E.t
No such file: t/Test-dnssec05-F.data
No such file: t/Test-dnssec05-F.t
No such file: t/Test-dnssec05-G.data
No such file: t/Test-dnssec05-G.t
No such file: t/Test-dnssec05-H.data
No such file: t/Test-dnssec05-H.t
No such file: t/Test-dnssec05-I.data
No such file: t/Test-dnssec05-I.t
No such file: t/Test-dnssec05-J.data
No such file: t/Test-dnssec05-J.t
Not in MANIFEST: t/Test-dnssec05.data
Not in MANIFEST: t/Test-dnssec05.t

@matsduf

matsduf commented Oct 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

For scenario SHARED-IP-1 I get

$ zonemaster-cli --hints=hintfile.zone --test=dnssec05 --level=info --show-testcase --raw SHARED-IP-1.dnssec05.xa                                           
   0.00 INFO     Unspecified    GLOBAL_VERSION  version=v8.0.0                                                                                              
   0.05 INFO     DNSSEC05       DS05_ALGO_OK  algo_descr=ECDSA Curve P-256 with SHA-256; algo_mnemo=ECDSAP256SHA256; algo_num=13; keytag=51298; ns_list=ns1\
a.shared-ip-1.dnssec05.xa/127.15.5.31

but it should be ns_list=ns1a.shared-ip-1.dnssec05.xa/127.15.5.31;ns1b.shared-ip-1.dnssec05.xa/127.15.5.31

@matsduf

matsduf commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

For all athor scenarios I get the correct output when running zonemaster-cli based on this update.

matsduf added a commit to matsduf/zonemaster that referenced this pull request Oct 29, 2025
@matsduf
Updates of the output of zonemaster-cli on the test scenarios based o…
ab71ad4 
…n the update of the implementation in PR zonemaster/zonemaster-engine#1473
matsduf added a commit to matsduf/zonemaster that referenced this pull request Oct 29, 2025
@matsduf
Updates of the output of zonemaster-cli on the test scenarios based o…
56c4f15 
…n the update of the implementation in PR zonemaster/zonemaster-engine#1473
@tgreenx tgreenx marked this pull request as ready for review October 30, 2025 09:54
@tgreenx

tgreenx commented Oct 30, 2025

Copy link
Copy Markdown
Contributor Author

@matsduf All tests now pass and I've addressed your comments, please re-review.

@tgreenx tgreenx requested a review from matsduf October 30, 2025 09:54
@matsduf

matsduf commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

I see that t/translator.t contains the following test that naturally fails after this update:

ok( exists $trans->data->{DNSSEC}{ALGORITHM_OK},    'expected key from module exists' );

@tgreenx

tgreenx commented Oct 30, 2025

Copy link
Copy Markdown
Contributor Author

I see that t/translator.t contains the following test that naturally fails after this update:

ok( exists $trans->data->{DNSSEC}{ALGORITHM_OK},    'expected key from module exists' );

Indeed, fixed.

matsduf
matsduf approved these changes Oct 30, 2025
View reviewed changes

@matsduf matsduf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All scenarios pass.

@tgreenx tgreenx merged commit 5381101 into zonemaster:develop Nov 14, 2025
3 checks passed
@tgreenx tgreenx deleted the update-dnssec05 branch November 14, 2025 09:08
@MichaelTimbert MichaelTimbert added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Dec 8, 2025
@MichaelTimbert

MichaelTimbert commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

Tested and all unit tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matsduf matsduf matsduf approved these changes
@mattias-p mattias-p Awaiting requested review from mattias-p
@tolvmannen tolvmannen Awaiting requested review from tolvmannen
@marc-vanderwal marc-vanderwal Awaiting requested review from marc-vanderwal
@MichaelTimbert MichaelTimbert Awaiting requested review from MichaelTimbert

Assignees

No one assigned

Labels

A-TestCase Area: Test case specification or implementation of test case RC-Features Release category: Features. S-ReleaseTested Status: The PR has been successfully tested in release testing V-Patch Versioning: The change gives an update of patch in version.

Projects

None yet

Milestone

v2025.2

Development

Successfully merging this pull request may close these issues.

3 participants

@tgreenx @matsduf @MichaelTimbert