Updates DNSSEC05 test case specification#1409
Merged
matsduf merged 9 commits intoNov 13, 2025
Merged
Conversation
* Includse explicit msgid. * Matches current template. * New algorithms from IANA and new classifications. * Compacter outputs with only one output for the same key ID.
tgreenx
reviewed
Jul 24, 2025
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
Test procedure LGTM at first glance, otherwise just a few editorial suggestions:
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
tgreenx
reviewed
Oct 28, 2025
Comment on lines
+175
to
+178
| 5. For all messages outputted below, if an IP address in *NS IP* is connected to | ||
| more than one name server name, then all names should be included with the | ||
| message tag if it is specified that name server name and IP address should | ||
| be outputted with the message tag. |
Contributor
There was a problem hiding this comment.
Not needed. Lines 115 to 118 already take care of that peculiarity.
Contributor
Author
There was a problem hiding this comment.
I agree that the extra information about names should be in one place, but on lines 115-118 there is nothing about extra names.
Contributor
|
Implementation in zonemaster/zonemaster-engine#1473. |
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
tgreenx
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates the test case specification for DNSSEC05
Context
Discussions at F2F in July 2025.
The changes in the specification requires an update of the implementation and update of the translations of the messages.
Test scenarios have been created in #1410.
How to test this PR
Review.