Convert Basic00 to be a general specification#942
Conversation
* Formats specification after new template. * Adds explicit normalization of the domain name to be tested. * Adds explicit handling of IDN names.
* Applies new template. * Removes handling of leading or trailing space. * Added description of handling of underscore. * Added links to Unicode database for characters * Updates wording, no other update of logic.
|
@blacksponge, please review again. I have applied the draft template on the test case in this PR. |
hannaeko
left a comment
There was a problem hiding this comment.
just a few remaining typos, otherwise looks good to me
ghost
left a comment
There was a problem hiding this comment.
Beside my comments on some typos, I think this specifications looks good.
|
@mattias-p and @vlevigneron, can you review this? |
| [RFC 1123][RFC 1123#2.1], section 2.1, specifies that a domain name label | ||
| may not start or end with a HYPHEN-MINUS ("-"), only digit or letter. This | ||
| restriction on HYPHEN-MINUS is disregarded in this specification and is assumed | ||
| to be handled in test case [Syntax02]. |
There was a problem hiding this comment.
Do we plan to maybe migrate the SYNTAX02 into BASIC00? I think it would make sense since it can be seen as part of checking that the input domain is valid.
There was a problem hiding this comment.
I do not think we should.
| see the [Severity Level Definitions] document. | ||
|
|
||
| The argument names in the Arguments column lists the arguments used in the | ||
| message. The argument names are defined in the [argument list]. |
There was a problem hiding this comment.
Looking at the logentry_args.md document, it looks like the dlabel is not under the "Defined arguments" section. Maybe update the document as well.
There was a problem hiding this comment.
Chose to define "label" (not "dlabel") in PR zonemaster/zonemaster-engine#1126.
By commit 78732ed to this PR, "dlabel" is replaced by "label".
ddd0f1b to
ba7ed76
Compare
* Adds explicit NFC normalization. * Adds explicit control of empty domain. * Updates handling of LATIN CAPITAL LETTER I WITH DOT ABOVE. * Corrected message tags. * Editorial updates from review comments.
ba7ed76 to
6d94b81
Compare
|
@PNAX, please re-review. |
hannaeko
left a comment
There was a problem hiding this comment.
Looks good to me, thank you for all the edits!
|
A first step to implementation is found in zonemaster/zonemaster-engine#1040 |
|
@blacksponge, can I merge this? Will you continue on zonemaster/zonemaster-engine#1040? By this update, current Basic00 goes away. |
|
Yes you can, the implementation at zonemaster/zonemaster-engine#1040 should be up to date with this specification, I will mark the PR as ready so you review it again |
Issue #614 has requirements on Basic00 that are not met in this PR. See comment in the issue.
Updates 2022-07-11:
As agreed, test case Basic00 is removed and turned into a general specification. That transformation has been done with the following two commits: