URL fragments referring to internal headings in lowercase#1094
Merged
1 commit merged intoSep 5, 2022
Merged
Conversation
tgreenx
approved these changes
Sep 1, 2022
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
Fine with me. Template01 gets updated too so it should be fine for future specification updates.
Contributor
|
Maybe Style Guide should be updated too? (There is an open RP on that #1081.) |
matsduf
approved these changes
Sep 2, 2022
matsduf
added a commit
to matsduf/zonemaster
that referenced
this pull request
Sep 2, 2022
Author
Good point, I've provided an update of the document in a separate PR, see #1095. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When it comes to referring to internal anchors, we used a mix of upper and lower cases in our Markdown documents. It appears that Github handles this well, but other Markdown to HTML engines suffer to link to the related identifier on the page since they are looking for a perfect match (case sensitively).
This PR is about downcasing all fragments in our Markdown documents.
Context
n/a
Changes
Downcase all fragments that refer to internal anchors in our Markdown documents.
How to test this PR
Documentation only. Links with the updated fragments should work properly once rendered.