Skip to content

Add style guide item on autolinks#1081

Merged
mattias-p merged 3 commits into
zonemaster:developfrom
mattias-p:585-styleguide-autolinks
Jun 7, 2023
Merged

Add style guide item on autolinks#1081
mattias-p merged 3 commits into
zonemaster:developfrom
mattias-p:585-styleguide-autolinks

Conversation

@mattias-p

Copy link
Copy Markdown
Member

Purpose

Document how to keep our Markdown documentation compatible with tools other than Github.

Context

Fixes #585.

Changes

Adds an item to the style guide.

How to test this PR

N/A

@mattias-p mattias-p force-pushed the 585-styleguide-autolinks branch from 34d3ecf to 3722adc Compare July 12, 2022 09:39
@mattias-p mattias-p added this to the v2022.2 milestone Jul 12, 2022
Comment thread docs/internal-documentation/maintenance/StyleGuide.md Outdated
Comment on lines +21 to +23
If you forget the angle brackets the URL it is still render as a link on Github
(per [GFM autolink] syntax), but other tools (e.g. link checking tools) are
likely to not recognize it as a link.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of argument can be left out. It should be what, not why.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you apply the rule what is important, but when you change the rule why is important. I found the why to be non-obvious so I thought better to spell it out.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but could the "why" be shorter? E.g.

If the angle brackets are not included, the URL it is render as a link on Github ([GFM autolink] syntax), but other tools may not recognize it as a link.

ghost
ghost previously approved these changes Jul 19, 2022

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the purpose of this suggestion.

"Domain Part"). If a word is an abbreviation, it is usually written with all
capitals, e.g. "DNS".
* When linking to other documents and you want to include the URL in the
rendered text, make sure to put angle brackets around the URL, i.e. use the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it a rule, not a suggestion, i.e. remove "make sure to".

Also, I suggest that the text does not speak to the reader, i.e. replace "you" with passive wording.

@tgreenx tgreenx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can approve when Mats comments are addressed.

@matsduf matsduf modified the milestones: v2022.2, v2023.1 Nov 23, 2022
@mattias-p mattias-p force-pushed the 585-styleguide-autolinks branch from 9c94bfa to ce50efe Compare May 10, 2023 13:52
Comment thread docs/internal/maintenance/StyleGuide.md Outdated

If the angle brackets are not included the URL is still rendered as a link on
Github (per [GFM autolink] syntax), but other tools (e.g. link checking tools)
are may not recognize it as a link.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"are may" --> "may"

To make it shorter I suggest that "(e.g. link checking tools)" is excluded.

@mattias-p mattias-p merged commit 7a5d591 into zonemaster:develop Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants