Rewrite of the specification of DNSSEC03#1189
Merged
Merged
Conversation
This was referenced Jul 28, 2023
Closed
Closed
This was
linked to
issues
Jul 29, 2023
Closed
Closed
matsduf
added a commit
to matsduf/zonemaster
that referenced
this pull request
Jul 30, 2023
tgreenx
reviewed
Aug 1, 2023
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
The specification reads well and I have not found any errors in the Test Procedure.
matsduf
commented
Aug 1, 2023
tgreenx
previously approved these changes
Aug 2, 2023
Contributor
Author
|
@mustafa-alrifaee writes in #1177 (comment):
Both non-zero iteration and non-empty salt will result in message tags (DS03_ILLEGAL_ITERATION_VALUE and DS03_ILLEGAL_SALT_LENGTH, respectively) have ERROR level as default values according to the proposal. @mustafa-alrifaee, doesn't that meet your proposal? |
tgreenx
previously approved these changes
Aug 2, 2023
marc-vanderwal
previously approved these changes
Sep 13, 2023
Contributor
Author
Test zones are now available in #1218. |
Contributor
Author
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Nov 15, 2023
Follows speficiation update (zonemaster/zonemaster#1189). Note that Prefix Suffix List check (step 13.2.2.1) is not yet implemented, as this service is not yet provided by Zonemaster.
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Nov 15, 2023
Follows specifiation update (zonemaster/zonemaster#1189). Note that Prefix Suffix List check (step 13.2.2.1) is not yet implemented, as this service is not yet provided by Zonemaster. Also note that this commit does not update unit tests yet.
tgreenx
reviewed
Nov 15, 2023
tgreenx
added a commit
to tgreenx/zonemaster-engine
that referenced
this pull request
Nov 16, 2023
Follows specifiation update (zonemaster/zonemaster#1189). Note that Prefix Suffix List check (step 13.2.2.1) is not yet implemented, as this service is not yet provided by Zonemaster. Also note that this commit does not update unit tests yet.
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
…ultiple NSEC3 records
tgreenx
previously approved these changes
Nov 21, 2023
tgreenx
reviewed
Nov 21, 2023
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
Contributor
Author
|
@tgreenx and @marc-vanderwal, please re-review. |
marc-vanderwal
approved these changes
Nov 22, 2023
marc-vanderwal
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me!
tgreenx
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This is a complete rewrite of the specification for DNSSEC03:
Context
Resolves #1177, #1047, #1039 and #948. Resolves does not necessarily mean that this PR follow the issues, but when this PR has been completed those issues can be closed.
This PR introduces a new argument name, which means that Argument list must be updated (-> see #1190).
When this PR has been completed, the implementation must also be rewritten.
Test zones are available in #1218.
How to test this PR
Review the specification.